From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52401) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e0TR5-0006ny-LY for guix-patches@gnu.org; Fri, 06 Oct 2017 10:17:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e0TR0-0000a5-Ki for guix-patches@gnu.org; Fri, 06 Oct 2017 10:17:07 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:44773) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e0TR0-0000ZI-Bz for guix-patches@gnu.org; Fri, 06 Oct 2017 10:17:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1e0TR0-000283-0y for guix-patches@gnu.org; Fri, 06 Oct 2017 10:17:02 -0400 Subject: [bug#28720] [PATCH 00/23] Enhance building KDE Frameworks. Resent-Message-ID: From: Thomas Danckaert References: <20171006121420.30821-1-h.goebel@crazy-compilers.com> <20171006121636.30904-1-h.goebel@crazy-compilers.com> Date: Fri, 06 Oct 2017 16:16:20 +0200 In-Reply-To: <20171006121636.30904-1-h.goebel@crazy-compilers.com> (Hartmut Goebel's message of "Fri, 6 Oct 2017 14:16:13 +0200") Message-ID: MIME-Version: 1.0 Content-Type: text/plain List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Hartmut Goebel Cc: 28720@debbugs.gnu.org Hi Hartmut, thanks for your work on this! I think most of these patches are fine. Maybe you can still shorten the commit messages here and there? (I think comments like "Align with the version of other kde-frameworks packages." as you wrote with the prison update, can be left out.) Otherwise I only commented on a few patches, really nitpicking actually... Thomas