From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47455)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1e0TDW-0003uR-3d
	for guix-patches@gnu.org; Fri, 06 Oct 2017 10:03:09 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1e0TDT-0001GS-0q
	for guix-patches@gnu.org; Fri, 06 Oct 2017 10:03:06 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:44750)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1e0TDS-0001G3-Tz
	for guix-patches@gnu.org; Fri, 06 Oct 2017 10:03:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1e0TDS-0001ja-Gh
	for guix-patches@gnu.org; Fri, 06 Oct 2017 10:03:02 -0400
Subject: [bug#28720] [PATCH 08/23] gnu: phonon: Enable building the Qt
	Designer plugin.
Resent-Message-ID: <handler.28720.B28720.15072985776656@debbugs.gnu.org>
From: Thomas Danckaert <post@thomasdanckaert.be>
References: <20171006121636.30904-1-h.goebel@crazy-compilers.com>
	<20171006121636.30904-9-h.goebel@crazy-compilers.com>
Date: Fri, 06 Oct 2017 16:02:38 +0200
In-Reply-To: <20171006121636.30904-9-h.goebel@crazy-compilers.com> (Hartmut
	Goebel's message of "Fri, 6 Oct 2017 14:16:21 +0200")
Message-ID: <cuc8tgobcht.fsf@thomasdanckaert.be>
MIME-Version: 1.0
Content-Type: text/plain
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Hartmut Goebel <h.goebel@crazy-compilers.com>
Cc: 28720@debbugs.gnu.org

Hartmut Goebel <h.goebel@crazy-compilers.com> writes:

> Add native-inputs pkg-config, qttools and update comments.
>
> This enables building the Qt Designer plugin.
>
> * gnu/packages/kde-frameworks.scm (phonon): [native-inputs]: Add pkg-config,
>   qttools.  [arguments]<#configure-flags>: Remove
>   PHONON_INSTALL_QT_EXTENSIONS_INTO_SYSTEM_QT

I'm not sure what this does (or: used to do), so I don't know if this
removal needs a further comment.

> +     ;; TODO: Add bulding the super experimental QML support

There's a typo in your TODO ;-)

Just to comment on something, because otherwise all these patches LGTM (assuming
they still build, which I didn't verify).

Thomas