unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Thomas Danckaert <post@thomasdanckaert.be>
To: Maxim Cournoyer <maxim.cournoyer@gmail.com>
Cc: 28562@debbugs.gnu.org
Subject: [bug#28562] [PATCH] gnu: eudev: Update to 3.2.4 and generate manpages.
Date: Mon, 25 Sep 2017 10:33:42 +0200	[thread overview]
Message-ID: <cuc377bkwih.fsf@thomasdanckaert.be> (raw)
In-Reply-To: <87ingakr83.fsf@gmail.com> (Maxim Cournoyer's message of "Fri, 22 Sep 2017 23:51:08 -0400")

Hi Maxim,

thanks for the patch!

Only one thing: we don't have to substitute the location of autoreconf
in autogen.sh: because autoconf is a native input, its executables are
already in the build environment PATH:

> +     '(#:phases
> +       (modify-phases %standard-phases
> +         (add-before 'configure 'bootstrap
> +           (lambda* (#:key inputs #:allow-other-keys)
> +            (substitute* "autogen.sh"
> +              (("autoreconf")
> +               (string-append (assoc-ref inputs "autoconf")
> +                              "/bin/autoreconf")))

If you agree, I can push with that change (and will try to remember to
push to staging :0) ).

Thomas

  parent reply	other threads:[~2017-09-25  8:34 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-23  3:51 [bug#28562] [PATCH] gnu: eudev: Update to 3.2.4 and generate manpages Maxim Cournoyer
2017-09-23  3:55 ` Maxim Cournoyer
2017-09-25  8:33 ` Thomas Danckaert [this message]
2017-09-25 20:54   ` [bug#28562] [PATCHv2] " Maxim Cournoyer
2017-09-28 18:31     ` Thomas Danckaert
2017-09-28 22:03       ` Maxim Cournoyer
2017-10-04 22:51       ` Marius Bakke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cuc377bkwih.fsf@thomasdanckaert.be \
    --to=post@thomasdanckaert.be \
    --cc=28562@debbugs.gnu.org \
    --cc=maxim.cournoyer@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).