From: Pierre Langlois <pierre.langlois@gmx.com>
To: 32431@debbugs.gnu.org
Subject: [bug#32431] [PATCH] gnu: clementine: Drop dependency on qtwebkit.
Date: Mon, 13 Aug 2018 20:26:21 +0100 [thread overview]
Message-ID: <cubmutqdq5e.fsf@gmx.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 276 bytes --]
Hello guix!
I realised clementine wasn't building because qtwebkit isn't building
either. But, it turns out that while it's an optional dependency
according to CMakeList.txt, it isn't actually used anywhere in the
code. Here's a patch that removes qtwebkit from its inputs.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-clementine-Drop-dependency-on-qtwebkit.patch --]
[-- Type: text/x-patch, Size: 931 bytes --]
From c32d30001676d80bc9c80ece3ee8c31ec9b72592 Mon Sep 17 00:00:00 2001
From: Pierre Langlois <pierre.langlois@gmx.com>
Date: Mon, 13 Aug 2018 09:05:17 +0100
Subject: [PATCH] gnu: clementine: Drop dependency on qtwebkit.
QtWebkit is optionally included in CMakeList.txt but isn't actually used
anywhere in the code.
* gnu/packages/music.scm (clementine)[inputs]: Remove qtwebkit.
---
gnu/packages/music.scm | 1 -
1 file changed, 1 deletion(-)
diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index c5ee4293b..cf1e0f82f 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -281,7 +281,6 @@ score, keyboard, guitar, drum and controller views.")
("pulseaudio" ,pulseaudio)
("qtbase" ,qtbase)
("qtx11extras" ,qtx11extras)
- ("qtwebkit" ,qtwebkit)
("sqlite" ,sqlite-with-fts3)
("sparsehash" ,sparsehash)
("taglib" ,taglib)))
--
2.18.0
[-- Attachment #3: Type: text/plain, Size: 17 bytes --]
Thanks!
Pierre
next reply other threads:[~2018-08-13 19:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-13 19:26 Pierre Langlois [this message]
2018-08-13 20:58 ` [bug#32431] [PATCH] gnu: clementine: Drop dependency on qtwebkit Leo Famulari
2018-08-13 21:12 ` Pierre Langlois
2018-08-14 2:31 ` Leo Famulari
2018-08-14 9:24 ` Pierre Langlois
2018-08-14 21:32 ` Pierre Langlois
2018-08-15 0:42 ` Leo Famulari
2018-08-15 6:57 ` Pierre Langlois
2018-08-15 18:35 ` bug#32431: " Leo Famulari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cubmutqdq5e.fsf@gmx.com \
--to=pierre.langlois@gmx.com \
--cc=32431@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).