From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45302) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fpK9C-0001Ji-BK for guix-patches@gnu.org; Mon, 13 Aug 2018 17:13:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fpK98-000339-8D for guix-patches@gnu.org; Mon, 13 Aug 2018 17:13:06 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:44959) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fpK98-000331-3l for guix-patches@gnu.org; Mon, 13 Aug 2018 17:13:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fpK97-0006yn-UF for guix-patches@gnu.org; Mon, 13 Aug 2018 17:13:01 -0400 Subject: [bug#32431] [PATCH] gnu: clementine: Drop dependency on qtwebkit. Resent-Message-ID: References: <20180813205857.GA15519@jasmine.lan> From: Pierre Langlois In-reply-to: <20180813205857.GA15519@jasmine.lan> Date: Mon, 13 Aug 2018 22:12:14 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Leo Famulari Cc: 32431@debbugs.gnu.org Hi Leo, Leo Famulari writes: > On Mon, Aug 13, 2018 at 08:26:21PM +0100, Pierre Langlois wrote: >> Hello guix! >> >> I realised clementine wasn't building because qtwebkit isn't building >> either. But, it turns out that while it's an optional dependency >> according to CMakeList.txt, it isn't actually used anywhere in the >> code. Here's a patch that removes qtwebkit from its inputs. >> > >> From c32d30001676d80bc9c80ece3ee8c31ec9b72592 Mon Sep 17 00:00:00 2001 >> From: Pierre Langlois >> Date: Mon, 13 Aug 2018 09:05:17 +0100 >> Subject: [PATCH] gnu: clementine: Drop dependency on qtwebkit. >> >> QtWebkit is optionally included in CMakeList.txt but isn't actually used >> anywhere in the code. >> >> * gnu/packages/music.scm (clementine)[inputs]: Remove qtwebkit. > > Thanks! > > Does clementine work for you with this change? For me, it fails like > this: > > > $ clementine > 16:58:17.043 INFO main:315 Clementine-qt5 1.3.1 > 16:58:17.065 WARN Database:275 Couldn't register FTS3 tokenizer : QSqlError("1", "Unable to fetch row", "fts3tokenize disabled") > 16:58:17.066 DEBUG Database:449 Applying database schema update 13 from ":/schema/schema-13.sql" > 16:58:17.066 ERROR Database:577 db error: QSqlError("1", "Unable to fetch row", "unknown tokenizer: unicode") > 16:58:17.066 ERROR Database:578 faulty query: "CREATE VIRTUAL TABLE songs_fts USING fts3(\n ftstitle, ftsalbum, ftsartist, ftsalbumartist, ftscomposer, ftsgenre, ftscomment,\n tokenize=unicode\n)" > 16:58:17.066 ERROR Database:579 bound values: QMap() > __logging_message__16:58:17.066 ERROR unknown Unable to update music library database That's strange, it works OK for me. I'm on master, which branch are you on? IIRC this was the error I was getting when sqlite wasn't built with FTS3 support, hence the sqlite-with-fts3 package (although I'm not sure what it is). Thanks, Pierre