From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46055) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f6Lre-0000sE-Jn for guix-patches@gnu.org; Wed, 11 Apr 2018 15:57:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f6Lra-0006cP-OU for guix-patches@gnu.org; Wed, 11 Apr 2018 15:57:06 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:38632) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1f6Lra-0006cJ-JO for guix-patches@gnu.org; Wed, 11 Apr 2018 15:57:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1f6Lra-0005SC-CW for guix-patches@gnu.org; Wed, 11 Apr 2018 15:57:02 -0400 Subject: [bug#31128] [PATCH] gnu: libmygpo-qt: Update to 1.1.0. Resent-Message-ID: Received: from eggs.gnu.org ([2001:4830:134:3::10]:44814) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f6LqT-000843-4t for guix-patches@gnu.org; Wed, 11 Apr 2018 15:55:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f6LqP-0005Ix-Br for guix-patches@gnu.org; Wed, 11 Apr 2018 15:55:53 -0400 Received: from mout.gmx.net ([212.227.15.19]:40355) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1f6LqO-0005I2-Vq for guix-patches@gnu.org; Wed, 11 Apr 2018 15:55:49 -0400 Received: from labiere ([80.229.147.137]) by mail.gmx.com (mrgmx003 [212.227.17.184]) with ESMTPSA (Nemesis) id 0LgqQQ-1eipXg1j0A-00oBi3 for ; Wed, 11 Apr 2018 21:55:46 +0200 From: Pierre Langlois Date: Wed, 11 Apr 2018 20:55:46 +0100 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: 31128@debbugs.gnu.org --=-=-= Content-Type: text/plain Hi Guix! Here's an update for the libmygpo-qt package, it now builds with Qt5 by default. Thanks, Pierre --=-=-= Content-Type: text/x-patch; charset=utf-8 Content-Disposition: attachment; filename=0001-gnu-libmygpo-qt-Update-to-1.1.0.patch Content-Transfer-Encoding: quoted-printable >From 4e2d4f0606fc14e002f27a3ab59ddba7f64b80a2 Mon Sep 17 00:00:00 2001 From: Pierre Langlois Date: Wed, 11 Apr 2018 09:54:42 +0100 Subject: [PATCH] gnu: libmygpo-qt: Update to 1.1.0. * gnu/packages/music.scm (libmygpo-qt): Update to 1.1.0. [source]: Remove 'patches'. [arguments]: Do not set BUILD_WITH_QT4=3DOFF, it is the default. * gnu/packages/patches/libmygpo-qt-fix-jsoncreatortest.patch: Remove. * gnu/local.mk (dist_patch_DATA): Adjust. --- gnu/local.mk | 1 - gnu/packages/music.scm | 10 ++--- .../libmygpo-qt-fix-jsoncreatortest.patch | 41 ------------------- 3 files changed, 3 insertions(+), 49 deletions(-) delete mode 100644 gnu/packages/patches/libmygpo-qt-fix-jsoncreatortest.pa= tch diff --git a/gnu/local.mk b/gnu/local.mk index 3d4b05c77..38ca94f86 100644 --- a/gnu/local.mk +++ b/gnu/local.mk @@ -860,7 +860,6 @@ dist_patch_DATA =3D \ %D%/packages/patches/libmad-armv7-thumb-pt2.patch \ %D%/packages/patches/libmad-frame-length.patch \ %D%/packages/patches/libmad-mips-newgcc.patch \ - %D%/packages/patches/libmygpo-qt-fix-jsoncreatortest.patch \ %D%/packages/patches/libsndfile-armhf-type-checks.patch \ %D%/packages/patches/libsndfile-CVE-2017-8361-8363-8365.patch \ %D%/packages/patches/libsndfile-CVE-2017-8362.patch \ diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm index bb98f5b6a..aea7395d4 100644 --- a/gnu/packages/music.scm +++ b/gnu/packages/music.scm @@ -11,7 +11,7 @@ ;;; Copyright =C2=A9 2017 Nils Gillmann ;;; Copyright =C2=A9 2017 Rodger Fox ;;; Copyright =C2=A9 2017, 2018 Nicolas Goaziou -;;; Copyright =C2=A9 2017 Pierre Langlois +;;; Copyright =C2=A9 2017, 2018 Pierre Langlois ;;; Copyright =C2=A9 2017 Arun Isaac ;;; Copyright =C2=A9 2017, 2018 Tobias Geerinckx-Rice ;;; Copyright =C2=A9 2018 nee @@ -3846,19 +3846,15 @@ by The Echo Nest.") (define-public libmygpo-qt (package (name "libmygpo-qt") - (version "1.0.9") + (version "1.1.0") (source (origin (method url-fetch) (uri (string-append "http://stefan.derkits.at/files/" "libmygpo-qt/libmygpo-qt." version ".tar= .gz")) (sha256 (base32 - "1wsgh2vjnd52rkvpncj1ycpbp84sj9hh12ija46b42z9mmqf2jm4")) - (patches - (search-patches "libmygpo-qt-fix-jsoncreatortest.patch")))) + "1kg18qrq2rsswgzhl65r3mlyx7kpqg4wwnbp4yiv6svvmadmlxl2")))) (build-system cmake-build-system) - (arguments - '(#:configure-flags '("-DBUILD_WITH_QT4=3DOFF"))) (native-inputs `(("pkg-config" ,pkg-config))) (inputs diff --git a/gnu/packages/patches/libmygpo-qt-fix-jsoncreatortest.patch b/g= nu/packages/patches/libmygpo-qt-fix-jsoncreatortest.patch deleted file mode 100644 index c457d592c..000000000 --- a/gnu/packages/patches/libmygpo-qt-fix-jsoncreatortest.patch +++ /dev/null @@ -1,41 +0,0 @@ -From ebe2323727f8d646590245b0bf06dbc92b5808d6 Mon Sep 17 00:00:00 2001 -From: Golubev Alexander -Date: Tue, 20 Sep 2016 15:33:30 +0400 -Subject: [PATCH] JsonCreatorTest failed due to extra space - -JsonCreatorTest failed with next message: -``` -********* Start testing of mygpo::JsonCreatorTest ********* -Config: Using QTest library 4.8.6, Qt 4.8.6 -PASS : mygpo::JsonCreatorTest::initTestCase() -PASS : mygpo::JsonCreatorTest::testAddRemoveSubsToJSON() -PASS : mygpo::JsonCreatorTest::testSaveSettingsToJSON() -FAIL! : mygpo::JsonCreatorTest::testEpisodeActionListToJSON() Compared va= lues are not the same - Actual (outString2): [{"action":"download","device":"device1","episode"= :"http://episode.url","podcast":"http://podcast.url","timestamp":"1998-01-0= 1T00:01:02"},{"action":"delete","device":"device3","episode":"http://episod= e2.url","podcast":"http://podcast2.url","timestamp":"1920-01-01T12:01:02"},= {"action":"new","device":"foodev","episode":"http://www.podtrac.com","podca= st":"http://leo.am","timestamp":"1998-01-01T00:01:02"},{"action":"play","de= vice":"foodev","episode":"http://www.podtrac.com","podcast":"http://leo.am"= ,"timestamp":"1920-01-01T12:01:02"},{"action":"play","device":"foodev","epi= sode":"http://www.podtrac.com","podcast":"http://leo.am","position":123,"st= arted":10,"timestamp":"1998-01-01T00:01:02","total":321},{"action":"play","= device":"foodev","episode":"http://www.podtrac.com","podcast":"http://leo.a= m","position":10,"timestamp":"1998-01-01T00:01:02"}] - Expected (expected2): [{"action":"download","device":"device1","episode= ":"http://episode.url","podcast":"http: - Loc: [/var/tmp/portage/media-libs/libmygpo-qt-1.0.9-r1/work/libmygpo-qt= -1.0.9/tests/JsonCreatorTest.cpp(138)] -PASS : mygpo::JsonCreatorTest::testRenameDeviceStringToJSON() -PASS : mygpo::JsonCreatorTest::testDeviceSynchronizationListsToJSON() -PASS : mygpo::JsonCreatorTest::cleanupTestCase() -Totals: 6 passed, 1 failed, 0 skipped -********* Finished testing of mygpo::JsonCreatorTest ********* -``` - -This was caused by extra space in the expected string. ---- - tests/JsonCreatorTest.cpp | 2 +- - 1 file changed, 1 insertion(+), 1 deletion(-) - -diff --git a/tests/JsonCreatorTest.cpp b/tests/JsonCreatorTest.cpp -index b15b006..feb03d5 100644 ---- a/tests/JsonCreatorTest.cpp -+++ b/tests/JsonCreatorTest.cpp -@@ -133,7 +133,7 @@ void JsonCreatorTest::testEpisodeActionListToJSON() -=20 - output =3D JsonCreator::episodeActionListToJSON(episodeActions); - QString outString2 =3D QString::fromLatin1( output ).replace( QLatin1St= ring(" "), QLatin1String("") ); -- QString expected2( QLatin1String( "[{\"action\":\"download\",\"device\"= :\"device1\",\"episode\":\"http://episode.url\",\"podcast\":\"http://podcas= t.url\",\"timestamp\":\"1998-01-01T00:01:02\"},{\"action\":\"delete\",\"dev= ice\":\"device3\",\"episode\":\"http://episode2.url\",\"podcast\":\"http://= podcast2.url\",\"timestamp\":\"1920-01-01T12:01:02\"},{\"action\":\"new\",\= "device\":\"foodev\",\"episode\":\"http://www.podtrac.com\",\"podcast\":\"h= ttp://leo.am\",\"timestamp\":\"1998-01-01T00:01:02\"},{\"action\":\"play\",= \"device\":\"foodev\",\"episode\":\"http://www.podtrac.com\",\"podcast\":\"= http://leo.am\",\"timestamp\":\"1920-01-01T12:01:02\" },{\"action\":\"play\= ",\"device\":\"foodev\",\"episode\":\"http://www.podtrac.com\",\"podcast\":= \"http://leo.am\",\"position\":123,\"started\":10,\"timestamp\":\"1998-01-0= 1T00:01:02\",\"total\":321},{\"action\":\"play\",\"device\":\"foodev\",\"ep= isode\":\"http://www.podtrac.com\",\"podcast\":\"http://leo.am\",\"position= \":10,\"timestamp\":\"1998-01-01T00:01:02\"}]" ) ); -+ QString expected2( QLatin1String( "[{\"action\":\"download\",\"device\"= :\"device1\",\"episode\":\"http://episode.url\",\"podcast\":\"http://podcas= t.url\",\"timestamp\":\"1998-01-01T00:01:02\"},{\"action\":\"delete\",\"dev= ice\":\"device3\",\"episode\":\"http://episode2.url\",\"podcast\":\"http://= podcast2.url\",\"timestamp\":\"1920-01-01T12:01:02\"},{\"action\":\"new\",\= "device\":\"foodev\",\"episode\":\"http://www.podtrac.com\",\"podcast\":\"h= ttp://leo.am\",\"timestamp\":\"1998-01-01T00:01:02\"},{\"action\":\"play\",= \"device\":\"foodev\",\"episode\":\"http://www.podtrac.com\",\"podcast\":\"= http://leo.am\",\"timestamp\":\"1920-01-01T12:01:02\"},{\"action\":\"play\"= ,\"device\":\"foodev\",\"episode\":\"http://www.podtrac.com\",\"podcast\":\= "http://leo.am\",\"position\":123,\"started\":10,\"timestamp\":\"1998-01-01= T00:01:02\",\"total\":321},{\"action\":\"play\",\"device\":\"foodev\",\"epi= sode\":\"http://www.podtrac.com\",\"podcast\":\"http://leo.am\",\"position\= ":10,\"timestamp\":\"1998-01-01T00:01:02\"}]" ) ); -=20 - QCOMPARE(outString2, expected2 ); - } --=20 2.17.0 --=-=-=--