From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52373) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ePc9h-0007SE-9u for guix-patches@gnu.org; Thu, 14 Dec 2017 17:39:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ePc9e-0006XD-54 for guix-patches@gnu.org; Thu, 14 Dec 2017 17:39:05 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:53833) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ePc9e-0006Wu-1k for guix-patches@gnu.org; Thu, 14 Dec 2017 17:39:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ePc9d-0001Os-OU for guix-patches@gnu.org; Thu, 14 Dec 2017 17:39:01 -0500 Subject: [bug#29624] EasyTAG Resent-Message-ID: References: <87o9n5z2m4.fsf@gnu.org> From: Pierre Langlois In-reply-to: <87o9n5z2m4.fsf@gnu.org> Date: Thu, 14 Dec 2017 22:37:57 +0000 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 29624@debbugs.gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Hi Ludovic, Thanks for taking a look! Ludovic Courtès writes: > Hello Pierre, > > Pierre Langlois skribis: > >> EasyTAG depends on the libid3tag library and tries to find it using >> pkg-config. I thought it'd be a good idea for the library to provide a >> .pc file instead of manually telling EasyTAG where it is. It allows >> cleaning up dependent packages a little, namely audacity and gmtp, what >> do you think? > > I think it’s a good patch for upstream, but not for distros. As I see > it, the risk is that people hacking on Guix would come to rely on the > availability of a .pc file, and that code will break on other distros. > Likewise, the build process of other packages is subtly affected. > > So I’m reluctant to making such changes in Guix proper, but I do agree > that it’s a good idea for upstream to adopt. > > WDYT? Sure, sounds reasonable! I'm unsure I'll have time to chase upstream however. In the meantime, see the attached patch to get around the issue with libid3tag. I'm afraid I couldn't find a way to make the configure script work without pkg-config. I got as far as patching it to think libid3tag was found, but then I couldn't find how to set CFLAGS and LDFLAGS to include libid3tag. It appears using pkg-config for some dependencies but not others is tricky here. So in the end, I settled with creating a temporary local .pc file. It feels like a bit of a hack but I thought it would be the most future-proof option, WDYT? > > Does the EasyTag patch need to be adjusted? (I wanted to test but > there’s currently no webkit-gtk substitute so…) > > Thanks, > Ludo’. Thanks, Pierre --=-=-= Content-Type: message/external-body; name="/home/pierre/code/guix/0001-gnu-Add-Easytag.patch"; access-type=local-file Content-Type: text/x-patch Content-ID: Content-Transfer-Encoding: binary --=-=-=--