From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:33496) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jGUBz-0000R7-V9 for guix-patches@gnu.org; Mon, 23 Mar 2020 17:01:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jGUBy-00048K-ND for guix-patches@gnu.org; Mon, 23 Mar 2020 17:01:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:47645) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jGUBx-000486-Ph for guix-patches@gnu.org; Mon, 23 Mar 2020 17:01:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jGUBx-0007B0-NK for guix-patches@gnu.org; Mon, 23 Mar 2020 17:01:01 -0400 Subject: [bug#38149] [WIP] gnu: Add qgis. Resent-Message-ID: From: Arun Isaac In-Reply-To: <87a748ieb1.fsf@yamatai> References: <20191109112702.14723-1-wz@freeshell.de> <87a748ieb1.fsf@yamatai> Date: Tue, 24 Mar 2020 02:30:30 +0530 Message-ID: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Guillaume Le Vaillant , 38149@debbugs.gnu.org --=-=-= Content-Type: text/plain Hi, Thank you for continuing the work. I was not making any progress on the tests and was caught up with other work. > Do you think this package definition for QGIS is good enough to be > merged in master (and improved later), or are the remaining issues > blocking? I agree we should merge this now and fix the tests later. > I took the WIP patch and updated it for QGIS 3.12.1. I also added some > inputs for optional features and some Qt wrapping for the SVG icons to > show up correctly in the GUI. Ok. > Things that can still be improved: > - Among the 550 tests, around 60 are failing. I disabled them for now > in the package definition. Ok, that should be enough for now. > - Also, I only put GPL2+ and GPL3+ as license (like in Gentoo and Nix), > and not the complete list for every file (like in Debian). Is this a good idea? I always thought we go the Debian way and try to document every single license. I would love it if we only had to document the "main license" but I'm not sure that is consistent with how other Guix packages are written. Thoughts? Thanks, Arun. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEf3MDQ/Lwnzx3v3nTLiXui2GAK7MFAl55I24ACgkQLiXui2GA K7PaYggAo6HHLU/AbH7SPvjsA2iU8uWe9XZb/0UKMbuligbR5fTEMjSXHspdwPfu LxCHy8Aq7m1EblGv14lf8fpDcKa3zBX0LaTO8ZvfcuSkmnpAibBZsgQlFj5PXrIH ed5Li9VPqiQRjhvVUUX4SJyvHDlp+DV41Z/vrgHTfhY39xHey285DJhc68m4R0qL 7rifATyD7ji3aUwmjHMuC9+mxDauV3EvLrvTJNOYGgF5O9MHG/4AozIJKMfmkP80 2oUvm7uV9iOAAOwnUdFhFSSNqNnvQjALrtx+qxGErLJ1hw2EBC/0UlGY7IqxdwiK AW1LHX8LXycVE3HQ8ODDlpi1OQz4DA== =AbDm -----END PGP SIGNATURE----- --=-=-=--