unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#30441] [PATCH] gnu: boost: Update to 1.66.0.
@ 2018-02-12 23:33 Arun Isaac
  2018-02-13 19:46 ` Leo Famulari
  2018-06-22 15:59 ` bug#30441: " Gábor Boskovits
  0 siblings, 2 replies; 8+ messages in thread
From: Arun Isaac @ 2018-02-12 23:33 UTC (permalink / raw)
  To: 30441

* gnu/packages/boost.scm (boost): Update to 1.66.0.
[arguments]: Replace system* with invoke.
[home-page]: Update URI.
---
 gnu/packages/boost.scm | 33 +++++++++++++++++----------------
 1 file changed, 17 insertions(+), 16 deletions(-)

diff --git a/gnu/packages/boost.scm b/gnu/packages/boost.scm
index 91dd2f915..bf584fa6c 100644
--- a/gnu/packages/boost.scm
+++ b/gnu/packages/boost.scm
@@ -6,6 +6,7 @@
 ;;; Copyright © 2015 Ludovic Courtès <ludo@gnu.org>
 ;;; Copyright © 2017 Thomas Danckaert <post@thomasdanckaert.be>
 ;;; Copyright © 2018 Tobias Geerinckx-Rice <me@tobias.gr>
+;;; Copyright © 2018 Arun Isaac <arunisaac@systemreboot.net>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -37,7 +38,7 @@
 (define-public boost
   (package
     (name "boost")
-    (version "1.64.0")
+    (version "1.66.0")
     (source (origin
               (method url-fetch)
               (uri (string-append
@@ -46,7 +47,7 @@
                     ".tar.bz2"))
               (sha256
                (base32
-                "0cikd35xfkpg9nnl76yqqnqxnf3hyfjjww8xjd4akflprsm5rk3v"))))
+                "1aaw48cmimsskzgiclwn0iifp62a5iw9cbqrhfari876af1828ap"))))
     (build-system gnu-build-system)
     (inputs `(("icu4c" ,icu4c)
               ("zlib" ,zlib)))
@@ -73,8 +74,7 @@
                    '()))
        #:phases
        (modify-phases %standard-phases
-         (replace
-             'configure
+         (replace 'configure
            (lambda* (#:key outputs #:allow-other-keys)
              (let ((out (assoc-ref outputs "out")))
                (substitute* '("libs/config/configure"
@@ -88,21 +88,22 @@
                (setenv "SHELL" (which "sh"))
                (setenv "CONFIG_SHELL" (which "sh"))
 
-               (zero? (system* "./bootstrap.sh"
-                               (string-append "--prefix=" out)
-                               "--with-toolset=gcc")))))
-         (replace
-             'build
+               (invoke "./bootstrap.sh"
+                       (string-append "--prefix=" out)
+                       "--with-toolset=gcc")
+               #t)))
+         (replace 'build
            (lambda* (#:key outputs make-flags #:allow-other-keys)
-             (zero? (apply system* "./b2"
-                           (format #f "-j~a" (parallel-job-count))
-                           make-flags))))
-         (replace
-             'install
+             (apply invoke "./b2"
+                    (format #f "-j~a" (parallel-job-count))
+                    make-flags)
+             #t))
+         (replace 'install
            (lambda* (#:key outputs make-flags #:allow-other-keys)
-             (zero? (apply system* "./b2" "install" make-flags)))))))
+             (apply invoke "./b2" "install" make-flags)
+             #t)))))
 
-    (home-page "http://boost.org")
+    (home-page "http://www.boost.org")
     (synopsis "Peer-reviewed portable C++ source libraries")
     (description
      "A collection of libraries intended to be widely useful, and usable
-- 
2.15.1

^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [bug#30441] [PATCH] gnu: boost: Update to 1.66.0.
  2018-02-12 23:33 [bug#30441] [PATCH] gnu: boost: Update to 1.66.0 Arun Isaac
@ 2018-02-13 19:46 ` Leo Famulari
  2018-02-14  6:20   ` Arun Isaac
  2018-02-17 13:58   ` Andreas Enge
  2018-06-22 15:59 ` bug#30441: " Gábor Boskovits
  1 sibling, 2 replies; 8+ messages in thread
From: Leo Famulari @ 2018-02-13 19:46 UTC (permalink / raw)
  To: Arun Isaac; +Cc: 30441

[-- Attachment #1: Type: text/plain, Size: 333 bytes --]

On Tue, Feb 13, 2018 at 05:03:58AM +0530, Arun Isaac wrote:
> * gnu/packages/boost.scm (boost): Update to 1.66.0.
> [arguments]: Replace system* with invoke.
> [home-page]: Update URI.

Thanks!

This is a change for the next core-updates cycle, so I put it on my
local core-updates-next branch. But please try to remember it, too :)

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [bug#30441] [PATCH] gnu: boost: Update to 1.66.0.
  2018-02-13 19:46 ` Leo Famulari
@ 2018-02-14  6:20   ` Arun Isaac
  2018-02-17 13:58   ` Andreas Enge
  1 sibling, 0 replies; 8+ messages in thread
From: Arun Isaac @ 2018-02-14  6:20 UTC (permalink / raw)
  To: Leo Famulari; +Cc: 30441

Leo Famulari <leo@famulari.name> writes:

> On Tue, Feb 13, 2018 at 05:03:58AM +0530, Arun Isaac wrote:
>> * gnu/packages/boost.scm (boost): Update to 1.66.0.
>> [arguments]: Replace system* with invoke.
>> [home-page]: Update URI.
>
> Thanks!
>
> This is a change for the next core-updates cycle, so I put it on my
> local core-updates-next branch. But please try to remember it, too :)

Sure!

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [bug#30441] [PATCH] gnu: boost: Update to 1.66.0.
  2018-02-13 19:46 ` Leo Famulari
  2018-02-14  6:20   ` Arun Isaac
@ 2018-02-17 13:58   ` Andreas Enge
  2018-02-27  9:31     ` Ludovic Courtès
  1 sibling, 1 reply; 8+ messages in thread
From: Andreas Enge @ 2018-02-17 13:58 UTC (permalink / raw)
  To: Leo Famulari; +Cc: 30441

Hello,

On Tue, Feb 13, 2018 at 02:46:33PM -0500, Leo Famulari wrote:
> This is a change for the next core-updates cycle, so I put it on my
> local core-updates-next branch. But please try to remember it, too :)

would it not be better to build it (after the next core-updates merge,
or even the next release) on a feature branch?

There are new releases of mpfr and mpc; it would be nice to have a quick
core-updates run with these packages that really belong to the core (together
with a few others, maybe, like glibc?) right after the next guix release.

Andreas

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [bug#30441] [PATCH] gnu: boost: Update to 1.66.0.
  2018-02-17 13:58   ` Andreas Enge
@ 2018-02-27  9:31     ` Ludovic Courtès
  2018-02-27 13:49       ` Marius Bakke
  0 siblings, 1 reply; 8+ messages in thread
From: Ludovic Courtès @ 2018-02-27  9:31 UTC (permalink / raw)
  To: Andreas Enge; +Cc: 30441

Hello,

Andreas Enge <andreas@enge.fr> skribis:

> On Tue, Feb 13, 2018 at 02:46:33PM -0500, Leo Famulari wrote:
>> This is a change for the next core-updates cycle, so I put it on my
>> local core-updates-next branch. But please try to remember it, too :)
>
> would it not be better to build it (after the next core-updates merge,
> or even the next release) on a feature branch?

I’d recommend either that or current ‘staging’ (though you’d need to
check with Leo and Marius if that’s fine) or ‘core-updates’.

> There are new releases of mpfr and mpc; it would be nice to have a quick
> core-updates run with these packages that really belong to the core (together
> with a few others, maybe, like glibc?) right after the next guix release.

You should definitely try updating them in the current ‘core-updates’
branch.  Now’s the time!  :-)

Thanks,
Ludo’.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [bug#30441] [PATCH] gnu: boost: Update to 1.66.0.
  2018-02-27  9:31     ` Ludovic Courtès
@ 2018-02-27 13:49       ` Marius Bakke
  2018-02-27 14:22         ` Ludovic Courtès
  0 siblings, 1 reply; 8+ messages in thread
From: Marius Bakke @ 2018-02-27 13:49 UTC (permalink / raw)
  To: Ludovic Courtès, Andreas Enge; +Cc: 30441

[-- Attachment #1: Type: text/plain, Size: 810 bytes --]

Ludovic Courtès <ludo@gnu.org> writes:

> Hello,
>
> Andreas Enge <andreas@enge.fr> skribis:
>
>> On Tue, Feb 13, 2018 at 02:46:33PM -0500, Leo Famulari wrote:
>>> This is a change for the next core-updates cycle, so I put it on my
>>> local core-updates-next branch. But please try to remember it, too :)
>>
>> would it not be better to build it (after the next core-updates merge,
>> or even the next release) on a feature branch?
>
> I’d recommend either that or current ‘staging’ (though you’d need to
> check with Leo and Marius if that’s fine) or ‘core-updates’.

Current 'staging' is almost built, so it would have to be the next round.

Also, Boost has ~1400 dependents, so it's a bit heavy even for 'staging'.

Let's try to do a new 'core-updates' soonish instead.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [bug#30441] [PATCH] gnu: boost: Update to 1.66.0.
  2018-02-27 13:49       ` Marius Bakke
@ 2018-02-27 14:22         ` Ludovic Courtès
  0 siblings, 0 replies; 8+ messages in thread
From: Ludovic Courtès @ 2018-02-27 14:22 UTC (permalink / raw)
  To: Marius Bakke; +Cc: 30441

Marius Bakke <mbakke@fastmail.com> skribis:

> Ludovic Courtès <ludo@gnu.org> writes:
>
>> Hello,
>>
>> Andreas Enge <andreas@enge.fr> skribis:
>>
>>> On Tue, Feb 13, 2018 at 02:46:33PM -0500, Leo Famulari wrote:
>>>> This is a change for the next core-updates cycle, so I put it on my
>>>> local core-updates-next branch. But please try to remember it, too :)
>>>
>>> would it not be better to build it (after the next core-updates merge,
>>> or even the next release) on a feature branch?
>>
>> I’d recommend either that or current ‘staging’ (though you’d need to
>> check with Leo and Marius if that’s fine) or ‘core-updates’.
>
> Current 'staging' is almost built, so it would have to be the next round.
>
> Also, Boost has ~1400 dependents, so it's a bit heavy even for 'staging'.

Sounds reasonable.

> Let's try to do a new 'core-updates' soonish instead.

Actually ‘core-updates’ already exist, so I suppose we can give it a try
right away?

berlin.guixsd.org should have substitutes for the core packages on
‘core-updates’, hopefully making it less painful to try things out.

Ludo’.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* bug#30441: gnu: boost: Update to 1.66.0.
  2018-02-12 23:33 [bug#30441] [PATCH] gnu: boost: Update to 1.66.0 Arun Isaac
  2018-02-13 19:46 ` Leo Famulari
@ 2018-06-22 15:59 ` Gábor Boskovits
  1 sibling, 0 replies; 8+ messages in thread
From: Gábor Boskovits @ 2018-06-22 15:59 UTC (permalink / raw)
  To: 30441-done

[-- Attachment #1: Type: text/plain, Size: 45 bytes --]

Thanks, this landed on master as *baef70bb.*

[-- Attachment #2: Type: text/html, Size: 744 bytes --]

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2018-06-22 16:00 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-02-12 23:33 [bug#30441] [PATCH] gnu: boost: Update to 1.66.0 Arun Isaac
2018-02-13 19:46 ` Leo Famulari
2018-02-14  6:20   ` Arun Isaac
2018-02-17 13:58   ` Andreas Enge
2018-02-27  9:31     ` Ludovic Courtès
2018-02-27 13:49       ` Marius Bakke
2018-02-27 14:22         ` Ludovic Courtès
2018-06-22 15:59 ` bug#30441: " Gábor Boskovits

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).