unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Arun Isaac <arunisaac@systemreboot.net>
To: Benjamin Slade <slade@jnanam.net>, 36064@debbugs.gnu.org
Subject: [bug#36064] [PATCH] sawfish.scm - update sawfish to 1.12
Date: Tue, 04 Jun 2019 18:30:35 +0530	[thread overview]
Message-ID: <cu7lfyha4jw.fsf@systemreboot.net> (raw)
In-Reply-To: <87imtnsgqb.fsf@jnanam.net>

[-- Attachment #1: Type: text/plain, Size: 1347 bytes --]


Thanks for contributing to Guix!

Please split this into three separate patches -- one each for librep,
rep-gtk and sawfish. For the commit messages, please use the
conventional Guix update commit message. If you use Emacs, this can be
done easily using the update yasnippet in etc/snippets of the Guix
source tree.

> -    (home-page "http://sawfish.wikia.com/wiki/Librep")
> +    (home-page "https://sawfish.wikia.com/wiki/Librep")

Shouldn't https://sawfish.tuxfamily.org/ be the home-page for all three
packages? Why are we listing the wiki as the home-page?

>  (define-public rep-gtk
>    (package
>      (name "rep-gtk")
> -    (version "0.90.8.2")
> +    (version "0.90.8.2") ; next point release hasn't been distributed; requires autoconf etc.

We don't usually package beta releases. So, there is no need to mention
this as a comment. But, the current release is 0.90.8.3. Please update
to that.

>  (define-public sawfish
>    (package
>      (name "sawfish")
> -    (version "1.11")
> +    (version "1.12.0") ; point release 1.12.90 hasn't been distributed; requires autoconf etc.

We don't usually package beta releases. So, there is no need to mention
this as a comment.

> -    (home-page "http://sawfish.wikia.com/wiki/Main_Page")
> +    (home-page "https://sawfish.wikia.com/wiki/Main_Page")

See above for comment on home-page.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

  reply	other threads:[~2019-06-04 13:02 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-02 23:35 [bug#36064] [PATCH] sawfish.scm - update sawfish to 1.12 Benjamin Slade
2019-06-04 13:00 ` Arun Isaac [this message]
2019-06-10  6:36   ` Benjamin Slade
2019-06-27  6:58     ` bug#36064: " Arun Isaac

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cu7lfyha4jw.fsf@systemreboot.net \
    --to=arunisaac@systemreboot.net \
    --cc=36064@debbugs.gnu.org \
    --cc=slade@jnanam.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).