From: Arun Isaac <arunisaac@systemreboot.net>
To: Efraim Flashner <efraim@flashner.co.il>
Cc: 36415@debbugs.gnu.org
Subject: [bug#36415] [PATCH] gnu: Add qlogo.
Date: Thu, 04 Jul 2019 22:10:04 +0530 [thread overview]
Message-ID: <cu7k1cx21p7.fsf@systemreboot.net> (raw)
In-Reply-To: <20190702072132.GB22794@macbook41>
[-- Attachment #1: Type: text/plain, Size: 1055 bytes --]
> On Fri, Jun 28, 2019 at 01:33:57PM +0530, Arun Isaac wrote:
>> + ;; The check phase rebuilds the source for tests. So, it needs to be
>> + ;; run after the install phase has installed the outputs of the build
>> + ;; phase.
>> + (delete 'check)
>> + (add-after 'install 'check
>> + (lambda _
>> + ;; Clean files created by the build phase.
>> + (invoke "make" "clean")
>> + ;; QLogo tries to create its "dribble file" in the home
>> + ;; directory. So, set HOME.
>> + (setenv "HOME" "/tmp")
>> + ;; Build and run tests.
>> + (invoke "qmake" "TestQLogo.pro")
>
> Doesn't this efectively just rebuild the binary we just built in the
> 'configure and 'build phases?
No. There are two qmake project files -- QLogo.pro and
TestQLogo.pro. QLogo.pro builds the "QLogo" executable and TestQLogo.pro
builds the "testqlogo" executable. "QLogo" is the actual qlogo
executable that we install. "testqlogo" simply runs the tests.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
prev parent reply other threads:[~2019-07-04 16:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-28 8:03 [bug#36415] [PATCH] gnu: Add qlogo Arun Isaac
2019-06-28 16:35 ` swedebugia
2019-07-02 8:36 ` Arun Isaac
2019-07-02 8:50 ` Ricardo Wurmus
2019-07-04 17:11 ` Arun Isaac
2019-07-04 19:30 ` Ricardo Wurmus
2019-07-05 7:59 ` bug#36415: " Arun Isaac
2019-07-02 7:21 ` [bug#36415] " Efraim Flashner
2019-07-04 16:40 ` Arun Isaac [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cu7k1cx21p7.fsf@systemreboot.net \
--to=arunisaac@systemreboot.net \
--cc=36415@debbugs.gnu.org \
--cc=efraim@flashner.co.il \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).