unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#35736] geiser-edit-symbol-at-point (M-.) does not work on fork+exec-command
@ 2019-05-14 20:29 Arun Isaac
  2019-05-15 12:40 ` Ludovic Courtès
  0 siblings, 1 reply; 4+ messages in thread
From: Arun Isaac @ 2019-05-14 20:29 UTC (permalink / raw)
  To: 35736

[-- Attachment #1: Type: text/plain, Size: 607 bytes --]


geiser-edit-symbol-at-point (M-.) does not work on
fork+exec-command. geiser wrongly tries to lookup fork instead of
looking up fork+exec-command. This is because (thing-at-point 'symbol)
does not correctly identify the whole symbol. And, that, in turn, is
because ?+ has been reclassified as an expression prefix character (')
in .dir-locals.el. It should be a symbol constituent character (_) which
is the default for scheme mode.

(modify-syntax-entry ?+ "'")

This is a rather trivial bug. But, I thought I'll just document it
here. I'm not sure if we should fix it. I can't think of any easy way
out.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [bug#35736] geiser-edit-symbol-at-point (M-.) does not work on fork+exec-command
  2019-05-14 20:29 [bug#35736] geiser-edit-symbol-at-point (M-.) does not work on fork+exec-command Arun Isaac
@ 2019-05-15 12:40 ` Ludovic Courtès
  2019-05-16  7:06   ` Arun Isaac
  0 siblings, 1 reply; 4+ messages in thread
From: Ludovic Courtès @ 2019-05-15 12:40 UTC (permalink / raw)
  To: Arun Isaac; +Cc: 35736

Hi,

Arun Isaac <arunisaac@systemreboot.net> skribis:

> geiser-edit-symbol-at-point (M-.) does not work on
> fork+exec-command. geiser wrongly tries to lookup fork instead of
> looking up fork+exec-command. This is because (thing-at-point 'symbol)
> does not correctly identify the whole symbol. And, that, in turn, is
> because ?+ has been reclassified as an expression prefix character (')
> in .dir-locals.el. It should be a symbol constituent character (_) which
> is the default for scheme mode.
>
> (modify-syntax-entry ?+ "'")

What about proposing this change to ‘scheme-mode’ to Emacs upstream?

Alternately, or in the meantime, we could carry that fix in Geiser
maybe?

Thoughts?

Ludo’.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [bug#35736] geiser-edit-symbol-at-point (M-.) does not work on fork+exec-command
  2019-05-15 12:40 ` Ludovic Courtès
@ 2019-05-16  7:06   ` Arun Isaac
  2019-05-16  9:53     ` Ludovic Courtès
  0 siblings, 1 reply; 4+ messages in thread
From: Arun Isaac @ 2019-05-16  7:06 UTC (permalink / raw)
  To: Ludovic Courtès; +Cc: 35736

[-- Attachment #1: Type: text/plain, Size: 453 bytes --]


> What about proposing this change to ‘scheme-mode’ to Emacs upstream?
>
> Alternately, or in the meantime, we could carry that fix in Geiser
> maybe?

I don't think reporting this to scheme-mode or geiser would help. They
are justified in classifying ?+ as a symbol constituent character
(_). It is we (the Guix project) who have reclassified ?+ as an
expression prefix character (') in a "non-standard" way for our use in
gexps. WDYT?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [bug#35736] geiser-edit-symbol-at-point (M-.) does not work on fork+exec-command
  2019-05-16  7:06   ` Arun Isaac
@ 2019-05-16  9:53     ` Ludovic Courtès
  0 siblings, 0 replies; 4+ messages in thread
From: Ludovic Courtès @ 2019-05-16  9:53 UTC (permalink / raw)
  To: Arun Isaac; +Cc: 35736

Arun Isaac <arunisaac@systemreboot.net> skribis:

>> What about proposing this change to ‘scheme-mode’ to Emacs upstream?
>>
>> Alternately, or in the meantime, we could carry that fix in Geiser
>> maybe?
>
> I don't think reporting this to scheme-mode or geiser would help. They
> are justified in classifying ?+ as a symbol constituent character
> (_). It is we (the Guix project) who have reclassified ?+ as an
> expression prefix character (') in a "non-standard" way for our use in
> gexps. WDYT?

Oh true, sorry!

Well I don’t know, I’m confused now.  I vaguely remember prior
discussions about this with Alex Kost, but I forgot what the conclusions
were.  :-/

Ludo’.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2019-05-16  9:55 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-05-14 20:29 [bug#35736] geiser-edit-symbol-at-point (M-.) does not work on fork+exec-command Arun Isaac
2019-05-15 12:40 ` Ludovic Courtès
2019-05-16  7:06   ` Arun Isaac
2019-05-16  9:53     ` Ludovic Courtès

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).