unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Noé Lopez via Guix-patches via" <guix-patches@gnu.org>
To: 74670@debbugs.gnu.org
Cc: "Noé Lopez" <noelopez@free.fr>, "Ludovic Courtès" <ludo@gnu.org>
Subject: [bug#74670] [PATCH v3 0/2] tests: pack: Fix AppImage tests.
Date: Thu, 19 Dec 2024 01:23:01 +0100	[thread overview]
Message-ID: <cover.1734566923.git.noelopez@free.fr> (raw)
In-Reply-To: <3f75445c04184678b357e777bfbc5eb751b9f363.1733238317.git.noelopez@free.fr>

From: Noé Lopez <noelopez@free.fr>

(messed up git in v2)

Hi,

Thanks you very much for working on the tests, I should have spent more time
on them myself.

> I noticed that the tests were not going very far, so I tried the patch
> below to: (1) check the output of ‘hello’ in the first test, (2) change
> the second test to check for the existence of /var/guix/db/db.sqlite.
>
> The second test doesn’t work though, because where’s that file supposed
> to live?  The image is apparently extracted in an unguessable directory,
> so cannot tell where it is.  Am I right?

Yes, --appimage-extract-and-run uses a temporary directory but you can use
--appimage-extract which always places the contents in ./squashfs-root.

The other reason the test did not work is because the localstatedir option
wasn’t supported to begin with, this is an oversight that I could have avoided
by knowing what I was doing.

I’m sending a second version with the localstatedir support and your updated
tests.

Thanks,
Noé

Noé Lopez (2):
  pack: Support localstatedir in AppImage format.
  tests: pack: Improve AppImage tests.

 guix/scripts/pack.scm | 13 +++++++++-
 tests/pack.scm        | 60 +++++++++++++++++++++++++++++++++----------
 2 files changed, 58 insertions(+), 15 deletions(-)


base-commit: 1a62f687e504c67f26693f3bc60a90e503ab4ea9
-- 
2.46.0





  parent reply	other threads:[~2024-12-19  0:23 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-03 15:13 [bug#74670] [PATCH] tests: pack: Fix AppImage tests Noé Lopez via Guix-patches via
2024-12-12 21:58 ` Ludovic Courtès
2024-12-12 21:59 ` Ludovic Courtès
2024-12-18 23:58 ` [bug#74670] [PATCH v2 0/2] " Noé Lopez via Guix-patches
2024-12-18 23:59   ` [bug#74670] [PATCH v2 1/2] pack: Support localstatedir in AppImage format Noé Lopez via Guix-patches
2024-12-19  0:23 ` Noé Lopez via Guix-patches via [this message]
2024-12-19  0:23   ` [bug#74670] [PATCH v3 " Noé Lopez via Guix-patches via
2024-12-19  0:23   ` [bug#74670] [PATCH v3 2/2] tests: pack: Improve AppImage tests Noé Lopez via Guix-patches via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1734566923.git.noelopez@free.fr \
    --to=guix-patches@gnu.org \
    --cc=74670@debbugs.gnu.org \
    --cc=ludo@gnu.org \
    --cc=noe@xn--no-cja.eu \
    --cc=noelopez@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).