From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id 8M5vOi5iY2fFtQAAqHPOHw:P1 (envelope-from ) for ; Thu, 19 Dec 2024 00:00:47 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id 8M5vOi5iY2fFtQAAqHPOHw (envelope-from ) for ; Thu, 19 Dec 2024 01:00:47 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=olDTNlyY; dkim=fail ("headers rsa verify failed") header.d=xn--no-cja.eu header.s=ds202402 header.b=bvfMz2pe; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1734566446; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=HRPsQVDQCdm8Sm8odUKj6aH+pB9nMFPO2g4UhKo+ML8=; b=kmqdjhA4JMrYWNe5lR97Htrq1NPm0Olrzl0c0pnoHZiWvWuDRZFpcfITIvt1bcQynbGyUK bOw3SvQBEJ2h+RjKcUv9Lnx5twCCigsGwsXKZOqEzUCNKZFGByvt2vFt6bQSl0yE+XjiO9 9xxE46iwHkAujdQGYyhwx3x8elDt5NYtFRrtPPy5YtpsTcBi1XQZoqp0ziGnknyfZC8qB4 6J2v897ZRdMGm/dlyl2QCgH4AYeWtcfp6+W4i+ibM/QeRaGTdVAWUX72ZKEVaDDZa9Qul8 CHI4cUHBHpBlOnBYsWKmKc22g/2AhWRrQtVV96kD0GCzEx8l9rlrgXVSLnpbiQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=olDTNlyY; dkim=fail ("headers rsa verify failed") header.d=xn--no-cja.eu header.s=ds202402 header.b=bvfMz2pe; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1734566446; a=rsa-sha256; cv=none; b=FP8knG15VYVWyzo8SooELUr2W5YVRQ4OMI/WuwbVa/RRaBb3Y0ISiOYliiw2moMAJpyre8 0ilBcejzTDHrPGPKEU0NuBnl8dFDpA0AjP5bv2Z2lBu9Duijppt2Xla8MSDnBKk6y747Ji 6QNOhke5KAjP5yR6zvMBkkfW0lTfa/4DZ0yTVBjzDASMo8M1qpdCkYwN0yoGmRyRiIv9bi j3XCThvC+j7PHcKp6cKy6As9xFqtG3WM9ub0SI+ub8CLOMv1dh12dyjIU/iVg52UYGqQ/z wpmJh2Vs96uCy7k7ENGxvo0fPxj7bl5uwzy3Nr3mWl28iEC668Exb5RAFBfJwA== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D4DA3679E for ; Thu, 19 Dec 2024 01:00:45 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tO3xW-0003tQ-BS; Wed, 18 Dec 2024 19:00:06 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tO3xT-0003qz-QH for guix-patches@gnu.org; Wed, 18 Dec 2024 19:00:04 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tO3xT-0000pN-Em for guix-patches@gnu.org; Wed, 18 Dec 2024 19:00:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:From:To:In-Reply-To:References:Subject; bh=HRPsQVDQCdm8Sm8odUKj6aH+pB9nMFPO2g4UhKo+ML8=; b=olDTNlyYGJ3xNuDPWqyYvCRGUdUdRguNhdsKG36HOY9w1XoFnEq0zLTeCNzrNnFwQYvXOjG9sN24Ht23bXT6BaP2ClCAxj4nNvXC9hwWAwAcXev9qByQEqaZwSN2hccF9zMbFTM7Y0bOtcD4nkAE/mUArAO1n26uGgrOD8gd0/3/Mi0QcgkAhGaw8y/eTNNXIKIbNjbtAanbEuHNj3Coj0a7T3MlR9UZPhTw6gLkBw7DdqvSlmXEgsJxHDqH3he2vrHV7yOPkt36Pd+MqQOeRKbYLRldmlYBOnNfK552H4rt+EB9Han2h29BsfCV3+g1lhmcG9uZI2mG3eL2ODaj2A==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tO3xS-0000yP-Qb for guix-patches@gnu.org; Wed, 18 Dec 2024 19:00:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#74670] [PATCH v2 0/2] Fix AppImage tests. References: <3f75445c04184678b357e777bfbc5eb751b9f363.1733238317.git.noelopez@free.fr> In-Reply-To: <3f75445c04184678b357e777bfbc5eb751b9f363.1733238317.git.noelopez@free.fr> Resent-From: =?UTF-8?Q?No=C3=A9?= Lopez Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 19 Dec 2024 00:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74670 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 74670@debbugs.gnu.org Cc: =?UTF-8?Q?No=C3=A9?= Lopez Received: via spool by 74670-submit@debbugs.gnu.org id=B74670.17345663633629 (code B ref 74670); Thu, 19 Dec 2024 00:00:02 +0000 Received: (at 74670) by debbugs.gnu.org; 18 Dec 2024 23:59:23 +0000 Received: from localhost ([127.0.0.1]:36479 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tO3wo-0000wT-VM for submit@debbugs.gnu.org; Wed, 18 Dec 2024 18:59:23 -0500 Received: from smtp.domeneshop.no ([194.63.252.55]:50123) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tO3wk-0000w5-UW for 74670@debbugs.gnu.org; Wed, 18 Dec 2024 18:59:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xn--no-cja.eu; s=ds202402; h=Content-Transfer-Encoding:Content-Type: MIME-Version:Message-ID:Date:Subject:Cc:To:From:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=HRPsQVDQCdm8Sm8odUKj6aH+pB9nMFPO2g4UhKo+ML8=; b=bvfMz2pexM5q2bR0jikoWXZjPM S7rZC12O9BPT4OXrLY+rZ8AShZJXfeQUE4KDySey013yD1hFOT6tUeRgvSHSCVHIwWiIsZudhCrlu 8qACJm7Fs1F+saMFCjVxtzsi4QLNHcDkkies9XllqjFh3v0am208jPP71tZhFIVbWQUv8CN089G1F jOJqksAVtGfTjZamQtDEFP6DGe1MRtuAR3lspUSLv3R8OLllmdUjY3b8JKsqkGSu+wjQe0IVVznbh 6j+ZQbSHSxN4PdRGnWkCb2k4Hie2y2yTalGs8zhC1pfyw3vngGBAQ5YOSh2+XFApUAJpd+DuIhuxu DdiYYmig==; Received: from smtp by smtp.domeneshop.no with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) id 1tO3uX-00CMKi-0H; Thu, 19 Dec 2024 00:57:01 +0100 Date: Thu, 19 Dec 2024 00:58:13 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: =?utf-8?q?No=C3=A9_Lopez_via_Guix-patches?= Reply-To: =?UTF-8?Q?No=C3=A9?= Lopez Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Scanner: mx12.migadu.com X-Migadu-Spam-Score: -2.31 X-Spam-Score: -2.31 X-Migadu-Queue-Id: D4DA3679E X-TUID: a4VipngexHQS From: Noé Lopez Hi, Thanks you very much for working on the tests, I should have spent more time on them myself. > I noticed that the tests were not going very far, so I tried the patch > below to: (1) check the output of ‘hello’ in the first test, (2) change > the second test to check for the existence of /var/guix/db/db.sqlite. > > The second test doesn’t work though, because where’s that file supposed > to live? The image is apparently extracted in an unguessable directory, > so cannot tell where it is. Am I right? Yes, --appimage-extract-and-run uses a temporary directory but you can use --appimage-extract which always places the contents in ./squashfs-root. The other reason the test did not work is because the localstatedir option wasn’t supported to begin with, this is an oversight that I could have avoided. I’m sending a second version with the localstatedir support and your updated tests. Thanks, Noé Noé Lopez (2): pack: Support localstatedir in AppImage format. build: pack: Fix unexpected type in assert-utf8-local. guix/build/pack.scm | 2 +- guix/scripts/pack.scm | 13 ++++++++++- tests/pack.scm | 51 ++++++++++++++++++++++++++++--------------- 3 files changed, 46 insertions(+), 20 deletions(-) base-commit: bb8a6f0ac47296d3a18e1e0a26ea3a833eb77c4a prerequisite-patch-id: f3798629973582541e158d322c1a461038c657b8 -- 2.46.0