unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Richard Sent <richard@freakingpenguin.com>
To: 74837@debbugs.gnu.org
Cc: "Richard Sent" <richard@freakingpenguin.com>,
	"Ludovic Courtès" <ludo@gnu.org>,
	"Maxim Cournoyer" <maxim.cournoyer@gmail.com>
Subject: [bug#74837] [PATCH v3 0/2] resize-file-system-service
Date: Sat, 14 Dec 2024 16:18:21 -0500	[thread overview]
Message-ID: <cover.1734211103.git.richard@freakingpenguin.com> (raw)
In-Reply-To: <cover.1734034432.git.richard@freakingpenguin.com>

> I would avoid abbreviations as usual and go for
> ‘file-system-resizing-service-type’.  WDYT?

Sounds good to me.

> I wonder if Guile-Parted could be used instead of ‘growpart’ (shouldn’t
> be a blocker though).

This is an interesting idea. parted can tell us the file system type
at runtime, reducing the amount of information the user needs to
provide (at the cost of not catching invalid file-system-type values
at build-time.)

> No need for ‘let/ec’ here, you can just return from the ‘guard’ handler.

What would that look like? We don't want to capture an error in
grow-filesystem-command with an exit-status of 1, so it lives outside
the guard, and we don't want to raise an exception if the partition
was already resized.

(Side note, should Shepherd consider a service perpetually starting if
the start constructor exits without returning a value?)

V3 should have all other feedback implemented.

Richard Sent (2):
  packages: cloud-utils: Add missing growpart programs to path.
  gnu: services: Add resize-file-system-service.

 doc/guix.texi          |  54 +++++++++++++++++
 gnu/packages/admin.scm |  15 ++++-
 gnu/services/admin.scm | 133 ++++++++++++++++++++++++++++++++++++++++-
 3 files changed, 198 insertions(+), 4 deletions(-)


base-commit: 0787a180b3ca64d3958438920ca1b58a2a27fba4
-- 
2.46.0





  parent reply	other threads:[~2024-12-14 21:36 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-12 20:16 [bug#74837] [PATCH 0/2] Add resize-fs service Richard Sent
2024-12-12 20:18 ` [bug#74837] [PATCH 1/2] gnu: services: Add resize-fs-service Richard Sent
2024-12-12 20:19 ` [bug#74837] [PATCH 2/2] packages: cloud-utils: Add missing growpart programs to path Richard Sent
2024-12-12 21:15 ` [bug#74837] [PATCH v2 1/2] gnu: services: Add resize-fs-service Richard Sent
2024-12-12 21:15   ` [bug#74837] [PATCH v2 2/2] packages: cloud-utils: Add missing growpart programs to path Richard Sent
2024-12-14 15:23   ` [bug#74837] [PATCH v2 1/2] gnu: services: Add resize-fs-service Ludovic Courtès
2024-12-14 21:18 ` Richard Sent [this message]
2024-12-14 21:18   ` [bug#74837] [PATCH v3 1/2] packages: cloud-utils: Add missing growpart programs to path Richard Sent
2024-12-14 21:18   ` [bug#74837] [PATCH v3 2/2] gnu: services: Add resize-file-system-service Richard Sent

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1734211103.git.richard@freakingpenguin.com \
    --to=richard@freakingpenguin.com \
    --cc=74837@debbugs.gnu.org \
    --cc=ludo@gnu.org \
    --cc=maxim.cournoyer@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).