unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Simon Tournier <zimon.toutoune@gmail.com>
To: 73034@debbugs.gnu.org
Cc: Simon Tournier <zimon.toutoune@gmail.com>,
	maxim.cournoyer@gmail.com, liliana.prikler@gmail.com,
	ludo@gnu.org
Subject: [bug#73034] [PATCH v3 0/3] Fix annoyances of Git and update to 2.46.0
Date: Thu,  5 Sep 2024 17:34:47 +0200	[thread overview]
Message-ID: <cover.1725550253.git.zimon.toutoune@gmail.com> (raw)
In-Reply-To: <15bfd834d58da9d8910b0945689aa8cd4e8ff48c.1725498442.git.zimon.toutoune@gmail.com>

Hi,

Since changes to the package Git imply large rebuilds, this series integrates
submission #72413.

Change since v2: Restore the ’origin’ of git-manpages under native-inputs.

Commit f288604428e9c8f096ec9e0eccf207e079806271 moved the origin inside the phase.

--8<---------------cut here---------------start------------->8---
+          (add-after 'split 'install-man-pages
+            (lambda _
+              (let ((man (string-append #$output "/share/man")))
+                (mkdir-p man)
+                (with-directory-excursion man
+                  (invoke
+                   "tar" "xvf"
+                   #$(origin
+                       (method url-fetch)
+                       (uri (string-append
+                             "mirror://kernel.org/software/scm/git/"
+                             "git-manpages-" version ".tar.xz"))
+                       (sha256
+                        (base32
+                         "0xsqakgy0s60zpa13ilj6zj420kdh8pf4v3nrp1nziwj8ja4qymw"))))))))
--8<---------------cut here---------------end--------------->8---

And this appears to me a bad idea, because 1. it makes harder to know what are
the inputs and more importantly 2. it is hidden from procedure
’package-direct-sources’, which means it will not be archived.

Cheers,
simon


1:  https://issues.guix.gnu.org/72413

Ashish SHUKLA (1):
  gnu: git: Update to 2.46.0

Simon Tournier (2):
  gnu: git: Fix perl search-paths of wrapped programs.
  gnu: git: Move git-manpages origin from phases to native-inputs.

 gnu/packages/version-control.scm | 77 +++++++++++++++++++-------------
 1 file changed, 47 insertions(+), 30 deletions(-)


base-commit: 7d2ced8d6d9c38327592d312376d59a8c37fc160
-- 
2.45.2





  parent reply	other threads:[~2024-09-05 15:55 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-05  1:55 [bug#73034] [PATCH] gnu: git: Fix perl search-paths of wrapped programs Simon Tournier
2024-09-05  2:37 ` [bug#73034] [PATCH v2] " Simon Tournier
2024-09-05 12:47 ` [bug#73034] [PATCH] " Ashish SHUKLA via Guix-patches via
2024-09-05 15:34 ` Simon Tournier [this message]
2024-09-05 15:34   ` [bug#73034] [PATCH v3 1/3] " Simon Tournier
2024-09-05 15:34   ` [bug#73034] [PATCH v3 2/3] gnu: git: Update to 2.46.0 Simon Tournier
2024-09-05 15:34   ` [bug#73034] [PATCH v3 3/3] gnu: git: Move git-manpages origin from phases to native-inputs Simon Tournier
2024-09-06  4:17   ` [bug#73034] [PATCH v3 0/3] Fix annoyances of Git and update to 2.46.0 Maxim Cournoyer
2024-09-06 10:31     ` Simon Tournier
2024-09-06 15:53       ` Simon Tournier
2024-09-08 12:10         ` bug#73034: " Maxim Cournoyer
2024-09-09 17:50           ` [bug#73034] " Simon Tournier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1725550253.git.zimon.toutoune@gmail.com \
    --to=zimon.toutoune@gmail.com \
    --cc=73034@debbugs.gnu.org \
    --cc=liliana.prikler@gmail.com \
    --cc=ludo@gnu.org \
    --cc=maxim.cournoyer@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).