From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id oGutLV8txmZR/wAAe85BDQ:P1 (envelope-from ) for ; Wed, 21 Aug 2024 18:09:35 +0000 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id oGutLV8txmZR/wAAe85BDQ (envelope-from ) for ; Wed, 21 Aug 2024 20:09:35 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=K4t5TEGA; dkim=fail ("headers rsa verify failed") header.d=posteo.net header.s=2017 header.b=V+U45ijo; dmarc=fail reason="SPF not aligned (strict), DKIM not aligned (strict)" header.from=posteo.net (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1724263775; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=xiwiMJs3+gQqGLDsjChI8BV/+w5Q1qGGPmycKg+p2OU=; b=FvF/taiehPVM6ztbaMAErEfKy3w64X6PEXvuY3JlCJOV8LsCk41oK8Xz7ZAGYtWa/V1lb7 +4Ja0ZSn5aZM+06nHOzb/CFPQdc6v1+L3cU9gFb9G46jFZCzK1YxP3/V3Cse8CkMjHzlUk 9kokT6zqNRGQVmOIlfSqKglvMuJdAO36wDD6gfUjmhj3Psg6UJKG6w+xMIEOSPAnG8saok oUikv/ihnRlau+HSRx/Ki7xDY8q4Rv0LJT8xYBDMntsUoWthP4st6jiCUcHU5mHJMe9T1R TthYzz69hRaSHkrA+qfyDUv/wObx+TV9crdPyDdKmwMwAKgpr/3ePfQIAIrcZA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1724263775; a=rsa-sha256; cv=none; b=CIX8Nmxatohohn6cYrvjY/miC2HxxpizCmhjxm8+f9zXP2g8BFvRBGkx0rkVAoVsXcjO/A BbFywYrwfL8xZKVe/mt83Vb2MS2E4CiriJ3QelLln8fOyPwHOD7JPHi1wv+PFm3CBv48Rc DI0b4m9uR0QX2RutFxf1P9HLbP1w7Zye5ufXTvTY75XcaBw+9rxbuiO4/tyDkG5uLkYs+j qxYHGzkY6LOHDcEdHjsw74GJbgoUgou3ufV8r7Iqi9omOUxvaPMzWusylvvMJJhYR/dzf1 QnxpxUwssjWKw7j0eeajyhxqgn449cG8+BAqXTirS5ERZmSrQ6VWFDYf7g6nlQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=K4t5TEGA; dkim=fail ("headers rsa verify failed") header.d=posteo.net header.s=2017 header.b=V+U45ijo; dmarc=fail reason="SPF not aligned (strict), DKIM not aligned (strict)" header.from=posteo.net (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0E3803D6E4 for ; Wed, 21 Aug 2024 20:09:35 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sgplp-00070I-Jr; Wed, 21 Aug 2024 14:09:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sgpln-0006zB-8t for guix-patches@gnu.org; Wed, 21 Aug 2024 14:09:19 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sgpln-0002g4-0K for guix-patches@gnu.org; Wed, 21 Aug 2024 14:09:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:From:To:Subject; bh=xiwiMJs3+gQqGLDsjChI8BV/+w5Q1qGGPmycKg+p2OU=; b=K4t5TEGA9Fuig03vDtG6PO++KzNOcweLglar60IGlrqP5+7PBR102O8io5MUtE53Hv/e3gAcHl4s5eG8uonp6CjPUa9ftSbEDBjL3xOqqF1xDE6Z51h364/9Tl6p8BydzTz0meMa0m0chBuOfAtap6+qrG9jFik5DTcMVWwoeuZzOw9jLnnePK70TpJDuCy1V7rkULq99vY7/Y4MnTBu60ShtDPcIXZ6En3h+2HrbmJGidxYl4C9NSfBWrftR2EVHWOzKymdTreQH/hc77jouIfaakhaaEHvGo2K+yQy9l1h8CzYhx1y75cNGZrS3zSYBr1asfbpq5YAULW7Pqu9/w==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sgpmU-0003VK-3g; Wed, 21 Aug 2024 14:10:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#72751] [PATCH 0/2] Rework cmake cross compiling. Resent-From: Dariqq Original-Sender: "Debbugs-submit" Resent-CC: efraim@flashner.co.il, vagrant@debian.org, guix-patches@gnu.org Resent-Date: Wed, 21 Aug 2024 18:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 72751 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 72751@debbugs.gnu.org Cc: Dariqq , Efraim Flashner , Vagrant Cascadian X-Debbugs-Original-To: guix-patches@gnu.org X-Debbugs-Original-Xcc: Efraim Flashner , Vagrant Cascadian Received: via spool by submit@debbugs.gnu.org id=B.172426378113428 (code B ref -1); Wed, 21 Aug 2024 18:10:02 +0000 Received: (at submit) by debbugs.gnu.org; 21 Aug 2024 18:09:41 +0000 Received: from localhost ([127.0.0.1]:36306 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sgpm8-0003UW-KA for submit@debbugs.gnu.org; Wed, 21 Aug 2024 14:09:40 -0400 Received: from lists.gnu.org ([209.51.188.17]:54136) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sgpm6-0003UO-Aw for submit@debbugs.gnu.org; Wed, 21 Aug 2024 14:09:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sgplM-0006tR-Kx for guix-patches@gnu.org; Wed, 21 Aug 2024 14:08:53 -0400 Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sgplK-0002c9-3m for guix-patches@gnu.org; Wed, 21 Aug 2024 14:08:51 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id BCC17240028 for ; Wed, 21 Aug 2024 20:08:43 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1724263723; bh=OVvGrwJQgDIG7lLhcWd1xYCRpxg6+pC8w7qh3XMOQuc=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version: Content-Transfer-Encoding:From; b=V+U45ijoGS0nXnY30WciGttZgg0K3aVleyXWiGXUue8oxdbjtaCnS001jZ2gf1qIn OdLl0/+Qh2hKChPKAPcuW+84AqM3DJDBYV3bfr3dEIlCoDLPMmgNM++CRgh++tpvTe aU2Bm++V/PkBHSfIAdVGXIx0O9Di265jv7ObGyLlgWiyy2UAzNJvjCRSTHC95JJH1/ nSr8akCSJ4tGLklFWUeLwa0IkeqUh2Mjog1OUer+AD51JG4vOfzrr4ZlBDnnSOYFDu XOZdUwpWN0AoVd5vv0Id6zLXMqnBV+1CsMmHf1yVHlmZYma/ejgdXfDyHruHZ6VbNL ZR0YDWNBLH6dQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4WpvTk6f5Jz6tsg; Wed, 21 Aug 2024 20:08:42 +0200 (CEST) From: Dariqq Date: Wed, 21 Aug 2024 18:05:44 +0000 Message-ID: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=185.67.36.65; envelope-from=dariqq@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -4.01 X-Spam-Score: -4.01 X-Migadu-Queue-Id: 0E3803D6E4 X-Migadu-Scanner: mx11.migadu.com X-TUID: Sg+J7WEVmvY+ Hi, This is an attempt to move the cross compile logic out of the build side. This should fix https://issues.guix.gnu.org/72697 and technically supersedes https://issues.guix.gnu.org/68366 . Also cleans up after https://issues.guix.gnu.org/69476 by removing the need for CMAKE_SYSTEM_NAME override. Main benefit is that this decouples the cmake native compilation and cmake cross compilation, i.e. if a new target needs a new CMAKE_SYSTEM_NAME we don't need to touch build code to enable it and thus don't need to rebuild everything natively for something only affecting cross building. Also use the target-*? functions and c*-for-target instead of reimplementing them in build code. The new cmake-system-name-for-target (a bit long, idk) now also supports hurd and bare-metal targets. I have tested this with the package i had troubles in #72697, and also verified that the ath9k firmware hashes are unchanged. Output of guix hash: /gnu/store/0r075s8g9pr9i6yd3pvwfjl2g4mkm7s8-ath9k-htc-ar9271-firmware-1.4.0/lib/firmware/htc_9271.fw 0bi0m4y1g8i47mal4m11pry88kjqqyk2209hw5yj2awngp31qj55 /gnu/store/msjnrh864a2c8k44hvwqs6fra7c7bb6v-ath9k-htc-ar7010-firmware-1.4.0/lib/firmware/htc_7010.fw 01hl01gv66k8g5avw85fbfyzblsy1ccmv64wq7g3zbgdwcb4ry7f Unfortunely this will cause a lot of rebuilds (but this will be hopefully easier in the future). Dariqq (2): guix: build-system: cmake: Rework cross compilation. gnu: ath9k-firmware: Remove CMAKE_SYSTEM_NAME override. gnu/packages/firmware.scm | 6 ++---- guix/build-system/cmake.scm | 19 ++++++++++++++++++- guix/build/cmake-build-system.scm | 11 ----------- 3 files changed, 20 insertions(+), 16 deletions(-) base-commit: 7a149c6003d25e8b2794b113d34062be134d7710 -- 2.45.2