* [bug#62132] [PATCH] gnu: Add cyanrip.
@ 2023-03-11 22:30 simon
2023-03-13 20:42 ` Liliana Marie Prikler
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: simon @ 2023-03-11 22:30 UTC (permalink / raw)
To: 62132; +Cc: Simon Streit
From: Simon Streit <simon@netpanic.org>
* gnu/packages/audio.scm (cyanrip): New variable.
---
gnu/packages/audio.scm | 30 +++++++++++++++++++++++++++++-
1 file changed, 29 insertions(+), 1 deletion(-)
diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
index 6f3fa2a580..966a0b96f9 100644
--- a/gnu/packages/audio.scm
+++ b/gnu/packages/audio.scm
@@ -38,7 +38,7 @@
;;; Copyright © 2021 Aleksandr Vityazev <avityazev@posteo.org>
;;; Copyright © 2022 Arjan Adriaanse <arjan@adriaan.se>
;;; Copyright © 2022 Juliana Sims <jtsims@protonmail.com>
-;;; Copyright © 2022 Simon Streit <simon@netpanic.org>
+;;; Copyright © 2022, 2023 Simon Streit <simon@netpanic.org>
;;; Copyright © 2022 Andy Tai <atai@atai.org>
;;; Copyright © 2023 Sergiu Ivanov <sivanov@colimite.fr>
;;; Copyright © 2023 David Thompson <dthompson2@worcester.edu>
@@ -68,6 +68,7 @@ (define-module (gnu packages audio)
#:use-module (gnu packages bison)
#:use-module (gnu packages build-tools)
#:use-module (gnu packages boost)
+ #:use-module (gnu packages cdrom)
#:use-module (gnu packages check)
#:use-module (gnu packages compression)
#:use-module (gnu packages curl)
@@ -124,6 +125,7 @@ (define-module (gnu packages audio)
#:use-module (gnu packages linux)
#:use-module (gnu packages tls)
#:use-module (gnu packages valgrind)
+ #:use-module (gnu packages version-control)
#:use-module (gnu packages video)
#:use-module (gnu packages vim) ;xxd
#:use-module (gnu packages web)
@@ -6316,3 +6318,29 @@ (define-public cubeb
(description "Cubeb is Mozilla's cross-platform audio library.")
(home-page "https://github.com/mozilla/cubeb")
(license license:isc))))
+
+(define-public cyanrip
+ (package
+ (name "cyanrip")
+ (version "0.9.0")
+ (source
+ (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/cyanreg/cyanrip")
+ (commit (string-append "v" version))))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32
+ "1pf381qmqr3p3xk26w8v4gfv5cyi5siljs4gv485spsq6icynzw0"))))
+ (build-system meson-build-system)
+ (native-inputs
+ (list pkg-config))
+ (propagated-inputs
+ (list curl ffmpeg libcdio-paranoia libmusicbrainz libxml2 neon))
+ (synopsis "Fully featured CD ripping program")
+ (description "Console CD ripper with automatic tagging through integration
+with MusicBrainz , error detection, log generation, many formats, HDCD
+decoding, covert art automatic download.")
+ (home-page "https://github.com/cyanreg/cyanrip")
+ (license license:lgpl2.1+)))
--
2.39.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [bug#62132] [PATCH] gnu: Add cyanrip.
2023-03-11 22:30 [bug#62132] [PATCH] gnu: Add cyanrip simon
@ 2023-03-13 20:42 ` Liliana Marie Prikler
2024-07-28 12:10 ` [bug#62132] [PATCH v2 0/1] " mio via Guix-patches via
2024-07-29 10:58 ` [bug#62132] [PATCH v3] " mio via Guix-patches via
2 siblings, 0 replies; 7+ messages in thread
From: Liliana Marie Prikler @ 2023-03-13 20:42 UTC (permalink / raw)
To: simon, 62132
Am Samstag, dem 11.03.2023 um 23:30 +0100 schrieb simon@netpanic.org:
> From: Simon Streit <simon@netpanic.org>
>
> * gnu/packages/audio.scm (cyanrip): New variable.
> ---
> gnu/packages/audio.scm | 30 +++++++++++++++++++++++++++++-
> 1 file changed, 29 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
> index 6f3fa2a580..966a0b96f9 100644
> --- a/gnu/packages/audio.scm
> +++ b/gnu/packages/audio.scm
> @@ -38,7 +38,7 @@
> ;;; Copyright © 2021 Aleksandr Vityazev <avityazev@posteo.org>
> ;;; Copyright © 2022 Arjan Adriaanse <arjan@adriaan.se>
> ;;; Copyright © 2022 Juliana Sims <jtsims@protonmail.com>
> -;;; Copyright © 2022 Simon Streit <simon@netpanic.org>
> +;;; Copyright © 2022, 2023 Simon Streit <simon@netpanic.org>
> ;;; Copyright © 2022 Andy Tai <atai@atai.org>
> ;;; Copyright © 2023 Sergiu Ivanov <sivanov@colimite.fr>
> ;;; Copyright © 2023 David Thompson <dthompson2@worcester.edu>
> @@ -68,6 +68,7 @@ (define-module (gnu packages audio)
> #:use-module (gnu packages bison)
> #:use-module (gnu packages build-tools)
> #:use-module (gnu packages boost)
> + #:use-module (gnu packages cdrom)
> #:use-module (gnu packages check)
> #:use-module (gnu packages compression)
> #:use-module (gnu packages curl)
> @@ -124,6 +125,7 @@ (define-module (gnu packages audio)
> #:use-module (gnu packages linux)
> #:use-module (gnu packages tls)
> #:use-module (gnu packages valgrind)
> + #:use-module (gnu packages version-control)
> #:use-module (gnu packages video)
> #:use-module (gnu packages vim) ;xxd
> #:use-module (gnu packages web)
> @@ -6316,3 +6318,29 @@ (define-public cubeb
> (description "Cubeb is Mozilla's cross-platform audio
> library.")
> (home-page "https://github.com/mozilla/cubeb")
> (license license:isc))))
> +
> +(define-public cyanrip
> + (package
> + (name "cyanrip")
> + (version "0.9.0")
> + (source
> + (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://github.com/cyanreg/cyanrip")
> + (commit (string-append "v" version))))
> + (file-name (git-file-name name version))
> + (sha256
> + (base32
> + "1pf381qmqr3p3xk26w8v4gfv5cyi5siljs4gv485spsq6icynzw0"))))
> + (build-system meson-build-system)
> + (native-inputs
> + (list pkg-config))
> + (propagated-inputs
> + (list curl ffmpeg libcdio-paranoia libmusicbrainz libxml2
> neon))
Propagated inputs are not that great, prefer normal ones. Also don't
let the lines get too long.
> + (synopsis "Fully featured CD ripping program")
Avoid marketing buzzwords; perhaps use "Console CD ripper" instead?
> + (description "Console CD ripper with automatic tagging through
> integration
> +with MusicBrainz , error detection, log generation, many formats,
> HDCD
> +decoding, covert art automatic download.")
Please use complete sentences for the description.
Cheers
^ permalink raw reply [flat|nested] 7+ messages in thread
* [bug#62132] [PATCH v2 0/1] gnu: Add cyanrip.
2023-03-11 22:30 [bug#62132] [PATCH] gnu: Add cyanrip simon
2023-03-13 20:42 ` Liliana Marie Prikler
@ 2024-07-28 12:10 ` mio via Guix-patches via
2024-07-28 12:10 ` [bug#62132] [PATCH v2 1/1] " mio via Guix-patches via
2024-07-29 10:58 ` [bug#62132] [PATCH v3] " mio via Guix-patches via
2 siblings, 1 reply; 7+ messages in thread
From: mio via Guix-patches via @ 2024-07-28 12:10 UTC (permalink / raw)
To: 62132; +Cc: mio, Simon Streit, Liliana Marie Prikler
> Propagated inputs are not that great, prefer normal ones. Also don't
> let the lines get too long.
> [...]
> Avoid marketing buzzwords; perhaps use "Console CD ripper" instead?
> [...]
> Please use complete sentences for the description.
Hey, I hope you don't mind but I updated the package definition to use the
latest version of cyanrip (0.9.3.1) and modified the synopsis and description
to be more complete and neutral.
Simon Streit (1):
gnu: Add cyanrip.
gnu/packages/audio.scm | 37 ++++++++++++++++++++++++++++++++++++-
1 file changed, 36 insertions(+), 1 deletion(-)
base-commit: 46a64c7fdd057283063aae6df058579bb07c4b6a
--
2.39.2
^ permalink raw reply [flat|nested] 7+ messages in thread
* [bug#62132] [PATCH v2 1/1] gnu: Add cyanrip.
2024-07-28 12:10 ` [bug#62132] [PATCH v2 0/1] " mio via Guix-patches via
@ 2024-07-28 12:10 ` mio via Guix-patches via
2024-07-28 18:46 ` Liliana Marie Prikler
0 siblings, 1 reply; 7+ messages in thread
From: mio via Guix-patches via @ 2024-07-28 12:10 UTC (permalink / raw)
To: 62132; +Cc: mio, Simon Streit, Liliana Marie Prikler
From: Simon Streit <simon@netpanic.org>
* gnu/packages/audio.scm (cyanrip): New variable.
Signed-off-by: mio <stigma@disroot.org>
Change-Id: If7059b47e5a9f968570af8617f28bbe9a8b30b93
---
gnu/packages/audio.scm | 37 ++++++++++++++++++++++++++++++++++++-
1 file changed, 36 insertions(+), 1 deletion(-)
diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
index b728220e1f..0aea78b117 100644
--- a/gnu/packages/audio.scm
+++ b/gnu/packages/audio.scm
@@ -38,7 +38,7 @@
;;; Copyright © 2021 Aleksandr Vityazev <avityazev@posteo.org>
;;; Copyright © 2022 Arjan Adriaanse <arjan@adriaan.se>
;;; Copyright © 2022, 2023 Juliana Sims <juli@incana.org>
-;;; Copyright © 2022 Simon Streit <simon@netpanic.org>
+;;; Copyright © 2022, 2023 Simon Streit <simon@netpanic.org>
;;; Copyright © 2022 Andy Tai <atai@atai.org>
;;; Copyright © 2023 Sergiu Ivanov <sivanov@colimite.fr>
;;; Copyright © 2023 David Thompson <dthompson2@worcester.edu>
@@ -47,6 +47,7 @@
;;; Copyright © 2023 Zheng Junjie <873216071@qq.com>
;;; Copyright © 2023 Parnikkapore <poomklao@yahoo.com>
;;; Copyright © 2024 hapster <o.rojon@posteo.net>
+;;; Copyright © 2024 mio <stigma@disroot.org>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -74,6 +75,7 @@ (define-module (gnu packages audio)
#:use-module (gnu packages boost)
#:use-module (gnu packages build-tools)
#:use-module (gnu packages check)
+ #:use-module (gnu packages cdrom)
#:use-module (gnu packages compression)
#:use-module (gnu packages cpp)
#:use-module (gnu packages curl)
@@ -137,6 +139,7 @@ (define-module (gnu packages audio)
#:use-module (gnu packages telephony)
#:use-module (gnu packages tls)
#:use-module (gnu packages valgrind)
+ #:use-module (gnu packages version-control)
#:use-module (gnu packages video)
#:use-module (gnu packages vim) ;xxd
#:use-module (gnu packages web)
@@ -6537,6 +6540,38 @@ (define-public cubeb
(home-page "https://github.com/mozilla/cubeb")
(license license:isc))))
+(define-public cyanrip
+ (package
+ (name "cyanrip")
+ (version "0.9.3.1")
+ (source
+ (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/cyanreg/cyanrip")
+ (commit (string-append "v" version))))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32 "13v6gjbxw6ybviq802wmgwlwy846ma4yw94aay0h698qhjqwf0qq"))))
+ (build-system meson-build-system)
+ (native-inputs (list pkg-config))
+ (inputs (list curl
+ ffmpeg
+ libcdio-paranoia
+ libmusicbrainz
+ libxml2
+ neon))
+ (synopsis "Command line CD ripper and encoder")
+ (description
+ "cyanrip is a command line tool for ripping CDs. It uses
+MusicBrainz to name and tag each track, and to download and embed cover art.
+cyanrip supports encoding tracks to multiple formats in parallel, and can
+save files in FLAC, Opus, MP3, TTA (True Audio), WavPac, ALAC, Vorbis, and
+AAC formats. Checksums for ripped tracks are automatically verified using
+the Exact Audio Copy CRC32 and AccurateRip V1 and V2 databases.")
+ (home-page "https://github.com/cyanreg/cyanrip")
+ (license license:lgpl2.1+)))
+
(define-public easyeffects
(package
(name "easyeffects")
--
2.39.2
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [bug#62132] [PATCH v2 1/1] gnu: Add cyanrip.
2024-07-28 12:10 ` [bug#62132] [PATCH v2 1/1] " mio via Guix-patches via
@ 2024-07-28 18:46 ` Liliana Marie Prikler
0 siblings, 0 replies; 7+ messages in thread
From: Liliana Marie Prikler @ 2024-07-28 18:46 UTC (permalink / raw)
To: mio, 62132; +Cc: Simon Streit
Am Sonntag, dem 28.07.2024 um 22:10 +1000 schrieb mio:
> From: Simon Streit <simon@netpanic.org>
>
> * gnu/packages/audio.scm (cyanrip): New variable.
>
> Signed-off-by: mio <stigma@disroot.org>
> Change-Id: If7059b47e5a9f968570af8617f28bbe9a8b30b93
> ---
> gnu/packages/audio.scm | 37 ++++++++++++++++++++++++++++++++++++-
> 1 file changed, 36 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
> index b728220e1f..0aea78b117 100644
> --- a/gnu/packages/audio.scm
> +++ b/gnu/packages/audio.scm
> @@ -38,7 +38,7 @@
> ;;; Copyright © 2021 Aleksandr Vityazev <avityazev@posteo.org>
> ;;; Copyright © 2022 Arjan Adriaanse <arjan@adriaan.se>
> ;;; Copyright © 2022, 2023 Juliana Sims <juli@incana.org>
> -;;; Copyright © 2022 Simon Streit <simon@netpanic.org>
> +;;; Copyright © 2022, 2023 Simon Streit <simon@netpanic.org>
> ;;; Copyright © 2022 Andy Tai <atai@atai.org>
> ;;; Copyright © 2023 Sergiu Ivanov <sivanov@colimite.fr>
> ;;; Copyright © 2023 David Thompson <dthompson2@worcester.edu>
> @@ -47,6 +47,7 @@
> ;;; Copyright © 2023 Zheng Junjie <873216071@qq.com>
> ;;; Copyright © 2023 Parnikkapore <poomklao@yahoo.com>
> ;;; Copyright © 2024 hapster <o.rojon@posteo.net>
> +;;; Copyright © 2024 mio <stigma@disroot.org>
> ;;;
> ;;; This file is part of GNU Guix.
> ;;;
> @@ -74,6 +75,7 @@ (define-module (gnu packages audio)
> #:use-module (gnu packages boost)
> #:use-module (gnu packages build-tools)
> #:use-module (gnu packages check)
> + #:use-module (gnu packages cdrom)
> #:use-module (gnu packages compression)
> #:use-module (gnu packages cpp)
> #:use-module (gnu packages curl)
> @@ -137,6 +139,7 @@ (define-module (gnu packages audio)
> #:use-module (gnu packages telephony)
> #:use-module (gnu packages tls)
> #:use-module (gnu packages valgrind)
> + #:use-module (gnu packages version-control)
> #:use-module (gnu packages video)
> #:use-module (gnu packages vim) ;xxd
> #:use-module (gnu packages web)
> @@ -6537,6 +6540,38 @@ (define-public cubeb
> (home-page "https://github.com/mozilla/cubeb")
> (license license:isc))))
>
> +(define-public cyanrip
> + (package
> + (name "cyanrip")
> + (version "0.9.3.1")
> + (source
> + (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://github.com/cyanreg/cyanrip")
> + (commit (string-append "v" version))))
> + (file-name (git-file-name name version))
> + (sha256
> + (base32
> "13v6gjbxw6ybviq802wmgwlwy846ma4yw94aay0h698qhjqwf0qq"))))
> + (build-system meson-build-system)
> + (native-inputs (list pkg-config))
> + (inputs (list curl
> + ffmpeg
> + libcdio-paranoia
> + libmusicbrainz
> + libxml2
> + neon))
> + (synopsis "Command line CD ripper and encoder")
> + (description
> + "cyanrip is a command line tool for ripping CDs. It uses
> +MusicBrainz to name and tag each track, and to download and embed
> cover art.
> +cyanrip supports encoding tracks to multiple formats in parallel,
> and can
> +save files in FLAC, Opus, MP3, TTA (True Audio), WavPac, ALAC,
> Vorbis, and
Perhaps we can shorten that to just "multiple formats in parallel"?
> +AAC formats. Checksums for ripped tracks are automatically verified
> using
> +the Exact Audio Copy CRC32 and AccurateRip V1 and V2 databases.")
Perhaps shorten this to "Checksums are automatically verified"?
> + (home-page "https://github.com/cyanreg/cyanrip")
> + (license license:lgpl2.1+)))
Otherwise LGTM.
Cheers
^ permalink raw reply [flat|nested] 7+ messages in thread
* [bug#62132] [PATCH v3] gnu: Add cyanrip.
2023-03-11 22:30 [bug#62132] [PATCH] gnu: Add cyanrip simon
2023-03-13 20:42 ` Liliana Marie Prikler
2024-07-28 12:10 ` [bug#62132] [PATCH v2 0/1] " mio via Guix-patches via
@ 2024-07-29 10:58 ` mio via Guix-patches via
2024-08-04 6:01 ` bug#62132: " Liliana Marie Prikler
2 siblings, 1 reply; 7+ messages in thread
From: mio via Guix-patches via @ 2024-07-29 10:58 UTC (permalink / raw)
To: 62132; +Cc: mio, Simon Streit, Liliana Marie Prikler
From: Simon Streit <simon@netpanic.org>
* gnu/packages/audio.scm (cyanrip): New variable.
Signed-off-by: mio <stigma@disroot.org>
Change-Id: If7059b47e5a9f968570af8617f28bbe9a8b30b93
---
gnu/packages/audio.scm | 35 ++++++++++++++++++++++++++++++++++-
1 file changed, 34 insertions(+), 1 deletion(-)
diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
index b728220e1f..1e7ee55bfc 100644
--- a/gnu/packages/audio.scm
+++ b/gnu/packages/audio.scm
@@ -38,7 +38,7 @@
;;; Copyright © 2021 Aleksandr Vityazev <avityazev@posteo.org>
;;; Copyright © 2022 Arjan Adriaanse <arjan@adriaan.se>
;;; Copyright © 2022, 2023 Juliana Sims <juli@incana.org>
-;;; Copyright © 2022 Simon Streit <simon@netpanic.org>
+;;; Copyright © 2022, 2023 Simon Streit <simon@netpanic.org>
;;; Copyright © 2022 Andy Tai <atai@atai.org>
;;; Copyright © 2023 Sergiu Ivanov <sivanov@colimite.fr>
;;; Copyright © 2023 David Thompson <dthompson2@worcester.edu>
@@ -47,6 +47,7 @@
;;; Copyright © 2023 Zheng Junjie <873216071@qq.com>
;;; Copyright © 2023 Parnikkapore <poomklao@yahoo.com>
;;; Copyright © 2024 hapster <o.rojon@posteo.net>
+;;; Copyright © 2024 mio <stigma@disroot.org>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -74,6 +75,7 @@ (define-module (gnu packages audio)
#:use-module (gnu packages boost)
#:use-module (gnu packages build-tools)
#:use-module (gnu packages check)
+ #:use-module (gnu packages cdrom)
#:use-module (gnu packages compression)
#:use-module (gnu packages cpp)
#:use-module (gnu packages curl)
@@ -137,6 +139,7 @@ (define-module (gnu packages audio)
#:use-module (gnu packages telephony)
#:use-module (gnu packages tls)
#:use-module (gnu packages valgrind)
+ #:use-module (gnu packages version-control)
#:use-module (gnu packages video)
#:use-module (gnu packages vim) ;xxd
#:use-module (gnu packages web)
@@ -6537,6 +6540,36 @@ (define-public cubeb
(home-page "https://github.com/mozilla/cubeb")
(license license:isc))))
+(define-public cyanrip
+ (package
+ (name "cyanrip")
+ (version "0.9.3.1")
+ (source
+ (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/cyanreg/cyanrip")
+ (commit (string-append "v" version))))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32 "13v6gjbxw6ybviq802wmgwlwy846ma4yw94aay0h698qhjqwf0qq"))))
+ (build-system meson-build-system)
+ (native-inputs (list pkg-config))
+ (inputs (list curl
+ ffmpeg
+ libcdio-paranoia
+ libmusicbrainz
+ libxml2
+ neon))
+ (synopsis "Command line CD ripper and encoder")
+ (description
+ "cyanrip is a command line tool for ripping CDs. It uses
+MusicBrainz to name and tag each track, and to download and embed cover art.
+cyanrip supports encoding tracks to multiple formats in parallel and automatically
+verifies checksums.")
+ (home-page "https://github.com/cyanreg/cyanrip")
+ (license license:lgpl2.1+)))
+
(define-public easyeffects
(package
(name "easyeffects")
--
2.39.2
^ permalink raw reply related [flat|nested] 7+ messages in thread
* bug#62132: [PATCH v3] gnu: Add cyanrip.
2024-07-29 10:58 ` [bug#62132] [PATCH v3] " mio via Guix-patches via
@ 2024-08-04 6:01 ` Liliana Marie Prikler
0 siblings, 0 replies; 7+ messages in thread
From: Liliana Marie Prikler @ 2024-08-04 6:01 UTC (permalink / raw)
To: mio, 62132-done; +Cc: Simon Streit
Am Montag, dem 29.07.2024 um 20:58 +1000 schrieb mio:
> From: Simon Streit <simon@netpanic.org>
>
> * gnu/packages/audio.scm (cyanrip): New variable.
>
> Signed-off-by: mio <stigma@disroot.org>
> Change-Id: If7059b47e5a9f968570af8617f28bbe9a8b30b93
Pushed as 4e9c5c601905eb281f2304d0a0d35992c51054cd.
Heads-up, I just now noticed that you used Signed-off-by: instead of
Co-authored-by: to signal co-authorship. Let's avoid that next time ;)
Cheers
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2024-08-04 6:04 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-03-11 22:30 [bug#62132] [PATCH] gnu: Add cyanrip simon
2023-03-13 20:42 ` Liliana Marie Prikler
2024-07-28 12:10 ` [bug#62132] [PATCH v2 0/1] " mio via Guix-patches via
2024-07-28 12:10 ` [bug#62132] [PATCH v2 1/1] " mio via Guix-patches via
2024-07-28 18:46 ` Liliana Marie Prikler
2024-07-29 10:58 ` [bug#62132] [PATCH v3] " mio via Guix-patches via
2024-08-04 6:01 ` bug#62132: " Liliana Marie Prikler
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).