From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id IEdVNFbU12VaeAAAe85BDQ:P1 (envelope-from ) for ; Fri, 23 Feb 2024 00:10:15 +0100 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id IEdVNFbU12VaeAAAe85BDQ (envelope-from ) for ; Fri, 23 Feb 2024 00:10:14 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=incana.org header.s=gm1 header.b=exq+GxCJ; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1708643414; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=E/wu8JkIleBqDy0jDp3gI0e9ZAnvlKcfTsaWUyjYJ7I=; b=SVOVxV7BmYbKLtSBYyr0VlLG0QRHb3IIaHx0s6NkdHes/rrGlNHabMyKoxY/WBvnJ1IL2q BQzaUt3BZ3j2woOZMsJ34X4rCtY2XSPiNetog/QAgLNsPc/Fcz0aQeJgVPnMuNdknrUUGr T72h269OBksRsZO0W0gOewZ57zCRuUFVD7//DgX8cKy2VKodmxuwoUOupPCTe5aVsksXb4 /9nPVIaGo0FScYGHEjYPUrZHMeGLXcOzN0FHzOboeDl68QrTDOcjy9jQ0z+kxwdVzg4IC2 ga1jjU9eDqdcFmn2oQaLq5XhROHlC8bW9XgsX//6nU0G4CGqMQu9ZuMsvKNLCw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=incana.org header.s=gm1 header.b=exq+GxCJ; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Seal: i=1; s=key1; d=yhetil.org; t=1708643414; a=rsa-sha256; cv=none; b=JFJYCxQDHHJNCfITGxUzVxC7IfeoAJEhxYhS+ysv+cOz0m3CkkcEjgj3zFaKa9TwEeYURu MaedXNS+5m/UEf/oWUdFy8uaoyGO3KG+qt3GtQtr284kdH7OfGG5RQzhSin8LyxsKVVZT3 d1EJr4p1Xauv+ZGerlPQfNaxAbO5fK6EYodKWeB6ihRlQL6XQLqhWgvrUst+lIiVSAPLIt /IeqY4Oz9DuwM08l0pMQClOvsbh27KKM2OaO/uiuqy/vR9dhEhlRLg6X8IV3HHET+1WnWN dwVOQs6qNjDOh1Uejw3DUhPXQrPy4KQGpbPXPgtJwRQPHqkq76kKTjAU+ObgYw== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 786A9316EA for ; Fri, 23 Feb 2024 00:10:14 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rdICL-0000tv-M5; Thu, 22 Feb 2024 18:09:49 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rdICF-0000tE-Uk for guix-patches@gnu.org; Thu, 22 Feb 2024 18:09:43 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rdICF-0002KY-Cc for guix-patches@gnu.org; Thu, 22 Feb 2024 18:09:43 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rdICY-0002GC-MB; Thu, 22 Feb 2024 18:10:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#69313] [PATCH v2 0/2] gnu: tlpui: Fix location for "defaults.conf". Resent-From: Juliana Sims Original-Sender: "Debbugs-submit" Resent-CC: leo@famulari.name, me@tobias.gr, w@wmeyer.eu, guix-patches@gnu.org Resent-Date: Thu, 22 Feb 2024 23:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69313 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 69313@debbugs.gnu.org Cc: Juliana Sims , Leo Famulari , Tobias Geerinckx-Rice , Wilko Meyer X-Debbugs-Original-Xcc: Leo Famulari , Tobias Geerinckx-Rice , Wilko Meyer Received: via spool by 69313-submit@debbugs.gnu.org id=B69313.17086433688562 (code B ref 69313); Thu, 22 Feb 2024 23:10:02 +0000 Received: (at 69313) by debbugs.gnu.org; 22 Feb 2024 23:09:28 +0000 Received: from localhost ([127.0.0.1]:39178 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rdIBz-0002E1-D1 for submit@debbugs.gnu.org; Thu, 22 Feb 2024 18:09:27 -0500 Received: from relay7-d.mail.gandi.net ([217.70.183.200]:60411) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rdIBx-0002Dc-IY for 69313@debbugs.gnu.org; Thu, 22 Feb 2024 18:09:26 -0500 Received: by mail.gandi.net (Postfix) with ESMTPSA id DB4EF20003; Thu, 22 Feb 2024 23:08:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=incana.org; s=gm1; t=1708643316; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=E/wu8JkIleBqDy0jDp3gI0e9ZAnvlKcfTsaWUyjYJ7I=; b=exq+GxCJ+nqX47oruJ0vIBeqPVm4NePhAUjvE/j4DcAkRjGn6EF4qYjaCE3q652AXmRJmU tt8dXgKGd/fEXyEeiMnX0wKQFGmxr7LZr6eNh6OYOr7Jtpau3RGYN1hPF6kz571IiqRY8i dxxsXEQSrehM8BgyCNjug8hodE/wVZk9xnNhGUG+DrbkSKduyG0CO2O7r0JFHwLOMhMHdz Tn7vQaSOcyqlumyG7mk9QK3r3k589jaCc4KlzGEWZnBRKJ1kQ6m5EMj/oemZdH33EUa2Sr 2OQJKQBCI2F4324sY6efM1Gxbk2QI9k/R4PIMSZ9RVVsiqi6qSThPnxAjG+3Ug== From: Juliana Sims Date: Thu, 22 Feb 2024 17:56:57 -0500 Message-ID: X-Mailer: git-send-email 2.41.0 In-Reply-To: <87il2gcfvm.fsf@nicolasgoaziou.fr> References: <87il2gcfvm.fsf@nicolasgoaziou.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-GND-Sasl: juli@incana.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Scanner: mx12.migadu.com X-Migadu-Spam-Score: -1.37 X-Spam-Score: -1.37 X-Migadu-Queue-Id: 786A9316EA X-TUID: 0t/gGt/dBymN > how does this relate to other changes in the patch (lsusb and lspci)? It doesn't! I meant to split these into separate commits but was very tired. Don't code sleepy, kids! > I'm a bit puzzled here: how does > > (search-input-file inputs "/share/tlp/defaults.conf") > > differ from > > #$(file-append tlp "/share/tlp/defaults.conf") The latter directly accesses the input in question then joins its path with the provided string and inserts the result where the `file-append` form was in the code. The former searches each input's store directory at build time to find a matching file. In other words, since we know exactly where to find these files ahead of time, we simply tell the build dæmon where they are rather than making it look for them. Because this is a quite minor performance improvement and code modernization, rather than a requirement for the package to build, I've split it into a second patch to be applied at the discretion of a commiter. > I think the commit message could be expounded a bit, e.g., > > * gnu/packages/linux.scm (tlpui)[arguments]: Fix location for "defaults.conf". Good idea! I've modified the commit messages to be more precise :) Thanks, Juli Juliana Sims (2): gnu: tlpui: Fix location for "defaults.conf". gnu: tlpui: Reference inputs directly during build. gnu/packages/linux.scm | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) base-commit: 34ce59bb0668e75d40f42b89e36dc9af6f548e4c -- 2.41.0