From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id 6PYmJ8AR1mRJjwAASxT56A (envelope-from ) for ; Fri, 11 Aug 2023 12:47:28 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id yP/ZJsAR1mQGygAA9RJhRA (envelope-from ) for ; Fri, 11 Aug 2023 12:47:28 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 4405D5ACBC for ; Fri, 11 Aug 2023 12:47:28 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=ultrarare.space header.s=dkim header.b=il45LfNW; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1691750848; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=57BDcjj3ibhAhQ9GZZ03x72ydGWv9zin91ZHqYyUzJw=; b=BOkYPQOqjN3UTXkzg6gdgCRovnzTKp6pvSj43fwVeqwjoA5wQknD5DYNEAJSyPOffg1Ng/ qLs6rkd/TRfrSkvf2ipf5Xo7a+eksMVKAewhmeR7fkNiS9/wN8U8rPFAM+T2cfefGLqzw7 BqpoVyNJ2T4JPG0GjESAtf/RfqwfIf5fDuvHX8DGYKsPjX8dGdN45zwEpr6VePvxV7OIdu ysUITLke62r9FSkBk463QFcxuWW7QEzODk6dufpYIiS2TWIyK4fJh/6lrQsR3RuN/COxVI NqI8hmf9rV+lja/szk9ebWKXyT7pHGoYCOZpZZJ3wA/iv2ZtluXuzHxJQTqpzQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1691750848; a=rsa-sha256; cv=none; b=qBfUSkz1MWsIjUyJpWC0NFdf+pQ++PDF/ziNLpHQFL+5FgXeRjaBx9L8dAbumedP2NLIfb zeu/36rrzF1qyG7L8IxsD/4RzP+79ZmejgbcKciHpI9izn/7mx8vW2ASDHJyAR8W0H9fRa kRIO5Po/OtYz9rGXn1bYwbDNJht/jPLGDN93NEKll+sLiyw8AQv+qetZ9VhSY5fF+gZtTf YHZ2Kr9RneIJoauNG9NWj3SvL2tRijGFVIzbEU+GDHrlftl8I/oi1FCY28pWfPEvubk9w0 MKXXeQ97PYXOTRZefOrf6EQw291pE8Juy8VV3/H7WhpSTSCvVx15d7NbNEEFNA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=ultrarare.space header.s=dkim header.b=il45LfNW; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qUPff-0001s0-Hi; Fri, 11 Aug 2023 06:47:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qUPfa-0001oU-Up for guix-patches@gnu.org; Fri, 11 Aug 2023 06:47:03 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qUPfa-00032o-HI for guix-patches@gnu.org; Fri, 11 Aug 2023 06:47:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qUPfa-0000MO-Cl for guix-patches@gnu.org; Fri, 11 Aug 2023 06:47:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#64910] [PATCH v2 0/3] gnu: docker: Update to 20.10.25. Resent-From: Hilton Chain Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 11 Aug 2023 10:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64910 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 64910@debbugs.gnu.org Cc: Hilton Chain Received: via spool by 64910-submit@debbugs.gnu.org id=B64910.16917507751084 (code B ref 64910); Fri, 11 Aug 2023 10:47:02 +0000 Received: (at 64910) by debbugs.gnu.org; 11 Aug 2023 10:46:15 +0000 Received: from localhost ([127.0.0.1]:45002 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qUPep-0000HQ-9d for submit@debbugs.gnu.org; Fri, 11 Aug 2023 06:46:15 -0400 Received: from mail.boiledscript.com ([144.168.59.46]:33516) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qUPel-0000HE-Nj for 64910@debbugs.gnu.org; Fri, 11 Aug 2023 06:46:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ultrarare.space; s=dkim; t=1691750762; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=57BDcjj3ibhAhQ9GZZ03x72ydGWv9zin91ZHqYyUzJw=; b=il45LfNWQ4cvZViNRZ997wgAl1cDkV8R8p6jMG32/3rtCYQeSpz1/p147JBegclOmcl+V4 d8thuE2aTWjbWdyrVhofI8pQe0yfF/ZS7o27gPadUdIffcouDBLBqbPJAgX5s+LLXI3RLh 0wbRokNDU+Unsg9ZcLraB51SZkXJ/W0xzC9iKv/mj1y7LpJnTUDVJ3uGlLYWETnHMwrFl4 WfFQOm6j04XfbgQua2ZeY5lJyG2+D55BvKXyYHd4gPVNMGUK+QKulsHZhYH2J0A/5y2p6D uDS4ibQldh9oNubCA5PYUmxhJEHU+0b1ucxIpKnogEY06685Z/u3HEBrQQd36g== Date: Fri, 11 Aug 2023 18:45:05 +0800 Message-ID: In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spamd-Bar: + X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Hilton Chain X-ACL-Warn: , Hilton Chain via Guix-patches From: Hilton Chain via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Queue-Id: 4405D5ACBC X-Migadu-Scanner: mx0.migadu.com X-Migadu-Spam-Score: -6.18 X-Spam-Score: -6.18 X-TUID: dzHV5sh/R4kB V1 -> V2: - runc@1.1.9 - Fix containerd starting issue. `make check-system TESTS=docker' passes. Details on the issue: Error message: --8<---------------cut here---------------start------------->8--- msg="failed to load plugin io.containerd.grpc.v1.cri" error="invalid plugin config: no corresponding runtime configured in `containerd.runtimes` for `containerd` `default_runtime_name` = \"/gnu/store/...-runc-1.1.9/sbin/runc\"" --8<---------------cut here---------------end--------------->8--- The message comes from pkg/cri/config/config.go: --8<---------------cut here---------------start------------->8--- if _, ok := c.ContainerdConfig.Runtimes[c.ContainerdConfig.DefaultRuntimeName]; !ok { return fmt.Errorf("no corresponding runtime configured in `containerd.runtimes` for `containerd` `default_runtime_name = \"%s\"", c.ContainerdConfig.DefaultRuntimeName) } --8<---------------cut here---------------end--------------->8--- It expects there's `ContainerdConfig.DefaultRuntimeName' within `ContainerdConfig.Runtimes'. And from the relevant code in pkg/cri/config/config_unix.go and the package definion, "runc" the `DefaultRuntimeName' was substituted to a store path, but not "runc" in `Runtimes'. So [...].Runtimes["/gnu/store/...-runc-1.1.9/sbin/runc"] fails. --8<---------------cut here---------------start------------->8--- func DefaultConfig() PluginConfig { [...] return PluginConfig{ [...] ContainerdConfig: ContainerdConfig{ [...] DefaultRuntimeName: "runc", Runtimes: map[string]Runtime{ "runc": { [...] }, }, [...] }, [...] } } --8<---------------cut here---------------end--------------->8--- There's no functional change in those two files between 1.6.6 and 1.6.22, I wonder why this wasn't an issue before... Thanks Hilton Chain (3): gnu: runc: Update to 1.1.9. gnu: containerd: Update to 1.6.22. gnu: docker: Update to 20.10.25. gnu/packages/docker.scm | 25 +++++++++++++++---------- gnu/packages/virtualization.scm | 4 ++-- 2 files changed, 17 insertions(+), 12 deletions(-) base-commit: ad4520b92662e42d7d0b1e648b2068300dbb95c8 -- 2.41.0