unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Simon South <simon@simonsouth.net>
To: 61120@debbugs.gnu.org
Subject: [bug#61120] [PATCH core-updates 0/1] gnu: mesa: Fix sporadic test failures.
Date: Sat, 28 Jan 2023 08:30:38 -0500	[thread overview]
Message-ID: <cover.1674910858.git.simon@simonsouth.net> (raw)

On core-updates, I've found Mesa will sometimes fail its test suite with error
messages like

  ../mesa-22.2.4/src/gallium/drivers/r600/sfn/tests/sfn_instrfromstring_test.cpp:712: Failure
  Expected equality of these values:
    os.str()
      Which is: "WRITE_SCRATCH 20 R1.xyzw\xFF\xFF AL:4 ALO:16"
    init
      Which is: "WRITE_SCRATCH 20 R1.xyzw AL:4 ALO:16"

Turns out this is due to an uninitialized buffer in the test suite's code,
reported to upstream with issue 7021[0] and fixed with upstream commit
7749599d[1] in Mesa 22.3.0.

The patch to follow backports this commit to the version in core-updates,
22.2.4, and has eliminated these sporadic failures for me.

Tested on x86-64 and AArch64 and everything seems fine.

[0] https://gitlab.freedesktop.org/mesa/mesa/-/issues/7021

[1] https://gitlab.freedesktop.org/mesa/mesa/-/commit/7749599d737d205a88bbb6fa755ba095d9b581fa

--
Simon South
simon@simonsouth.net


Simon South (1):
  gnu: mesa: Fix sporadic test failures.

 gnu/local.mk                                  |  1 +
 gnu/packages/gl.scm                           |  4 ++-
 .../mesa-fix-sporadic-test-failures.patch     | 27 +++++++++++++++++++
 3 files changed, 31 insertions(+), 1 deletion(-)
 create mode 100644 gnu/packages/patches/mesa-fix-sporadic-test-failures.patch


base-commit: 770d379d7b60590bfdcb749287cb6713dee093ce
prerequisite-patch-id: 418e6f2f834e0f77d4da64e48bf654d610fbfe80
prerequisite-patch-id: 7c9321685c0c33cb9d1438797d2cb2bb540276c4
-- 
2.39.1





             reply	other threads:[~2023-01-28 13:31 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-28 13:30 Simon South [this message]
2023-01-28 13:32 ` [bug#61120] [PATCH core-updates 1/1] gnu: mesa: Fix sporadic test failures Simon South
2023-03-04 16:32   ` bug#61120: [PATCH core-updates 0/1] " Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1674910858.git.simon@simonsouth.net \
    --to=simon@simonsouth.net \
    --cc=61120@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).