From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id cFsoL8CXwGLQfgEAbAwnHQ (envelope-from ) for ; Sat, 02 Jul 2022 21:08:48 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id NUU8LsCXwGIatgAAG6o9tA (envelope-from ) for ; Sat, 02 Jul 2022 21:08:48 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1BCFC315F2 for ; Sat, 2 Jul 2022 21:08:48 +0200 (CEST) Received: from localhost ([::1]:39834 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o7iU2-0001W5-QX for larch@yhetil.org; Sat, 02 Jul 2022 15:08:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34098) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o7iTM-0001TF-V6 for guix-patches@gnu.org; Sat, 02 Jul 2022 15:08:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:48969) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o7iTL-0003OD-4O for guix-patches@gnu.org; Sat, 02 Jul 2022 15:08:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o7iTL-0001dj-00 for guix-patches@gnu.org; Sat, 02 Jul 2022 15:08:03 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#56361] gnu: srt: Update to 1.4.4 (fix test failure on AArch64) Resent-From: Simon South Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 02 Jul 2022 19:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 56361 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: 56361@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.16567888666250 (code B ref -1); Sat, 02 Jul 2022 19:08:02 +0000 Received: (at submit) by debbugs.gnu.org; 2 Jul 2022 19:07:46 +0000 Received: from localhost ([127.0.0.1]:42864 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o7iT4-0001ci-45 for submit@debbugs.gnu.org; Sat, 02 Jul 2022 15:07:46 -0400 Received: from lists.gnu.org ([209.51.188.17]:37518) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o7iT1-0001cX-7q for submit@debbugs.gnu.org; Sat, 02 Jul 2022 15:07:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34036) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o7iT1-0001OV-3s for guix-patches@gnu.org; Sat, 02 Jul 2022 15:07:43 -0400 Received: from mailout.easymail.ca ([64.68.200.34]:51804) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o7iSy-0003L5-R1 for guix-patches@gnu.org; Sat, 02 Jul 2022 15:07:42 -0400 Received: from localhost (localhost [127.0.0.1]) by mailout.easymail.ca (Postfix) with ESMTP id 155546190C for ; Sat, 2 Jul 2022 19:07:38 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at emo07-pco.easydns.vpn Received: from mailout.easymail.ca ([127.0.0.1]) by localhost (emo07-pco.easydns.vpn [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id mCe7RZHwF_9i for ; Sat, 2 Jul 2022 19:07:37 +0000 (UTC) Received: from localhost.localdomain (23-233-96-244.cpe.pppoe.ca [23.233.96.244]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mailout.easymail.ca (Postfix) with ESMTPSA id A5721617F0 for ; Sat, 2 Jul 2022 19:07:37 +0000 (UTC) From: Simon South Date: Sat, 2 Jul 2022 15:07:29 -0400 Message-Id: X-Mailer: git-send-email 2.36.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=64.68.200.34; envelope-from=simon@simonsouth.net; helo=mailout.easymail.ca X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1656788928; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=DmE33zl1vdYoJN2MQnDJNVSRv8fcZcSLFDnni30S+/4=; b=cNIQj08ibLejAMsdFVQLG/EPNrmiZ6dQEMNsCN2BdDv1tap1LLetz5T3aw0ufOypzh4f2R KW1zM5oCJigoSjSrxcD9MyBs02yw6Pf1cUEw82gA3RCNYJU5jsPr32JzwIZ73AFL2Pmxoq zFMp3jwDV5a7A6OJTRqzmqoe7yyiA7i3pubeVmtWE3SyuoPtXDDvZrzrb7cAIhoMXv0K3E b84RLK2/4ybqCsWOi3DBFa7epQUdb0Mfu9BOMvvTo60M/5WJjeOVwiYF3coA95WWky2stL Ts1GhneCyjFo3irsA/5/jhGkOJoxsJMZ+uVlHLuWQEZMQg5l46+ZlwPn3FoteQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1656788928; a=rsa-sha256; cv=none; b=Pwa+fWIJ0sDFVHZ5k9HBwxUjJS//1K647HIHKHWj0+laH3AUij0uFW6rJyaS2aAJWWOUqY fJme1cilEcwc57dLIByb4r7fZgBNi1eorEdCr3ZKbDgiQvaH3jCth5V+MqqyOdvt/W3eTr dlbunaDexfYjFdwQcUblmOYXgWlOPAlJe32Lo3WT4E3LLo9yKyXsHDX+LmCGUOVmUjk+gy +RhPrFZsHzRG4oWcj2M7t4rX5JMCznj4XNHcVKuow0QoRqwt3PW865Q5J32AizYNEuDr+O BrBr0cVi2guJv85v4MQQZwOyIOP7phBpW8wpBouDPvzbz6fV+RUNnmj/LK9Mqw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -1.85 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 1BCFC315F2 X-Spam-Score: -1.85 X-Migadu-Scanner: scn1.migadu.com X-TUID: FAESAFbWwmPv Here's a patch series that - Updates SRT, the "Secure Reliable Transport" for audio/video streams, to 1.4.4, fixing a test failure on AArch64 and likely other non-Intel/AMD platforms[0]; - Updates the srt package itself to remove input labels; - Updates the vlc package to use the now-current version of SRT instead of an older version[1]; - Removes that older (and now unnecessary) version of srt from the package repository; and - Updates the vlc package to remove input labels and to add "bash-minimal" to its inputs, silencing a warning from "guix lint". I'm aware SRT 1.5.0 is also available, but - Version 1.4.4 is the latest version supported by VLC; - Version 1.5.0 introduces API/ABI changes that are likely to cause problems elsewhere; and - I just need to get my systems updating again. (I can look at submitting another patchset later.) I've tested these patches on x86-64 and AArch64 and in general, everything looks fine. With regards to SRT's immediate dependents, ffmpeg@4.4.2, ffmpeg@5.0.1, gst-plugins-bad and and vlc: - All four dependents build without issue on x86-64. - On AArch64, VLC and the two FFmpeg packages build just fine. Building gst-plugins-bad means building the entire Rust toolchain and potentially other packages that are infeasible to build on garden-variety AArch64 hardware, so I haven't been able to test this. - Nonetheless I've verified that on both architectures, VLC built with these patches connects to and plays a SRT video stream just fine.[2] On x86-64 I've tested building all of SRT's 299 dependent packages and this completes without any _new_ build failures: ams-lv2, dvdstyler, lv2-mda-piano and lv2-mda-epiano are all currently broken on x86-64, and it appears my system is unable to build curl 7.84.0 for i686-linux either with or without these patches applied. [0] The failure involves an unnecessarily-short timeout period in the "SyncEvent.WaitForTwoNotifyOne" unit test, which was adjusted in upstream commit e2a00aa: https://github.com/Haivision/srt/commit/e2a00aa03a36e153ab8cfe2c0790f7bf43747d8d It's unlikely this affects only AArch64. A Debian developer notes in this GitHub issue that SRT test failures are common on other, older and mostly non-Intel/AMD architectures as well: https://github.com/Haivision/srt/issues/2267 [1] VLC was updated to build with SRT version 1.4.4 by default in upstream commit 9a28929 this past February, making the comment above the srt-1.4.1 package (in gnu/packages/networking.scm) obsolete. Since neither of the other packages mentioned still use this older version of SRT, nor does any other, the package is no longer needed. https://code.videolan.org/videolan/vlc/-/commit/9a289291d01a393294c62ee7406487f59e25f4ed [2] I'd also like to verify that VLC can _output_ a video stream using SRT but despite an "SRT" output-access module appearing in the configuration settings I can't see how this is meant to work, using either the original or the patched build of VLC. If anyone relies on this functionality and can give me straightforward instructions for testing it I'll be happy to do so before this patch series is committed. --- Simon South (6): gnu: srt: Remove input labels. gnu: srt: Update to 1.4.4. gnu: vlc: Use regular srt. gnu: Remove srt-1.4.1. gnu: vlc: Remove input labels. gnu: vlc: Add bash-minimal as an input. gnu/packages/networking.scm | 26 +----- gnu/packages/video.scm | 155 ++++++++++++++++++------------------ 2 files changed, 79 insertions(+), 102 deletions(-) base-commit: 48ff4bfcd7491c12248b34a82e0b8e8a50a86308 -- 2.36.1