[bug#52806] [PATCH] gnu: Add xinitrc-xsession.

[bug#52806] [PATCH] gnu: Add xinitrc-xsession.

[John Kehayias via Guix-patches via]

[-- Attachment #1: Type: text/plain, Size: 390 bytes --]

Hi Guix,

This is a simple package from Arch's AUR that provides an xsession for using a user's ~/.xinitrc. I've been using this for a while to launch a bare WM (XMonad recently, but others in the past) from GDM and SDDM. There's no formal homepage and the git url will show as 404 in guix lint (I think because there is only git access). I added a description as well.

Thanks!

John

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-Add-xinitrc-xsession.patch --]
[-- Type: text/x-patch; name=0001-gnu-Add-xinitrc-xsession.patch, Size: 2952 bytes --]

From de0672c0376d7e47165c1f1d62aa4413b33717fa Mon Sep 17 00:00:00 2001
From: John Kehayias <john.kehayias@protonmail.com>
Date: Sun, 26 Dec 2021 11:43:26 -0500
Subject: [PATCH] gnu: Add xinitrc-xsession.

* gnu/packages/wm.scm (xinitrc-xsession): New variable.
---
 gnu/packages/wm.scm | 39 +++++++++++++++++++++++++++++++++++++++
 1 file changed, 39 insertions(+)

diff --git a/gnu/packages/wm.scm b/gnu/packages/wm.scm
index c6881154fe..a79a4c7fce 100644
--- a/gnu/packages/wm.scm
+++ b/gnu/packages/wm.scm
@@ -48,6 +48,7 @@
 ;;; Copyright © 2021 Petr Hodina <phodina@protonmail.com>
 ;;; Copyright © 2021 jgart <jgart@dismail.de>
 ;;; Copyright © 2021 Disseminate Dissent <disseminatedissent@protonmail.com>
+;;; Copyright © 2021 John Kehayias <john.kehayias@protonmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -71,6 +72,7 @@ (define-module (gnu packages wm)
   #:use-module (guix git-download)
   #:use-module (guix build-system asdf)
   #:use-module (guix build-system cmake)
+  #:use-module (guix build-system copy)
   #:use-module (guix build-system gnu)
   #:use-module (guix build-system haskell)
   #:use-module (guix build-system meson)
@@ -2317,6 +2319,43 @@ (define-public xclickroot
 button is pressed on the root window.")
     (license license:public-domain)))
 
+(define-public xinitrc-xsession
+  (let ((commit "cbfc77a1ccaf07b7d8a35f4d8007c7102f365374"))
+    (package
+      (name "xinitrc-xsession")
+      (version "1-3")
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://aur.archlinux.org/xinit-xsession.git")
+               (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32
+           "12nv3qyjhy2l9mcb547f414d8bj79mhdhsra0g8x7x71b1xxl15b"))))
+      (build-system copy-build-system)
+      (arguments
+       `(#:phases
+         (modify-phases %standard-phases
+           (add-after 'install 'patch-xsession-file
+             (lambda* (#:key outputs #:allow-other-keys)
+               (let* ((out (assoc-ref outputs "out"))
+                      (xinitrc-helper (string-append out "/bin/xinitrcsession-helper")))
+                 (substitute* (string-append out "/share/xsessions/xinitrc.desktop")
+                   (("Exec=xinitrcsession-helper")
+                    (string-append "Exec=" xinitrc-helper)))))))
+         #:install-plan
+         '(("xinitrcsession-helper" "bin/")
+           ("xinitrc.desktop" "share/xsessions/"))))
+      (home-page "https://aur.archlinux.org/packages/xinit-xsession/")
+      (synopsis "Use ~/.xinitrc as an xsession from your display manager")
+      (description
+       "Allows @code{~/.xinitrc} to be run as a session from your display manager.
+Use this package in your system configuration to make this xsession
+available.")
+      (license license:gpl3))))
+
 (define-public xmenu
   (package
     (name "xmenu")
-- 
2.34.1

[bug#52806] [PATCH v2] gnu: Add xinitrc-xsession.

[John Kehayias via Guix-patches via]

[-- Attachment #1: Type: text/plain, Size: 148 bytes --]

I forgot to note in the description that ~/.xinitrc needs to be executable for this xsession to run. Attached is the revised patch.

Thanks!
John

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-Add-xinitrc-xsession.patch --]
[-- Type: text/x-patch; name=0001-gnu-Add-xinitrc-xsession.patch, Size: 2979 bytes --]

From 5a974cce288973199d891223b3d9b84b2c683bb0 Mon Sep 17 00:00:00 2001
From: John Kehayias <john.kehayias@protonmail.com>
Date: Sun, 26 Dec 2021 11:43:26 -0500
Subject: [PATCH] gnu: Add xinitrc-xsession.

* gnu/packages/wm.scm (xinitrc-xsession): New variable.
---
 gnu/packages/wm.scm | 39 +++++++++++++++++++++++++++++++++++++++
 1 file changed, 39 insertions(+)

diff --git a/gnu/packages/wm.scm b/gnu/packages/wm.scm
index c6881154fe..39c447c07d 100644
--- a/gnu/packages/wm.scm
+++ b/gnu/packages/wm.scm
@@ -48,6 +48,7 @@
 ;;; Copyright © 2021 Petr Hodina <phodina@protonmail.com>
 ;;; Copyright © 2021 jgart <jgart@dismail.de>
 ;;; Copyright © 2021 Disseminate Dissent <disseminatedissent@protonmail.com>
+;;; Copyright © 2021 John Kehayias <john.kehayias@protonmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -71,6 +72,7 @@ (define-module (gnu packages wm)
   #:use-module (guix git-download)
   #:use-module (guix build-system asdf)
   #:use-module (guix build-system cmake)
+  #:use-module (guix build-system copy)
   #:use-module (guix build-system gnu)
   #:use-module (guix build-system haskell)
   #:use-module (guix build-system meson)
@@ -2317,6 +2319,43 @@ (define-public xclickroot
 button is pressed on the root window.")
     (license license:public-domain)))
 
+(define-public xinitrc-xsession
+  (let ((commit "cbfc77a1ccaf07b7d8a35f4d8007c7102f365374"))
+    (package
+      (name "xinitrc-xsession")
+      (version "1-3")
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://aur.archlinux.org/xinit-xsession.git")
+               (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32
+           "12nv3qyjhy2l9mcb547f414d8bj79mhdhsra0g8x7x71b1xxl15b"))))
+      (build-system copy-build-system)
+      (arguments
+       `(#:phases
+         (modify-phases %standard-phases
+           (add-after 'install 'patch-xsession-file
+             (lambda* (#:key outputs #:allow-other-keys)
+               (let* ((out (assoc-ref outputs "out"))
+                      (xinitrc-helper (string-append out "/bin/xinitrcsession-helper")))
+                 (substitute* (string-append out "/share/xsessions/xinitrc.desktop")
+                   (("Exec=xinitrcsession-helper")
+                    (string-append "Exec=" xinitrc-helper)))))))
+         #:install-plan
+         '(("xinitrcsession-helper" "bin/")
+           ("xinitrc.desktop" "share/xsessions/"))))
+      (home-page "https://aur.archlinux.org/packages/xinit-xsession/")
+      (synopsis "Use ~/.xinitrc as an xsession from your display manager")
+      (description
+       "Allows @code{~/.xinitrc} to be run as a session from your display manager.
+Make @code{~/.xinitrc} executable and use this package in your system
+configuration to use this xsession.")
+      (license license:gpl3))))
+
 (define-public xmenu
   (package
     (name "xmenu")
-- 
2.34.1

[bug#52806] [PATCH v3] gnu: Add xinitrc-xsession.

[John Kehayias via Guix-patches via]

[-- Attachment #1: Type: text/plain, Size: 212 bytes --]

Adjusted indentation and description per suggestions on another package (#52803). Did not see guix lint pick up that the description did not start with the package name, will have to investigate.

Thanks!
John

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-Add-xinitrc-xsession.patch --]
[-- Type: text/x-patch; name=0001-gnu-Add-xinitrc-xsession.patch, Size: 2984 bytes --]

From 45d2c27781bc2165b07147df1266a717f6143306 Mon Sep 17 00:00:00 2001
From: John Kehayias <john.kehayias@protonmail.com>
Date: Sun, 26 Dec 2021 11:43:26 -0500
Subject: [PATCH] gnu: Add xinitrc-xsession.

* gnu/packages/wm.scm (xinitrc-xsession): New variable.
---
 gnu/packages/wm.scm | 38 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 38 insertions(+)

diff --git a/gnu/packages/wm.scm b/gnu/packages/wm.scm
index c6881154fe..820b4bc6a5 100644
--- a/gnu/packages/wm.scm
+++ b/gnu/packages/wm.scm
@@ -48,6 +48,7 @@
 ;;; Copyright © 2021 Petr Hodina <phodina@protonmail.com>
 ;;; Copyright © 2021 jgart <jgart@dismail.de>
 ;;; Copyright © 2021 Disseminate Dissent <disseminatedissent@protonmail.com>
+;;; Copyright © 2021 John Kehayias <john.kehayias@protonmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -71,6 +72,7 @@ (define-module (gnu packages wm)
   #:use-module (guix git-download)
   #:use-module (guix build-system asdf)
   #:use-module (guix build-system cmake)
+  #:use-module (guix build-system copy)
   #:use-module (guix build-system gnu)
   #:use-module (guix build-system haskell)
   #:use-module (guix build-system meson)
@@ -2317,6 +2319,42 @@ (define-public xclickroot
 button is pressed on the root window.")
     (license license:public-domain)))
 
+(define-public xinitrc-xsession
+  (let ((commit "cbfc77a1ccaf07b7d8a35f4d8007c7102f365374"))
+    (package
+      (name "xinitrc-xsession")
+      (version "1-3")
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://aur.archlinux.org/xinit-xsession.git")
+               (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32 "12nv3qyjhy2l9mcb547f414d8bj79mhdhsra0g8x7x71b1xxl15b"))))
+      (build-system copy-build-system)
+      (arguments
+       `(#:phases
+         (modify-phases %standard-phases
+           (add-after 'install 'patch-xsession-file
+             (lambda* (#:key outputs #:allow-other-keys)
+               (let* ((out (assoc-ref outputs "out"))
+                      (xinitrc-helper (string-append out "/bin/xinitrcsession-helper")))
+                 (substitute* (string-append out "/share/xsessions/xinitrc.desktop")
+                   (("Exec=xinitrcsession-helper")
+                    (string-append "Exec=" xinitrc-helper)))))))
+         #:install-plan
+         '(("xinitrcsession-helper" "bin/")
+           ("xinitrc.desktop" "share/xsessions/"))))
+      (home-page "https://aur.archlinux.org/packages/xinit-xsession/")
+      (synopsis "Use ~/.xinitrc as an xsession from your display manager")
+      (description
+       "Xinitrc-xsession allows @code{~/.xinitrc} to be run as a session from your
+display manager.  Make @code{~/.xinitrc} executable and use this package in
+your system configuration to use this xsession.")
+      (license license:gpl3))))
+
 (define-public xmenu
   (package
     (name "xmenu")
-- 
2.34.1

[bug#52806] [PATCH v4] gnu: Add xinitrc-xsession.

[John Kehayias via Guix-patches via]

[-- Attachment #1: Type: text/plain, Size: 81 bytes --]

Updated this package after feedback via IRC, updated to use git-version and gexp.

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-Add-xinitrc-xsession.patch --]
[-- Type: text/x-patch; name=0001-gnu-Add-xinitrc-xsession.patch, Size: 3314 bytes --]

From 99cddf5130f9b5c95f268f09bce8b50e7951a7c3 Mon Sep 17 00:00:00 2001
From: John Kehayias <john.kehayias@protonmail.com>
Date: Sun, 26 Dec 2021 11:43:26 -0500
Subject: [PATCH] gnu: Add xinitrc-xsession.

* gnu/packages/wm.scm (xinitrc-xsession): New variable.
---
 gnu/packages/wm.scm | 44 ++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 44 insertions(+)

diff --git a/gnu/packages/wm.scm b/gnu/packages/wm.scm
index bf24dfa0d9..297244abcf 100644
--- a/gnu/packages/wm.scm
+++ b/gnu/packages/wm.scm
@@ -48,6 +48,7 @@
 ;;; Copyright © 2021 Petr Hodina <phodina@protonmail.com>
 ;;; Copyright © 2021 jgart <jgart@dismail.de>
 ;;; Copyright © 2021 Disseminate Dissent <disseminatedissent@protonmail.com>
+;;; Copyright © 2022 John Kehayias <john.kehayias@protonmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -68,9 +69,11 @@ (define-module (gnu packages wm)
   #:use-module ((guix licenses) #:prefix license:)
   #:use-module (guix packages)
   #:use-module (guix download)
+  #:use-module (guix gexp)
   #:use-module (guix git-download)
   #:use-module (guix build-system asdf)
   #:use-module (guix build-system cmake)
+  #:use-module (guix build-system copy)
   #:use-module (guix build-system gnu)
   #:use-module (guix build-system haskell)
   #:use-module (guix build-system meson)
@@ -2317,6 +2320,47 @@ (define-public xclickroot
 button is pressed on the root window.")
     (license license:public-domain)))
 
+(define-public xinitrc-xsession
+  (let ((commit "cbfc77a1ccaf07b7d8a35f4d8007c7102f365374")
+        (revision "0"))
+    (package
+      (name "xinitrc-xsession")
+      (version (git-version "1" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://aur.archlinux.org/xinit-xsession.git")
+               (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32 "12nv3qyjhy2l9mcb547f414d8bj79mhdhsra0g8x7x71b1xxl15b"))))
+      (build-system copy-build-system)
+      (arguments
+       (list
+        #:phases
+        #~(modify-phases %standard-phases
+            (add-after 'install 'patch-xsession-file
+              (lambda* (#:key outputs #:allow-other-keys)
+                (let* ((xinitrc-desktop
+                        (string-append #$output "/share/xsessions/xinitrc.desktop"))
+                       (xinitrc-helper
+                        (string-append #$output "/bin/xinitrcsession-helper")))
+                  (substitute* xinitrc-desktop
+                    (("Exec=xinitrcsession-helper")
+                     (string-append "Exec=" xinitrc-helper)))))))
+        #:install-plan
+        #~(list '("xinitrcsession-helper" "bin/")
+                '("xinitrc.desktop" "share/xsessions/"))))
+      (home-page "https://aur.archlinux.org/packages/xinit-xsession/")
+      (synopsis "Use ~/.xinitrc as an xsession from your display manager")
+      (description
+       "Xinitrc-xsession allows @code{~/.xinitrc} to be run as a session from your
+display manager.  Make @code{~/.xinitrc} executable and use this package in
+your system configuration have this xsession available to your display
+manager.")
+      (license license:gpl3))))
+
 (define-public xmenu
   (package
     (name "xmenu")
-- 
2.34.0

[bug#52806] [PATCH v4] gnu: Add xinitrc-xsession.

[Maxime Devos]

[-- Attachment #1: Type: text/plain, Size: 872 bytes --]

John Kehayias via Guix-patches via schreef op di 11-01-2022 om 21:29 [+0000]:
> +              (lambda* (#:key outputs #:allow-other-keys)
> +                (let* ((xinitrc-desktop
> +                        (string-append #$output
"/share/xsessions/xinitrc.desktop"))
> +                       (xinitrc-helper
> +                        (string-append #$output
"/bin/xinitrcsession-helper")))
> +                  (substitute* xinitrc-desktop
> +                    (("Exec=xinitrcsession-helper")
> +                     (string-append "Exec=" xinitrc-helper)))))))

'outputs' is unused here, so you can simplify the lambda from
(lambda * (#:key outputs #:allow-other-keys) ...)
to
(lambda _ ...).

Greetings,
Maxime

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]

[bug#52806] [PATCH v5] gnu: Add xinitrc-xsession.

[John Kehayias via Guix-patches via]

[-- Attachment #1: Type: text/plain, Size: 368 bytes --]

Hi Maxime,

‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐

On Tuesday, January 11th, 2022 at 5:24 PM, Maxime Devos wrote:

> 'outputs' is unused here, so you can simplify the lambda from
> (lambda * (#:key outputs #:allow-other-keys) ...)
> to
> (lambda _ ...).
>

Right, another thing that can be removed here with the gexp. Thanks!

John

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-Add-xinitrc-xsession.patch --]
[-- Type: text/x-patch; name=0001-gnu-Add-xinitrc-xsession.patch, Size: 3280 bytes --]

From b8344d2876e978d80bf56ba65993c4cf66246dad Mon Sep 17 00:00:00 2001
From: John Kehayias <john.kehayias@protonmail.com>
Date: Sun, 26 Dec 2021 11:43:26 -0500
Subject: [PATCH] gnu: Add xinitrc-xsession.

* gnu/packages/wm.scm (xinitrc-xsession): New variable.
---
 gnu/packages/wm.scm | 44 ++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 44 insertions(+)

diff --git a/gnu/packages/wm.scm b/gnu/packages/wm.scm
index bf24dfa0d9..72e2e37313 100644
--- a/gnu/packages/wm.scm
+++ b/gnu/packages/wm.scm
@@ -48,6 +48,7 @@
 ;;; Copyright © 2021 Petr Hodina <phodina@protonmail.com>
 ;;; Copyright © 2021 jgart <jgart@dismail.de>
 ;;; Copyright © 2021 Disseminate Dissent <disseminatedissent@protonmail.com>
+;;; Copyright © 2022 John Kehayias <john.kehayias@protonmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -68,9 +69,11 @@ (define-module (gnu packages wm)
   #:use-module ((guix licenses) #:prefix license:)
   #:use-module (guix packages)
   #:use-module (guix download)
+  #:use-module (guix gexp)
   #:use-module (guix git-download)
   #:use-module (guix build-system asdf)
   #:use-module (guix build-system cmake)
+  #:use-module (guix build-system copy)
   #:use-module (guix build-system gnu)
   #:use-module (guix build-system haskell)
   #:use-module (guix build-system meson)
@@ -2317,6 +2320,47 @@ (define-public xclickroot
 button is pressed on the root window.")
     (license license:public-domain)))
 
+(define-public xinitrc-xsession
+  (let ((commit "cbfc77a1ccaf07b7d8a35f4d8007c7102f365374")
+        (revision "0"))
+    (package
+      (name "xinitrc-xsession")
+      (version (git-version "1" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://aur.archlinux.org/xinit-xsession.git")
+               (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32 "12nv3qyjhy2l9mcb547f414d8bj79mhdhsra0g8x7x71b1xxl15b"))))
+      (build-system copy-build-system)
+      (arguments
+       (list
+        #:phases
+        #~(modify-phases %standard-phases
+            (add-after 'install 'patch-xsession-file
+              (lambda _
+                (let* ((xinitrc-desktop
+                        (string-append #$output "/share/xsessions/xinitrc.desktop"))
+                       (xinitrc-helper
+                        (string-append #$output "/bin/xinitrcsession-helper")))
+                  (substitute* xinitrc-desktop
+                    (("Exec=xinitrcsession-helper")
+                     (string-append "Exec=" xinitrc-helper)))))))
+        #:install-plan
+        #~(list '("xinitrcsession-helper" "bin/")
+                '("xinitrc.desktop" "share/xsessions/"))))
+      (home-page "https://aur.archlinux.org/packages/xinit-xsession/")
+      (synopsis "Use ~/.xinitrc as an xsession from your display manager")
+      (description
+       "Xinitrc-xsession allows @code{~/.xinitrc} to be run as a session from your
+display manager.  Make @code{~/.xinitrc} executable and use this package in
+your system configuration have this xsession available to your display
+manager.")
+      (license license:gpl3))))
+
 (define-public xmenu
   (package
     (name "xmenu")
-- 
2.34.0

[bug#52806] [PATCH v5] gnu: Add xinitrc-xsession.

[John Kehayias via Guix-patches via]

Hi Maxime,

Just wanted to see if you got a chance to see the updated patch I sent previously, where I made the change you suggested:

> ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
>
> On Tuesday, January 11th, 2022 at 5:24 PM, Maxime Devos wrote:
>
> > 'outputs' is unused here, so you can simplify the lambda from
> > (lambda * (#:key outputs #:allow-other-keys) ...)
> > to
> > (lambda _ ...).
>

Was there anything else I should take care of?

Thanks again for the suggestion!

John

[bug#52806] [PATCH v5] gnu: Add xinitrc-xsession.

[Maxime Devos]

[-- Attachment #1: Type: text/plain, Size: 764 bytes --]

user guix
usertag 52806 + reviewed-looks-good
thanks

John Kehayias schreef op do 27-01-2022 om 03:33 [+0000]:
> Hi Maxime,
> 
> Just wanted to see if you got a chance to see the updated patch I sent previously, where I made the change you suggested:
> 
> > ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
> > 
> > On Tuesday, January 11th, 2022 at 5:24 PM, Maxime Devos wrote:
> > 
> > > 'outputs' is unused here, so you can simplify the lambda from
> > > (lambda * (#:key outputs #:allow-other-keys) ...)
> > > to
> > > (lambda _ ...).
> > 
> 
> Was there anything else I should take care of?

IIRC, no, the v5 patch appears to be fine, though IIRC I didn't look at
the source code of xinitrc-xsession.

Greetings,
Maxime.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]

[bug#52806] [PATCH v5] gnu: Add xinitrc-xsession.

[John Kehayias via Guix-patches via]

Thanks Maxime!

------- Original Message -------

On Thursday, January 27th, 2022 at 10:56 AM, Maxime Devos wrote:

> user guix
> usertag 52806 + reviewed-looks-good
> thanks
>
> John Kehayias schreef op do 27-01-2022 om 03:33 [+0000]:
>
> > Was there anything else I should take care of?
>
> IIRC, no, the v5 patch appears to be fine, though IIRC I didn't look at
> the source code of xinitrc-xsession.
>

There is not much to the source, mostly it is an easy way to provide an xsession for your xinitrc. So the source is just a desktop file and helper script to execute a user's xinitrc. Basically making it convenient, through having this in your system configuration, to login through a display manager but with the more barebones (or controllable) xinit style. For example, I use this to set up my bare WM (xmonad) the same as I do when I don't run a display manager.

John

[bug#52806] [PATCH v5] gnu: Add xinitrc-xsession.

[Maxime Devos]

[-- Attachment #1: Type: text/plain, Size: 333 bytes --]

Maxime Devos schreef op do 27-01-2022 om 16:56 [+0100]:
> > [...]
> > Was there anything else I should take care of?
> 
> IIRC, no, the v5 patch appears to be fine, though IIRC I didn't look at
> the source code of xinitrc-xsession.
> 
> Greetings,
> Maxime.

Also, to be clear, I'm not a committer.

Greetings,
Maxime

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]

bug#52806: [PATCH v5] gnu: Add xinitrc-xsession.

[Liliana Marie Prikler]

Am Dienstag, dem 11.01.2022 um 22:34 +0000 schrieb John Kehayias:
> Hi Maxime,
> 
> ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
> 
> On Tuesday, January 11th, 2022 at 5:24 PM, Maxime Devos wrote:
> 
> > 'outputs' is unused here, so you can simplify the lambda from
> > (lambda * (#:key outputs #:allow-other-keys) ...)
> > to
> > (lambda _ ...).
> > 
> 
> Right, another thing that can be removed here with the gexp. Thanks!
> 
> John
Hi, I was told Maxime already reviewed this, so I pushed it.  Cheers!