From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id QnK9GBoH81/qbQAA0tVLHw (envelope-from ) for ; Mon, 04 Jan 2021 12:16:26 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id UNQXFBoH81/TcAAAB5/wlQ (envelope-from ) for ; Mon, 04 Jan 2021 12:16:26 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0DEEB94030E for ; Mon, 4 Jan 2021 12:16:24 +0000 (UTC) Received: from localhost ([::1]:43630 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kwOmd-0006ij-MW for larch@yhetil.org; Mon, 04 Jan 2021 07:16:23 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:43186) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kwOmI-0006iU-TQ for guix-patches@gnu.org; Mon, 04 Jan 2021 07:16:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:46493) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kwOmI-0005h3-Lc for guix-patches@gnu.org; Mon, 04 Jan 2021 07:16:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kwOmI-0008Sg-G4 for guix-patches@gnu.org; Mon, 04 Jan 2021 07:16:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#45573] [PATCH] Correct freecad runtime errors Resent-From: Ekaitz Zarraga Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 04 Jan 2021 12:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45573 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Leo Famulari Received: via spool by 45573-submit@debbugs.gnu.org id=B45573.160976254232491 (code B ref 45573); Mon, 04 Jan 2021 12:16:02 +0000 Received: (at 45573) by debbugs.gnu.org; 4 Jan 2021 12:15:42 +0000 Received: from localhost ([127.0.0.1]:58039 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kwOlx-0008Ry-Q5 for submit@debbugs.gnu.org; Mon, 04 Jan 2021 07:15:42 -0500 Received: from mail-40133.protonmail.ch ([185.70.40.133]:32857) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kwOlt-0008Rj-L0 for 45573@debbugs.gnu.org; Mon, 04 Jan 2021 07:15:40 -0500 Date: Mon, 04 Jan 2021 12:15:26 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=elenq.tech; s=protonmail2; t=1609762530; bh=z5n4Iilnr6hj5q7wpHjr1P6N767LIXOCWQYL2OULniE=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=Obgh3WxId8rC53stP8z/8Lzk87B7JolDl6lyzP73xFJI4Bpf5NNRzKgLCHYRcz96Q kUifCdOYbqpgIT7JHk3JevTYw4+Du24IWKywQmrx/zAw2qQPNt8k4GfJAtrvCosjyV iV4Lu46s1j8/qpfNZlzottUpO5zMcapzJFzfal62l6wxns8u2/khK9CkSU3F889t2t zFTnRN6fgpBvyLh8UJuz4Od+1Ulqvp+fqmsizyygDcxMrnUS5M7wqdQUrj7qcGwsYB CGVWTbx9fwVmYkxDQVH7wslDQmJtW4TqDf07aSr0ZcP9X9C3faKx1S4M6pjkJK4JdI tI7wcPCQWeY5w== From: Ekaitz Zarraga Message-ID: In-Reply-To: References: <6b2IbqX7a-q86Pjb_nOtz_XcCOrATSHf2T7vfIU5qrXWhYtQFsoex3XlfmDVhLt8UXjnOonMiLCS-1oKUzxXpp8x3HSUjNkzUjhUsKGc3Iw=@elenq.tech> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Ekaitz Zarraga Cc: "45573@debbugs.gnu.org" <45573@debbugs.gnu.org> Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -1.23 Authentication-Results: aspmx1.migadu.com; dkim=fail (headers rsa verify failed) header.d=elenq.tech header.s=protonmail2 header.b=Obgh3WxI; dmarc=fail reason="SPF not aligned (relaxed)" header.from=elenq.tech (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 0DEEB94030E X-Spam-Score: -1.23 X-Migadu-Scanner: scn1.migadu.com X-TUID: scPe+OUpQLeB Hi, =E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90 Original Me= ssage =E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90 On Monday, January 4, 2021 1:18 AM, Leo Famulari wrote: > On Fri, Jan 01, 2021 at 02:37:39PM +0000, Ekaitz Zarraga wrote: > > > Subject: [PATCH 3/6] gnu: Add python-pivy. > > > > * gnu/packages/python-xyz.scm (python-pivy): New variable. > > > > > - `(#:tests? #f ; Tests are broken > > > > > > Can you clarify what you mean, and the overall situation with the tests? > Are they actually used upstream? I think they are broken upstream. When they are run during the guix compilation they report a circular dependency issue when loading but once the lib is installed i'm able to import it without issues. > > > - #:phases > > > > > > - (modify-phases %standard-phases > > > > > > - (add-after 'unpack 'patch-cmake-include-dirs > > > > > > - (lambda _ > > > > > > - ;; Patch buildsystem to respect Coin3D include director= y > > > > > > - (substitute* "CMakeLists.txt" > > > > > > - (("\\\\$\\\\{SoQt_INCLUDE_DIRS}") > > > > > > - "${Coin_INCLUDE_DIR};${SoQt_INCLUDE_DIRS}= ")) > > > > > > This can probably be fixed with #:configure-flags. I can look into this > before pushing. I tried that and I was unable to solve it that way. I'm not a CMake expert but I think the problem is that even if CMake finds Coin3D, it's not taking it in account during the compilation, so it needs that patch to use it. > > > Subject: [PATCH 4/6] gnu: FreeCad: Update to 0.18.5-1.7616153. > > Fixes Draft module import errors > > > > * gnu/packages/engineering.scm (freecad): Update to 0.18.5-1.761615= 3. > > [inputs]: Add python-pivy. > > > > > Subject: [PATCH 5/6] gnu: freecad: move python-pyside-2-tools to native= -inputs > > > > * gnu/packages/engineering.scm (freecad): > > [inputs]: Remove python-pyside-2-tools. > > [native-inputs]: Add python-pyside-2-tools. > > > > The re-indentation of the package in patch 4/6 is not complete, and I > will squash these two patches before pushing. I have this "ready to go" > in my Git tree. > > > Subject: [PATCH 6/6] gnu: freecad: Add qtwebkit input. > > > > * gnu/packages/engineering.scm (freecad): > > [inputs]: Add qtwebkit. > > > > > - ;; qtwebkit is optional. We remove it currently, because it t= akes > > > > > > - ;; much time to compile and substitutes are often unavailable > > > > > > - ;;("qtwebkit" ,qtwebkit) > > > > > > > > - ("qtwebkit" ,qtwebkit) > > > > > > The comment is still true... I recommend adding a note in the commit > message saying what the new dependency enables. I'm not sure if the comment is true. I'd like to discuss it, but you can safely discard this change. The only part that is affected by qtwebkit is the first screen of the program that shows some examples, links and news. So it's safe to remove but I'm not sure if the substitutes were unavailable because of this or because the compilation was failing (it have been broken for a long time). I'm not sure about how to proceed here. I'm ok with a FreeCad that is open in a blank screen and shows a couple of warnings on load. I'll leave the decision of including this patch or not on you guys if you don't mind. Thank you for your time, Ekaitz