From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:8:6d80::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id MhdrFRWOX2BW/QAAgWs5BA (envelope-from ) for ; Sat, 27 Mar 2021 20:57:09 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id SGo/DhWOX2AhQQAA1q6Kng (envelope-from ) for ; Sat, 27 Mar 2021 19:57:09 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 8BAD52B8DD for ; Sat, 27 Mar 2021 20:57:08 +0100 (CET) Received: from localhost ([::1]:49324 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lQF3T-0000MB-9U for larch@yhetil.org; Sat, 27 Mar 2021 15:57:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33726) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lQF3O-0000La-Dj for guix-patches@gnu.org; Sat, 27 Mar 2021 15:57:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:33447) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lQF3O-0001sv-5x for guix-patches@gnu.org; Sat, 27 Mar 2021 15:57:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lQF3O-0005YD-3K for guix-patches@gnu.org; Sat, 27 Mar 2021 15:57:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#47434] [PATCH] Added Go 1.16.2 Resent-From: Maxime Devos Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 27 Mar 2021 19:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47434 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: =?UTF-8?Q?N=C3=A9fix?= Estrada , 47434@debbugs.gnu.org Received: via spool by 47434-submit@debbugs.gnu.org id=B47434.161687500921316 (code B ref 47434); Sat, 27 Mar 2021 19:57:02 +0000 Received: (at 47434) by debbugs.gnu.org; 27 Mar 2021 19:56:49 +0000 Received: from localhost ([127.0.0.1]:44993 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lQF3A-0005Xk-ON for submit@debbugs.gnu.org; Sat, 27 Mar 2021 15:56:49 -0400 Received: from albert.telenet-ops.be ([195.130.137.90]:43674) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lQF38-0005Xb-Jd for 47434@debbugs.gnu.org; Sat, 27 Mar 2021 15:56:47 -0400 Received: from ptr-bvsjgyjmffd7q9timvx.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:aaf1:9810:a0b8:a55d]) by albert.telenet-ops.be with bizsmtp id lXwk240070mfAB406XwkRZ; Sat, 27 Mar 2021 20:56:44 +0100 Message-ID: From: Maxime Devos Date: Sat, 27 Mar 2021 20:56:06 +0100 In-Reply-To: <20210327162953.32278-1-nefixestrada@gmail.com> References: <20210327162953.32278-1-nefixestrada@gmail.com> Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-OgCPHJ+Y7OCky1/8riFL" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r21; t=1616875004; bh=sRiNfx78x4vfvhZQOduaxOvXio4XcY2irIuveXVwNew=; h=Subject:From:To:Date:In-Reply-To:References; b=qEBuCWlK0/a+/f/GhuVJ8RLPyg7xmLST50Lg75iryx0no9v7rA0cguaLqd1M+/Dxx 0vjGgFKfAxi5w0YmZv0ni8Uvr/3pEdkMGPJrahQbE65+vBEHJgzsZiOA+enfYxmmY2 xc+7c9EEOH+W9EyAhLVDCZrLpIEmXCoFjRIaXuSlY22t0WMg1Rs/YYDWC9iCjQ9oWL lHx96jLbICVVu15kpYO4ps6MddGForV5OUW8JEtsqdrrlIzW+bLE3S9GFYvo96z50x ZupSVGmNmEIkL5lqojYLDFV7X/JBvEJ2Giv6pZkqEtcPGxJU0crhokOqzy/+DkAPEf gQs8cz4LrD9UA== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1616875029; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=sRiNfx78x4vfvhZQOduaxOvXio4XcY2irIuveXVwNew=; b=InZUjZHEqCKV9izRCXWMDJEckUfUpjp7sy/jO9IWPRwHPAprzewDxZscRgIEjPEXLwO34e 8+udMYNb3W1scZNjMvgQ/EfYPTBs2g3u1qRQecew6LnyLR0QiDwmBpFnPm7vjk6+0u+zIl Vphf5Y4B/KrbvVAcxuFlUTSNPU9LDB1bI9FUqqdhY1tpniwB/eP6MryFPdxLYpVPNgMtF9 utsuU2QVAA3UX7J/XEknlqvkLW6NNRi58VECS77j/ZP3pfmaKBYty5YhyyMCPHqWZlGCc2 KrC9SV1vXf/5EywSN8YdKiOwtdGNrIrT33Dk3NC+wU/wsR7Sbwc7FBUan01sRg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1616875029; a=rsa-sha256; cv=none; b=SoLFE7ZfO/ogaPs5elGsoZAcjqLhRsNpjUbP+ChA76Ha6UKw789SqrHBgrnCkBMw9bbXa2 NGzMjePx7NkpV2U/f6+ZJFBR3BZIju8ZdJ8rZIJdGJfNZR6pPSl05Cer6Ti3wLHXvECk45 iGq1NWeqOznla0uhomu4R/82qhc47BvKTEuocZdnYPMWjKzTyO0bGoVMlMqrxtjueVrA7B /+Bt8bp4KZ2deo/25IN07HiNyUmmF48D9WLX75deWfrfcpIHUwWSGrqtC/Uo/rC042SfkS CAIfoH37JQ8mw6FcQkYZWrSeHo5hyH3HNcmLj9JUgyXchvWR32/gt2Ak2iIEGQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r21 header.b=qEBuCWlK; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -3.42 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r21 header.b=qEBuCWlK; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 8BAD52B8DD X-Spam-Score: -3.42 X-Migadu-Scanner: scn0.migadu.com X-TUID: YI24YXRoR8k5 --=-OgCPHJ+Y7OCky1/8riFL Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sat, 2021-03-27 at 17:29 +0100, N=C3=A9fix Estrada wrote: > Signed-off-by: N=C3=A9fix Estrada > --- > gnu/packages/golang.scm | 27 +++++++++++++++++++++++++++ > 1 file changed, 27 insertions(+) A commit message is missing, see =E2=80=9816.6 Submitting Patches=E2=80=99 = in the manual (and there are plenty of examples in "git log"). There have been a few patches lately by new contributers without commit messages; is this section of the manual hard to find? Is there some location where we could prominently feature a link to the section? Also, =E2=80=98we=E2=80=99 don't use =E2=80=98Signed-off-by=E2=80=99 like t= hat. From =E2=80=9816.8 Commit Access=E2=80=99: When pushing a commit on behalf of somebody else, please add a =E2=80=98Signed-off-by=E2=80=99 line at the end of the commit log message= =E2=80=94e.g., with =E2=80=98git am --signoff=E2=80=99. This improves tracking of who did what= . Thus, it is up to committers to add a line like that. Perhaps a system like the Linux kernel project uses could be useful in the future, but I don't think =E2=80=98we=E2=80=99 are at that point yet > diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm > index d9988cd7ad..df17955c93 100644 > --- a/gnu/packages/golang.scm > +++ b/gnu/packages/golang.scm > @@ -25,6 +25,7 @@ > ;;; Copyright =C2=A9 2020 Martin Becze > ;;; Copyright =C2=A9 2021 Ricardo Wurmus > ;;; Copyright =C2=A9 2021 Guillaume Le Vaillant > +;;; Copyright =C2=A9 2021 N=C3=A9fix Estrada > ;;; > ;;; This file is part of GNU Guix. > ;;; > @@ -440,6 +441,32 @@ in the style of communicating sequential processes (= @dfn{CSP}).") > ,@(package-native-inputs go-1.4))) > (supported-systems %supported-systems))) > =20 > +(define-public go-1.16 > + (package > + (inherit go-1.14) > + [...] > + (arguments > + (substitute-keyword-arguments (package-arguments go-1.14) > + ((#:phases phases) > + `(modify-phases ,phases This part looks good to me. > + (add-after 'prebuild 'prebuild-1-16 > + (lambda* (#:key inputs #:allow-other-keys) > + (let* ((gcclib (string-append (assoc-ref inputs "gcc:lib") "/lib= "))) > + (substitute* "cmd/go/testdata/script/link_syso_issue33139.txt" > + (("\\[\\!cgo\\] skip") > + "[!exec:cc] skip"))))))))))) > + What's this 'prebuild-1-16' phase for? Please add a comment explaining! And what's (let* ((gcclib ...) ...) doing there if gcclib isn't used afterw= ards? > (define-public go go-1.14) Something to consider for people who know the go situation in guix: could this be replaced with (define-public go go-1.16) after this patch? (And go-1.14 deleted as there are no uses of it anymore.) The output of "guix refresh --list-dependent go" is: Building the following 125 packages would ensure 440 dependent packages are= rebuilt: [...] so this shouldn't cause a world-rebuild (note go packages are (reportedly) cheap to build). But perhaps there are API incompatibilities between 1.16 = and 1.14? idk. Note: this patch should be reviewed by someone more knowledged about go in guix than me. Thanks for looking into this, Greetings, Maxime --=-OgCPHJ+Y7OCky1/8riFL Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYIADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYF+N1xccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7g+wAQDIuumSyfD/ULQ6MOVcveXlQVhm dfdAg9AWgUPK6DMA7QD/dAWawD4s1WIrRlbWUv7OI0SMaSR4qdI7KJoMcTQbIww= =k3hI -----END PGP SIGNATURE----- --=-OgCPHJ+Y7OCky1/8riFL--