From: jgart via Guix-patches via <guix-patches@gnu.org>
To: "Maxime Devos" <maximedevos@telenet.be>, 47815@debbugs.gnu.org
Cc: "Bonface Munyoki K." <me@bonfacemunyoki.com>,
Efraim Flashner <efraim@flashner.co.il>,
"Bonface M. K." <bonfacemunyoki@gmail.com>
Subject: [bug#47815] [PATCH 1/3] gnu: music: python-abjad: Abjad Improvements.
Date: Sat, 17 Apr 2021 16:10:25 +0000 [thread overview]
Message-ID: <cf068a797061090cb9d1422e4e3b0363@dismail.de> (raw)
In-Reply-To: <9d82233085aadf8a622f2956e5fc8c51a134c7ca.camel@telenet.be>
Hi Maxime,
I tried your suggestion but it fails with the following exception:
Backtrace:
...
In guix/build-system/python.scm:
162:0 3 (python-build _ _ _ #:tests? _ #:test-target _ # _ # _ # …)
In ice-9/boot-9.scm:
1669:16 2 (raise-exception _ #:continuable? _)
1669:16 1 (raise-exception _ #:continuable? _)
1669:16 0 (raise-exception _ #:continuable? _)
ice-9/boot-9.scm:1669:16: In procedure raise-exception:
Unrecognized keyword: #:disallowed-references
It looks like python-build-system might not support #:disallowed-references.
Is that correct?
all the best,
jgart
ps
I did a quick search for it with ripgrep and it seems like only gnu, meson, and glib-or-gtk support it currently:
rg "\#:disallowed-references" -t lisp | rg build-system
guix/build-system/meson.scm: #:disallowed-references
guix/build-system/gnu.scm: #:disallowed-references
guix/build-system/gnu.scm: #:disallowed-references
guix/build-system/glib-or-gtk.scm: #:disallowed-references
April 17, 2021 5:12 AM, "Maxime Devos" <maximedevos@telenet.be> wrote:
> jgart schreef op vr 16-04-2021 om 17:59 [+0000]:
>
>> Hi Maxime,
>>
>> Thank you for the review! I attached a new patch set.
>>
>> I reverted to Bonface's original idea of having lilypond only as a native input
>> in the package definition.
>
> If you do that, make sure "abjad" does not retain a reference to lilypond,
> as otherwise when cross-compiling, "abjad" will use a lilypond built for the
> incorrect architecture. You can use #:disallowed-references ,lilypond for this.
>
> (TODO: there should be a #:disallowed-refences/native variant. But
> #:disallowed-references will suffice for now.)
>
> I'm currently occupied with some other things, so I can't review your revised
> patches yet.
>
> Greetings,
> Maxime.
next prev parent reply other threads:[~2021-04-17 16:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <7988a3c09cc5efb9265b28483f036b1508514f67.camel@telenet.be>
2021-04-16 4:57 ` [bug#47815] [PATCH 1/3] gnu: music: python-abjad: Abjad Improvements jgart via Guix-patches via
2021-04-16 10:12 ` Maxime Devos
2021-04-16 17:59 ` jgart via Guix-patches via
2021-04-17 9:12 ` Maxime Devos
2021-04-17 16:10 ` jgart via Guix-patches via [this message]
2021-07-22 8:53 ` bug#47815: " Efraim Flashner
2021-04-17 16:19 ` [bug#47815] Fwd: Re: [bug#47815] " Maxime Devos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cf068a797061090cb9d1422e4e3b0363@dismail.de \
--to=guix-patches@gnu.org \
--cc=47815@debbugs.gnu.org \
--cc=bonfacemunyoki@gmail.com \
--cc=efraim@flashner.co.il \
--cc=jgart@dismail.de \
--cc=maximedevos@telenet.be \
--cc=me@bonfacemunyoki.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).