From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id OCcwNGpgxmIRxQAAbAwnHQ (envelope-from ) for ; Thu, 07 Jul 2022 06:26:18 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id QI0DNGpgxmL1kAAAauVa8A (envelope-from ) for ; Thu, 07 Jul 2022 06:26:18 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 55C8C7B69 for ; Thu, 7 Jul 2022 06:26:18 +0200 (CEST) Received: from localhost ([::1]:35890 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o9J5l-0003es-Eq for larch@yhetil.org; Thu, 07 Jul 2022 00:26:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39840) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o9J5X-0003ej-PT for guix-patches@gnu.org; Thu, 07 Jul 2022 00:26:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:33335) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o9J5V-0004ur-UM for guix-patches@gnu.org; Thu, 07 Jul 2022 00:26:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o9J5V-0003GN-Of for guix-patches@gnu.org; Thu, 07 Jul 2022 00:26:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#56046] [PATCH] services: mail: add opensmtpd records to enhance opensmtpd-configuration. Version 2 Resent-From: Liliana Marie Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 07 Jul 2022 04:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56046 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: jbranso@dismail.de, 56046@debbugs.gnu.org Received: via spool by 56046-submit@debbugs.gnu.org id=B56046.165716794712519 (code B ref 56046); Thu, 07 Jul 2022 04:26:01 +0000 Received: (at 56046) by debbugs.gnu.org; 7 Jul 2022 04:25:47 +0000 Received: from localhost ([127.0.0.1]:55465 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o9J5F-0003Fp-CY for submit@debbugs.gnu.org; Thu, 07 Jul 2022 00:25:47 -0400 Received: from mail-ej1-f68.google.com ([209.85.218.68]:41598) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o9J5A-0003FY-Kd for 56046@debbugs.gnu.org; Thu, 07 Jul 2022 00:25:44 -0400 Received: by mail-ej1-f68.google.com with SMTP id u12so30289872eja.8 for <56046@debbugs.gnu.org>; Wed, 06 Jul 2022 21:25:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:subject:from:to:date:in-reply-to:references:user-agent :mime-version:content-transfer-encoding; bh=mER72DH/rkHh76cSAamAG9HOQPGoN8SNKo3lzZdOLg4=; b=pdY8Ab7igE4LZnoFwKg2/TdzV5uMXtDe9ZrCgIp6t1COzTqhXriE6MTpNR251yOWWs UscPm2nQsNqgvCsFrnlSUogF440rGq21APas+0IayBSv5SfpQ6y1lwH+K3ezKUPq1JAb ueKenYwqlRBBEYl7lWzsq7L26dUQduRHQx8Tv42gmVv/FVbVRTYGIPJCmcq+y5BK6pkz 8dF9i1IPSZrLTrPHyo3Tcw6umMGLuKkKK/wqPuldQJ8HvgAmRvXGtT7rle+hupjsMhiT +wP1oKXqchCgEWxVjpOTpd/LIbMJQM2EYtLpCFrnLjJ2NsWkh/TLxNuU5S02T/28CkwF eL7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=mER72DH/rkHh76cSAamAG9HOQPGoN8SNKo3lzZdOLg4=; b=Fhs1HRPIeX+bs2rtYUrIPf8JnVgB7gQZX7UeZoEFdQn8vhxVzPIcal/GkDp5na9ash sNKkpIgjWOTtVYSD1J/2jIuprdesBRrHQ67BJ6Hml6giu9/YZiQd0pP7N/r4dyZEjaeS 2NCvUXs5ypTEepPB8NYniSEKHTzDVC4v/FMUo69NL03I+lh4yMiySgReefk9hkTax8EP 3ouvfBf/WOhPvj0c2F26amZNOPs82YALkwWIZOYrPmcvudFHvEd3aFA+HBGZ/5ehl1qQ pgePw50TfkCB6P+eGYPWDrFzZdu80Jn4dgvUWfZVySh2LWDC1uPXZ6pbHw651IrBIbEF 6GJA== X-Gm-Message-State: AJIora/Hg1V3wkbige057gS9ExpwMw6xgtnoxsvH9wKHpBTdSSEcfKAF r/Jzwy0pVGctA6s2BtWusy8= X-Google-Smtp-Source: AGRyM1ukYaPxrduJXVUPMT0Eo16mVSf1Br8n/pHqkPJHsn1o2U82i9YlGDLpGnrf/3cejpAY425dKw== X-Received: by 2002:a17:907:1693:b0:726:4322:c330 with SMTP id hc19-20020a170907169300b007264322c330mr43209664ejc.9.1657167934559; Wed, 06 Jul 2022 21:25:34 -0700 (PDT) Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id jp1-20020a170906f74100b006fe0abb00f0sm18184620ejb.209.2022.07.06.21.25.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Jul 2022 21:25:34 -0700 (PDT) Message-ID: From: Liliana Marie Prikler Date: Thu, 07 Jul 2022 06:25:32 +0200 In-Reply-To: <6a272ff438ca4e2efc8e196c9160f857@dismail.de> References: <756a905107d7783bab238091d668fddbc1e712ab.camel@gmail.com> <20220704211759.8314-1-jbranso@dismail.de> <6a272ff438ca4e2efc8e196c9160f857@dismail.de> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1657167978; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=mER72DH/rkHh76cSAamAG9HOQPGoN8SNKo3lzZdOLg4=; b=OuriqBtxY2wjVTvzOdsapmrfMZ/C3nsWDklwYtdAaqbvVs3vaf4nDCznQ+rH5gQntqHciZ oOjgmcLyFTaUTVFM88pPqiUMCG1gE6XXW1TyxthluVYuRtthVn9/liETQUhfTvnJZ/8DPP JcZGx6qHxT2ykQQHFLrXcN15ERZWJwbcUnHMO4MYCkJQQrR83lKK20VV1kVJPOv2GXnbbS WWgJ+z1sreAlhpC+cJUOpA7uqwYCXZQVw9G3/NzK8Fx/xIkV1e+rf5IRoMjzXDj/btRx74 EkP1Dq4nNH6SDiAE4HbXBTrB+b0n76qTF3KGbnQzT/ELmUdm970/h3nSYeN1CQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1657167978; a=rsa-sha256; cv=none; b=LMEbOzsuHUNm/CuXqpOJDoABZ7A0apVLkPHTGf4VKN/n3MqswAIsDJi2r8cyowNLdXLO1p r5orYt728q+5MUrUJWM5eQ2u2CaGRakMukCx6rNGLsOoj/5nSVSjwjxnvGY9Nz2FZKAuLL vYTJjunmw8zLuMcHqYvM1IGM0cjq3akOnmCpMbRxDV2WGBDyryTkZxF6erHZISupbuyOqe GbwHWqwXMrh2llTIvBiUY5WLaCeNrKMJMLFhMUgvv9wnKDLV5teblIXWS2bhSf4/fwVTzA ohGu5ii0eAqlGmNbiR+eBchUvg7DMuWhzRW/D1ElyHIfdUpl5xFJ43JxwG9koA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=pdY8Ab7i; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 6.06 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=pdY8Ab7i; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 55C8C7B69 X-Spam-Score: 6.06 X-Migadu-Scanner: scn1.migadu.com X-TUID: 94qdTd6tnpkq Am Mittwoch, dem 06.07.2022 um 21:51 +0000 schrieb jbranso@dismail.de: > I do not believe that guile has a file-exists? thunk.  > I could use (access? file F_OK) every time, but I think > file-exists? is easier to use.  My two cents. scheme@(guile-user)> file-exists? $1 = # > > > What is a "listen-on"? > > "listen-on" refers to the "listen on" in smtpd.conf: > https://man.openbsd.org/smtpd.conf > > lan_addr = "192.168.0.1" > listen on $lan_addr > listen on $lan_addr tls auth Okay, but what would you call that? An address maybe? > > > +(define-record-type* > > configuration> > > > > Again, could this just be ? > > I would prefer to have two data types for "listen on" and > "listen on socket".  "listen on socket" only supports 3 options, > where "listen on" supports 19. I am not questioning whether it makes sense to add a configuration record – it probably does – but whether you're using the best name for that record. We are not Java programmers here, a little abstraction goes a long way. > From the documentation: > > listen on interface [family] [options] >     Listen on the interface for incoming connections, using the same > syntax as ifconfig(8). The interface parameter may also be an > interface group, an IP address, or a domain name. Listening can > optionally be restricted to a specific address family, which can be > either inet4 or inet6. > > listen on socket [options] >     Listen for incoming SMTP connections on the Unix domain socket > /var/run/smtpd.sock. This is done by default, even if the directive > is absent. So you can either have an opensmtp-interface (with family and a bunch of options) or an opensmtp-socket (with a bunch of options). Sounds like a much nicer ontology, doesn't it? > > > [...] > > > > Too much to check, too little time. Maybe return later. > > To summarize the tasks that you have given me are: > > 1) Write a proper changelog. > 2) define "string-in-list?" with member? >    Are there other procedures that could use this? > 3) replace [] with () > 4) Shorten the sanitize procedure for opensmtpd-option-configuration 5) Review your class names. I also don't think it makes too much sense to add -configuration for anything but the top-level configuration record, it just requires you to type much more configuration than you probably want. Cheers