From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id mFirNmsBmGE2aQEAgWs5BA (envelope-from ) for ; Fri, 19 Nov 2021 20:56:27 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id 2L86MmsBmGEmbAAAbx9fmQ (envelope-from ) for ; Fri, 19 Nov 2021 19:56:27 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 87004C1A2 for ; Fri, 19 Nov 2021 20:56:27 +0100 (CET) Received: from localhost ([::1]:46564 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mo9zm-0002My-MJ for larch@yhetil.org; Fri, 19 Nov 2021 14:56:26 -0500 Received: from eggs.gnu.org ([209.51.188.92]:38976) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mo9zQ-0001kN-0J for guix-patches@gnu.org; Fri, 19 Nov 2021 14:56:04 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:57272) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mo9zN-0003X2-Uk for guix-patches@gnu.org; Fri, 19 Nov 2021 14:56:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mo9zN-0005Ou-Lq for guix-patches@gnu.org; Fri, 19 Nov 2021 14:56:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#51967] [PATCH] package: calendar: Add gsimplecal to Guix Resent-From: Liliana Marie Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 19 Nov 2021 19:56:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51967 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Jaft , 51967@debbugs.gnu.org Received: via spool by 51967-submit@debbugs.gnu.org id=B51967.163735175020732 (code B ref 51967); Fri, 19 Nov 2021 19:56:01 +0000 Received: (at 51967) by debbugs.gnu.org; 19 Nov 2021 19:55:50 +0000 Received: from localhost ([127.0.0.1]:40585 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mo9zC-0005OJ-3L for submit@debbugs.gnu.org; Fri, 19 Nov 2021 14:55:50 -0500 Received: from mail-wm1-f68.google.com ([209.85.128.68]:39557) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mo9z9-0005O3-A5 for 51967@debbugs.gnu.org; Fri, 19 Nov 2021 14:55:48 -0500 Received: by mail-wm1-f68.google.com with SMTP id n33-20020a05600c502100b0032fb900951eso11320013wmr.4 for <51967@debbugs.gnu.org>; Fri, 19 Nov 2021 11:55:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:subject:from:to:date:in-reply-to:references:user-agent :mime-version:content-transfer-encoding; bh=caMqwKCXwA9DVPnS4AnL90q+a4u/NBVkREKU35KwQKg=; b=impXpldNroEel1LZlB97qBRaG4O8MOBZGZrFt/mJILfJQEtl5c5+7dQvGZ+rW3MMCV qE8HWX8qfMfKIEpj59uE1gFGOX9OUO46SiAA7k2yCraV37f3sJWZAQ7DbPtpDTftj2et V+VZPlrMq2MfQlvjkmE0QsMSg4dsDDmjr/FJtuYD1AMyoxcFCAYjWdrw3doBXNILRQmK qOmAvHGcm2UrWDMPocjfawrGYRwtmifO9cGq+h0I8MGCbr7BMTU9cYpls5Ry6heZJya2 wOX8EV37FKdwizRocTjz6a2tHD5ryBcoy82dfj+majnH4GGSNUPMov2G20xea3PgynjC jduw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=caMqwKCXwA9DVPnS4AnL90q+a4u/NBVkREKU35KwQKg=; b=5BXPcWGkuDhJBGbUn9lcOaudPq9ccUw+Clrpy46OHxd1oZuIRZ4H5M8Y3KynfZrKz5 4qwr+1pPH63a/dZEUz+DB/u5JZb2iVVBAI85QYSh3/MBYWsxnNFYSsc2Uz2D+kKa8OtF 4ir9UBBgdO2LSHky4hWP46p4yqHhekd06aIZtmlqsOIu35yxk4bvZ4RfpSQyfJD2BQIR 02Shnp1N6nK0mhOHO0+D28qu6Oxov1GoiSWCpkinFfLwZyMhKv63a/VOHQoQjVfn5NYx iomLKZs1CRtYLsZWbgARGPBXxwvvReC0lGhH9hEXQazbD8vhNQedBAcADQVjVALNJ/Jm spTA== X-Gm-Message-State: AOAM532hOxqoTezUzPum3lsyoBALAKtYZeR4bkAeJX1HBmPQoBSyryuI WFP98pWJg5Yi8RS1pilub6E= X-Google-Smtp-Source: ABdhPJw7DgacpS/hjQiTuOMmFxArn6aUOG04YsrdHdlpCOoKLtirD8Q43d6vSlLNW6kNuo2YbR1b0w== X-Received: by 2002:a05:600c:3c9b:: with SMTP id bg27mr2634033wmb.163.1637351741209; Fri, 19 Nov 2021 11:55:41 -0800 (PST) Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id i15sm15634438wmq.18.2021.11.19.11.55.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Nov 2021 11:55:40 -0800 (PST) Message-ID: From: Liliana Marie Prikler Date: Fri, 19 Nov 2021 20:55:39 +0100 In-Reply-To: References: <1945540023.3429539.1637311683282.ref@mail.yahoo.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1637351787; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=caMqwKCXwA9DVPnS4AnL90q+a4u/NBVkREKU35KwQKg=; b=Yj2371JfiQIKR0rhcOXch6Uhnlbz+EZDHKnPtxqrMSQjG+rXhMhx0TAK7zvdA2i5DON5MI vaEu0xDKGQcCGEF92xgrd29EFIUbm2D4g7f9MLcGo2MUcl9ok0nwmqupGzLluckda0+WbL kP9EDLLf2MU5hwPtWHO5RUB+GcXI2aHm946lpb2DFdcSBZignbUziW0vxbzIdrUdV9/8VS lksip4NhoEebNKwe3136QNsVVOKtdmmrgFH/lj03dSXADgit479cd+SkluLP96RFEDAACS Q9On0k2PGFmBE1CxcMipY5PbkzjjflVENJHPZ7i4kGO3258fE4Ww7zDVjJKImA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1637351787; a=rsa-sha256; cv=none; b=pLLVtJO9VxamRIa8z/8a5HUXbHx4oXXuiAxJaRm8DUy2Z+7BKFLPpzxUd5BQ4p1Asqv6o1 Zu8fF2lRc2woYW79Zl1VqO+8EubjHHXcHEu+oUsi+eJnPyou1uykSD1QzUSpQQspem5YgD TbTo6DOGo7knr7Jl6Go9TZV6ViK7zcNA++98lvuGfkESKlVvymruPEdxveVQH8ZboUP4kg d3qBJfZ3kBXeFOQLyzyu5RnIRgCutcrDBru5ME8axs53wIHltdqDTYJUmAVBuVcjDs4Pqx g7c9BcQMO7gfKghtd94dwgyE0l+Is9xOm5/PO16LC4obQKhFUXOZ+q4+puiQ4A== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=impXpldN; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -1.87 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=impXpldN; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 87004C1A2 X-Spam-Score: -1.87 X-Migadu-Scanner: scn0.migadu.com X-TUID: E7+g8ZxYNPaD Hi, Am Freitag, den 19.11.2021, 08:48 +0000 schrieb Jaft: > Hello; this is my first patch so, if I've missed or forgotten > anything, just let me know and I'm happy to get it fixed. First things first: transmit plain text, not HTML. Second, only the topmost directory (gnu:, guix:, doc:) is usually important. Package additions follow the rule "gnu: Add PACKAGE". > * gnu/packages/calendar.scm (gsimplecal): Add gsimplecal to Guix for > the first time, sourced from git. Simply say "New variable". > --- This line marks where you can add comments when you transmit the patch as-is. You might want to use it in lieu of a pre-statement. > gnu/packages/calendar.scm | 30 ++++++++++++++++++++++++++++++ > 1 file changed, 30 insertions(+) > > diff --git a/gnu/packages/calendar.scm b/gnu/packages/calendar.scm > index 8ec36d4fa2..4c54ac0549 100644 > --- a/gnu/packages/calendar.scm > +++ b/gnu/packages/calendar.scm > @@ -10,6 +10,7 @@ > ;;; Copyright © 2020 Brendan Tildesley > ;;; Copyright © 2020 Tanguy Le Carrour > ;;; Copyright © 2020 Peng Mei Yu > +;;; Copyright © 2021 Wamm K. D. > ;;; > ;;; This file is part of GNU Guix. > ;;; > @@ -36,6 +37,7 @@ (define-module (gnu packages calendar) > #:use-module (guix build-system cmake) > #:use-module (guix build-system python) > #:use-module (gnu packages admin) > + #:use-module (gnu packages autotools) > #:use-module (gnu packages base) > #:use-module (gnu packages check) > #:use-module (gnu packages dav) > @@ -405,3 +407,31 @@ (define-public ccal > ;; COPYING.LESSER specifies LGPL 3.0, but all source files say > ;; 'Lesser GPL version 2 or later'. > (license (list license:gpl2+ license:lgpl2.1+)))) > + > +(define-public gsimplecal > + (let ([commit "f00b80d86300397b52c3cf7d8dfc8de5cdee921d"] > + [revision "1"]) Guile is not racket, it's round brackets everywhere. We also don't do right alignment. A simple space between variable/field and value is enough. > + (package > + (name "gsimplecal") As above, pp. > + (version (git-version "2.2" revision commit)) > + (source (origin > + (method git-fetch) > + (uri (git-reference > + (url " > https://github.com/dmedvinsky/gsimplecal/") > + (commit > commit))) > + (file-name (git-file-name name version)) > + (sha256 (base32 (string-append/shared > + > "1qyf65l088dqsz25hm6s1cv18j" > + > "52yaias0llqvpqwjfnvssa5cxg"))) Use a single string rather than a function call. > + (modules '((guix build utils))))) > + (build-system gnu-build-system) > + (native-inputs `(("autoconf" ,autoconf) > + ("automake" ,automake) > + ("pkg-config" ,pkg-config) > + ("gtk+" ,gtk+))) GTK+ is probably not a native-input. Also use a newline here. > + (home-page "https://dmedvinsky.github.io/gsimplecal/") > + (synopsis "Lightweight calendar applet written in C++ > using GTK") > + (description "Gsimplecal was intentionally made for use with > tint2 panel > +in the openbox environment to be launched upon clock click but, of > course, it > +will work without it.") That's... not very descriptive, is it? > + (license license:bsd-3)))) Thanks for the submission and happy hacking :)