From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id QNYfFXN6XGfmmQAA62LTzQ:P1 (envelope-from ) for ; Fri, 13 Dec 2024 18:18:27 +0000 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id QNYfFXN6XGfmmQAA62LTzQ (envelope-from ) for ; Fri, 13 Dec 2024 19:18:27 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=WeRz8qjW; dkim=fail ("headers rsa verify failed") header.d=lassieur.org header.s=fm3 header.b=inPwkQLW; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm1 header.b="ke1t/pbY"; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=lassieur.org (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1734113907; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=cI7hL0ewGXnNOLO0Kral4nLHfUUwezs25tX8w2msnpw=; b=Odv/kvmYGlObX8R8iRNj2Gn/1Pd9upnCQoUVfC36iOL1acrO9kO9L/0HPm8Cscxcoqllax 14xveiB1uSQq1IyNySAtd0NskfCHMGiy2QYHQavFXaI71UrFkc+PUq5hZ5HOPY2zGUDzGV s4xmdfNs4IU/1sSuuFs6dcmPE96YuXEW0EG3GT56jUnFoPSVEpmbhKQaZ9f7meFdzaMGfo dr2aMpCaO9DZ0lVVpytgPJSMSYbWAOLNQceYJTyby5Imks8LCb3A+h1m9ZgZiwCRjs8n2O lMJPPjmS43gccpgfk9LcYakivT+GX+V1NuUzpeRYzubRVv8bOdJDuvbRye7cwQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=WeRz8qjW; dkim=fail ("headers rsa verify failed") header.d=lassieur.org header.s=fm3 header.b=inPwkQLW; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm1 header.b="ke1t/pbY"; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=lassieur.org (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1734113907; a=rsa-sha256; cv=none; b=my3xDj1UX3Ewhj4iDrzQ4gk1JJTqopHzOg5UpEj3ofJbGuJtc+UycXCiRQ04iG3Dm62KZQ MQGfygDkosyti/hwiVC1Kr4t/cwhfs+K+xCJmPsIFxJu1YcnrCke+YR3C1vWtFV1liPddw fKNmTfm5ElR0Qj+M1gLdkNRpqwjRgyO3wLfLTYylWr34Ip9MBLSTVRbVGvCELJH2F0wuBr 8ByKeMtkI0RD8c7MxzLWY4Fz1thR4XTrCzOxsikZuEH3Wlqu/qrdWK71qOqhoSYVLSGiNa etBfsabCf3iT/fq+gyCp96Ciw/+tZJMQWW4lHzHGg4x2nOaEIjU3iFSevIlHpA== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 23FD4924BB for ; Fri, 13 Dec 2024 19:18:27 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tMAEm-0007EA-7R; Fri, 13 Dec 2024 13:18:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tMAEk-0007Do-8A for guix-patches@gnu.org; Fri, 13 Dec 2024 13:18:02 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tMAEj-0003Rp-Tf for guix-patches@gnu.org; Fri, 13 Dec 2024 13:18:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=References:In-Reply-To:From:Date:MIME-Version:To:Subject; bh=cI7hL0ewGXnNOLO0Kral4nLHfUUwezs25tX8w2msnpw=; b=WeRz8qjWoDuy3RobNqpmIrmga1YtuG0qSfVwcg/dWVjcnw/LBx7bcEF6DsEr91REKTvUbVCXKabRoj0t8TZxNE2ffy3efVdJCqBZjf4uV3O5WxvHcSA9n/qbUFBSbUXOmxIWob4Jw9UZ6xBK7fQIUqwKjB+EZM54ylzaBHScyKZ7P9q68Rh1Nhg1DYz8sctHoZUZTiOj7gJ/QIpHrndl52MsRpTp5Oy3uIsjTErCE3uIrM0ssQrhjdaO1W66MVPCf7BJj11VKzWCbk91LGW1c7xeuKqAYSl+pctL0O/e+Xn4SUlaYwH1FmHq8IelyVj0FzPuyAu+f59orcoznzMaAw==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tMAEj-0004Ap-K3 for guix-patches@gnu.org; Fri, 13 Dec 2024 13:18:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#74790] [PATCH] gnu: librewolf: Support Guix icecat browser extensions. Resent-From: =?UTF-8?Q?Cl=C3=A9ment?= Lassieur Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 13 Dec 2024 18:18:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74790 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: "Ian Eure" , "Hilton Chain" Cc: 74790@debbugs.gnu.org, =?UTF-8?Q?Andr=C3=A9?= Batista , Jonathan Brielmaier , Mark H Weaver Received: via spool by 74790-submit@debbugs.gnu.org id=B74790.173411382315955 (code B ref 74790); Fri, 13 Dec 2024 18:18:01 +0000 Received: (at 74790) by debbugs.gnu.org; 13 Dec 2024 18:17:03 +0000 Received: from localhost ([127.0.0.1]:44057 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tMADl-000495-R9 for submit@debbugs.gnu.org; Fri, 13 Dec 2024 13:17:02 -0500 Received: from fout-b2-smtp.messagingengine.com ([202.12.124.145]:40195) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tMADf-00048b-GH for 74790@debbugs.gnu.org; Fri, 13 Dec 2024 13:16:59 -0500 Received: from phl-compute-02.internal (phl-compute-02.phl.internal [10.202.2.42]) by mailfout.stl.internal (Postfix) with ESMTP id 08BCF11400BD; Fri, 13 Dec 2024 13:16:49 -0500 (EST) Received: from phl-imap-06 ([10.202.2.83]) by phl-compute-02.internal (MEProxy); Fri, 13 Dec 2024 13:16:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lassieur.org; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm3; t=1734113808; x=1734200208; bh=cI7hL0ewGX nNOLO0Kral4nLHfUUwezs25tX8w2msnpw=; b=inPwkQLWxsU6ssP3qM0MEeTLbc yeGrp/5UIWuS48dbE2bs9ILg0H+RLoP5v9iFlCfhzO7gX6QZCeoYM7CWkpauEIDi LjJjIXTOlC1kkTAH4Ifywc5SCdEi87iw6+duC99XhwYsTWomH4DqWoBLdyvfoLJJ Wr6c4Pw+uY10+07G6pYN24WTMwSP9PZbDRINj1Oe7OuL8E6Fqm0xJ0mQKnzCy4yE MS0cGZ4hMjmbPG7JjT4zWfmseZOAdgQBI1JKmF9t3PhKxMWSX4SAz/dnrYx7HJRZ GUMozfwGQZ8ncajxVMIpDOAe7yVq6NS4Wc+lq+iNA7P0J3Dzrkz7ir72qsHg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1734113808; x=1734200208; bh=cI7hL0ewGXnNOLO0Kral4nLHfUUwezs25tX 8w2msnpw=; b=ke1t/pbYpVmlKBRmWsonj1Qx5VMtaCxD7GRbbRRWkAkCL7OOnMr +Wu0GZZ8daqHJdVLAWLrH8SUxsqSjdO8n7AzlzzoZlyQXbv8NN/sznqHTFFbm/Gg PqCdG9lgb0a5/srmPoJMUop782on1nC3DmH5cbMGpDQgO5FAwIYuQ9zT7sBlAIbz wHPBU0NegJRRXrxfUZwqOxz74OO5P6gIlSUOl1CduCDQhnNsSSPIQ8PIZxyLS7wW +Pby4qmNw1yToDEzEW49U5tMuYY4ST8CrmuCNc1uI9o5p0UlogUfsarxJcA8HVAR JEDUXdexm0noJsOgW+w2ci+Owuw8eBEHiaQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefuddrkeejgddutdelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhepofggfffhvfevkfgjfhfutgesrgdtreerredtjeen ucfhrhhomhepvehlrohmvghnthcunfgrshhsihgvuhhruceotghlvghmvghntheslhgrsh hsihgvuhhrrdhorhhgqeenucggtffrrghtthgvrhhnpefhgeevfffhfeduveeukefhudei jeekgedvfeefleejudeggefflefhheelffeiieenucffohhmrghinhepghhnuhdrohhrgh enucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegtlhgv mhgvnhhtsehlrghsshhivghurhdrohhrghdpnhgspghrtghpthhtohepiedpmhhouggvpe hsmhhtphhouhhtpdhrtghpthhtohepjeegjeeltdesuggvsggsuhhgshdrghhnuhdrohhr ghdprhgtphhtthhopehmhhifsehnvghtrhhishdrohhrghdprhgtphhtthhopehirghnse hrvghtrhhoshhpvggtrdhtvhdprhgtphhtthhopehnrghnughrvgesrhhishgvuhhprdhn vghtpdhrtghpthhtohephhgrkhhosehulhhtrhgrrhgrrhgvrdhsphgrtggvpdhrtghpth htohepjhhonhgrthhhrghnrdgsrhhivghlmhgrihgvrhesfigvsgdruggv X-ME-Proxy: Feedback-ID: i4c21472a:Fastmail Received: by mailuser.phl.internal (Postfix, from userid 501) id 4CEEA29C006F; Fri, 13 Dec 2024 13:16:48 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface MIME-Version: 1.0 Date: Fri, 13 Dec 2024 19:15:11 +0100 From: =?UTF-8?Q?Cl=C3=A9ment?= Lassieur Message-Id: In-Reply-To: <87bjxf8oup.fsf@retrospec.tv> References: <87bjxf8oup.fsf@retrospec.tv> Content-Type: multipart/alternative; boundary=76f5d545285d48248c20f69968e7931d X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Scanner: mx11.migadu.com X-Migadu-Spam-Score: 3.32 X-Spam-Score: 3.32 X-Migadu-Queue-Id: 23FD4924BB X-TUID: d/guqFBfo4Ib --76f5d545285d48248c20f69968e7931d Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi Ian, On Fri, Dec 13, 2024, at 6:38 PM, Ian Eure wrote: > The patches look good to me, thank you for taking this on! How to=20 > handle browser extensions is a subject that=E2=80=99s been on my mind=20 > intermittently, so it=E2=80=99s great to see effort in that direction. >=20 > I think it might be non-obvious that IceCat packages affect=20 > non-IceCat browsers. I=E2=80=99d really like to have a solid facility= for=20 > managing extensions across the different Firefox forks, either=20 > with generic "browser-extension-ublock-origin" packages; or=20 > something similar to the Common Lisp setup, where=20 > implementation-specific package variants can be derived from a=20 > canonical one. I've looked into having variant-specific extensions already (https://issues.guix.gnu.org/68298), and I came to the conclusion that it added a lot of complexity for little benefits. Maybe I was wrong and you thought of a better implementation? Still, I think most of the time use= rs would want their "system add-ons" to be available on all browsers. When= this is not the case, they can already use 'guix shell' to run a Firefox vari= ant with a different set of extensions, or use the built-in add-on system. We can however add clarity where things are unclear. Cheers, Cl=C3=A9ment > I lean somewhat towards the latter approach, since=20 > I think it provides a cleaner way of handling differences across=20 > browsers. Given the different release cadences, I think it makes=20 > sense to abstract over the differences in the build tooling rather=20 > than patching the browsers to get consistent behavior. >=20 > To be clear here, these patches don=E2=80=99t have to wait for that; I= =E2=80=99m=20 > +1 on pushing as-is. But I think we should have a more explicit=20 > system for handling browser extension packages. --76f5d545285d48248c20f69968e7931d Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable
Hi Ian,

On Fri, Dec 13, 2024, at 6:38 PM, Ian Eure wrote:<= br>
The patches= look good to me, thank you for taking this on!  How to 
handle browser extensions is a subject that=E2=80=99s been on m= y mind 
intermittently, so it=E2=80=99s great to see = effort in that direction.

I think it might = be non-obvious that IceCat packages affect 
non-IceCa= t browsers.  I=E2=80=99d really like to have a solid facility for&n= bsp;
managing extensions across the different Firefox fork= s, either 
with generic "browser-extension-ublock-ori= gin" packages; or 
something similar to the Common Li= sp setup, where 
implementation-specific package vari= ants can be derived from a 
canonical one.
<= /blockquote>

I've looked into having variant-spe= cific extensions already
(https://issues.guix.gnu.org/68298), and I came t= o the conclusion that it
=
added a lot of complexity for little benefits.  Maybe I was wr= ong and you
thought = of a better implementation?  Still, I think most of the time users<= br style=3D"max-width:100%;height:auto;">
would want their "sy= stem add-ons" to be available on all browsers.  When this
is not the case, they can alrea= dy use 'guix shell' to run a Firefox variant
with a different set of extensions, or use the = built-in add-on system.
<= div>

We can however add clarity where things are uncl= ear.

Cheers,
Cl=C3=A9ment
=

I lean somewhat towards the latter approach, since 
I think it provides a cleaner way of handling differences across&n= bsp;
browsers.  Given the different release cadences,= I think it makes 
sense to abstract over the differe= nces in the build tooling rather 
than patching the b= rowsers to get consistent behavior.

To be c= lear here, these patches don=E2=80=99t have to wait for that; I=E2=80=99= m 
+1 on pushing as-is.  But I think we should h= ave a more explicit 
system for handling browser exte= nsion packages.

--76f5d545285d48248c20f69968e7931d--