On 16-09-2022 17:53, 路辉 wrote:
>> Can be simplified:
>>
>> #:make-flags
>> ,(let ((target ,(%current-target-system)))

Oops the , before (%current-target-system) shouldn't be there

>>      (if target
>>          #~(list (string-append "CROSS_COMPILE=" ,target))

OOps, ,target -> #$target

>>          #~'()))
>>
>> (the #~ makes the phasing more explicit, if you go for that, I recommend
>> turning the arguments into (arguments (list #:phases #~(modify-phases
>> ...) #:make-flags ...)), instead of using ` / , , to remain consistent.)
>>
>> Greetings,
>> Maxime
>>
> 
> new patch vvvv

The #:make-flags simplification is missing (it can help with avoiding 
rebuilds (e.g. if a particular architecture needs some different 
#:make-flags than usual), but otherwise looks good.

Greetings,
Maxime.