From: Maxime Devos <maximedevos@telenet.be>
To: 路辉 <luhux76@gmail.com>
Cc: 57857@debbugs.gnu.org
Subject: [bug#57857] [PATCH] gnu: busybox: fix the cross build.
Date: Sun, 25 Sep 2022 19:55:35 +0200 [thread overview]
Message-ID: <ce103d10-19d4-5c7a-e06b-9673cce8aeb8@telenet.be> (raw)
In-Reply-To: <CAGNyvehF7vEL0XejBy_jUcaBU94AgBwjadDfYWYT1+cSnL7seA@mail.gmail.com>
[-- Attachment #1.1.1: Type: text/plain, Size: 838 bytes --]
On 16-09-2022 17:53, 路辉 wrote:
>> Can be simplified:
>>
>> #:make-flags
>> ,(let ((target ,(%current-target-system)))
Oops the , before (%current-target-system) shouldn't be there
>> (if target
>> #~(list (string-append "CROSS_COMPILE=" ,target))
OOps, ,target -> #$target
>> #~'()))
>>
>> (the #~ makes the phasing more explicit, if you go for that, I recommend
>> turning the arguments into (arguments (list #:phases #~(modify-phases
>> ...) #:make-flags ...)), instead of using ` / , , to remain consistent.)
>>
>> Greetings,
>> Maxime
>>
>
> new patch vvvv
The #:make-flags simplification is missing (it can help with avoiding
rebuilds (e.g. if a particular architecture needs some different
#:make-flags than usual), but otherwise looks good.
Greetings,
Maxime.
[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 929 bytes --]
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]
next prev parent reply other threads:[~2022-09-25 17:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-16 12:35 [bug#57857] [PATCH] gnu: busybox: fix the cross build 路辉
2022-09-16 15:08 ` Maxime Devos
2022-09-16 15:53 ` 路辉
2022-09-25 17:55 ` Maxime Devos [this message]
2022-09-26 21:27 ` bug#57857: " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ce103d10-19d4-5c7a-e06b-9673cce8aeb8@telenet.be \
--to=maximedevos@telenet.be \
--cc=57857@debbugs.gnu.org \
--cc=luhux76@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).