From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id YFCaN/A3T2AlTwAA0tVLHw (envelope-from ) for ; Mon, 15 Mar 2021 10:33:20 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id +MpUM/A3T2ClJgAAbx9fmQ (envelope-from ) for ; Mon, 15 Mar 2021 10:33:20 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 3A02E212F4 for ; Mon, 15 Mar 2021 11:33:20 +0100 (CET) Received: from localhost ([::1]:39100 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lLkXG-0005In-PO for larch@yhetil.org; Mon, 15 Mar 2021 06:33:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54026) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lLkX1-0005HU-97 for guix-patches@gnu.org; Mon, 15 Mar 2021 06:33:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:51611) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lLkX0-0003xL-5F for guix-patches@gnu.org; Mon, 15 Mar 2021 06:33:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lLkX0-0000C2-2B for guix-patches@gnu.org; Mon, 15 Mar 2021 06:33:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#47153] [PATCH] gnu: chez-scheme: simplify packaging Resent-From: Leo Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 15 Mar 2021 10:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47153 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Philip McGrath , 47153@debbugs.gnu.org Received: via spool by 47153-submit@debbugs.gnu.org id=B47153.1615804362716 (code B ref 47153); Mon, 15 Mar 2021 10:33:02 +0000 Received: (at 47153) by debbugs.gnu.org; 15 Mar 2021 10:32:42 +0000 Received: from localhost ([127.0.0.1]:34924 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lLkWg-0000BU-3o for submit@debbugs.gnu.org; Mon, 15 Mar 2021 06:32:42 -0400 Received: from mailrelay.tugraz.at ([129.27.2.202]:59888) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lLkWd-0000BI-1t for 47153@debbugs.gnu.org; Mon, 15 Mar 2021 06:32:40 -0400 Received: from nijino.local (217-149-164-20.nat.highway.telekom.at [217.149.164.20]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4DzXmf4Wynz3w9M; Mon, 15 Mar 2021 11:32:34 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1615804354; bh=18109riXmvEu2cMS6LrwcWa9FY5M11lkkeyoKVL7yfk=; h=Subject:From:To:Date:In-Reply-To:References; b=EH2PNb7GT4RIu4o2w1b5XCaiYYkvGbXUkvEETCMe0xqjjuVkX2QKIDxec5S+mmnuW dRMW+L966XfAf7+RbVXWEIp0niMdGw5brZX22kfgKxZ6jcV16NMld07lyf+zp+2biw wLlnUKAfpiF2owUtGw26MXIrZ4M1OLZcsTmyg9N4= Message-ID: From: Leo Prikler Date: Mon, 15 Mar 2021 11:32:33 +0100 In-Reply-To: <20210315084235.7051-1-philip@philipmcgrath.com> References: <20210315084235.7051-1-philip@philipmcgrath.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-TUG-Backscatter-control: bt4lQm5Tva3SBgCuw0EnZw X-Spam-Scanner: SpamAssassin 3.003001 X-Spam-Score-relay: -1.9 X-Scanned-By: MIMEDefang 2.74 on 129.27.10.117 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1615804400; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=18109riXmvEu2cMS6LrwcWa9FY5M11lkkeyoKVL7yfk=; b=YbUQ2tQ98stIKHo7SrGzk/TdA09erHKxk8XsNtNNwbPC6hPPEwrq447u98hkD8vJ3+2OLI AOr38j3m7lHuWsjf2ISkYU5WLIPqTngX8tI57jUaV4ltrtzGAegE2J5hjCLQY63MKiAvGn QU5MPPi32piRQAjRLcOCUb7HgWXqaYrKnnqKC16L/hqyMfCtFIfTA9knFHUMv/l7rVmDsa 57YiytPsDrKnrKcSrtGx4WGoR+XyzbuEEWMxH52bJHANiBVwnL7OY6czjMb4uScWO1cUhD i9kiGBnKAQOGLNxmaoTCpBwC18vPPhoKG5zENZGoltigKldNpuwDzysR2kHjvQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1615804400; a=rsa-sha256; cv=none; b=MGaASEboeTpWhjIabkQJ5fDA6l6yeJ3WjyOheB739wH/Y60RX5x3KxqJgv6NE0EDm9ZT5M WqSk9d7ifjSJMHmmTy0Hm3aWBkhQPrmFOTDTqxBiDvKMqKbod7BzFmiKDGjLHk35nGXDgE g50GyfBB71u4ucK4SM2/gAnpZhu4ZkViGzb1EwcakH/GQcJNYzB8GoavsezvE9KBiFS8KM 7erGgWdmOrStl80VkL91BkH+o3KT2jaT1OchVyQd8v86HhRZ+3m7yYhK1QbpCpGLelTulq xOfW0E6qahNjquTS8OG88cr+DAQE7sBZCODjBNBQiwDf4A2E2VbrLKXfO6APhw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tugraz.at header.s=mailrelay header.b=EH2PNb7G; dmarc=fail reason="SPF not aligned (relaxed)" header.from=student.tugraz.at (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.30 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tugraz.at header.s=mailrelay header.b=EH2PNb7G; dmarc=fail reason="SPF not aligned (relaxed)" header.from=student.tugraz.at (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 3A02E212F4 X-Spam-Score: -1.30 X-Migadu-Scanner: scn0.migadu.com X-TUID: Q1xYjWAVWnJ1 Hi, I'm not an expert on Chez Scheme, so take this with a grain of salt, but I do have some questions/remarks. Am Montag, den 15.03.2021, 04:42 -0400 schrieb Philip McGrath: > * gnu/packages/chez.scm (nanopass): Rename it to ... > (nanopass-framework-scheme): ... this variable. Change it from an > origin > to a package. Update to 1.9.2. What advantages do we get from making this a package? Can it be upgraded to 1.9.2 without this change at the same time? > (stex): Rename it to ... > (chez-stex): ... this variable. Change it from an origin to a hidden > package. Update to commit 5405149, which helps us install it. Same here, also does this need to be done at the same time as the nanopass upgrade? > (chez-scheme)[source](patches): Use it. Use what? > [source](snippet): Remove bundled libraries here, not during > 'configure' > phase. Also remove irrelevant bootfiles. This seems okay. > + (build-system gnu-build-system) > + (arguments > + `(#:phases > + (modify-phases %standard-phases > + (delete 'bootstrap) > + (delete 'patch-usr-bin-file) > + (delete 'configure) > + (delete 'patch-generated-file-shebangs) > + (delete 'build) > + (delete 'check) > + (replace 'install > + (lambda* (#:key outputs #:allow-other-keys) > + (copy-recursively "." (assoc-ref outputs "out")) > + #t)) > + (delete 'patch-shebangs) > + (delete 'strip) > + (delete 'validate-runpath) > + (delete 'validate-documentation-location) > + (delete 'delete-info-dir-file) > + (delete 'patch-dot-desktop-files) > + (delete 'install-license-files) > + (delete 'reset-gzip-timestamps) > + (delete 'compress-documentation))))))) copy-build-system exists. And again, what is the point of making this a package if it contains the exact same files as the corresponding origin? > +(define chez-stex > + ;; Hidden because of a circular dependency issue: > + ;; stex needs chez-scheme to be used, but chez-scheme uses > + ;; stex to build its documentation. > + ;; The chez-scheme package has an stex output that exposes > + ;; the useful version of this---or maybe there's a more elegant > solution? > + (hidden-package > + (let ((version "1.2.2") > + ;; This commit includes a fix for which we would > + ;; otherwise want to use a snippet. > + ;; When there's a new tagged release, > + ;; go back to using (string-append "v" version) > + (commit "54051494434a197772bf6ca5b4e6cf6be55f39a5") > + (revision "1")) ;Guix package revision > + (package > + (inherit nanopass-framework-scheme) > + (name "chez-stex") > + (version (git-version version revision commit)) > + (source > + (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/dybvig/stex") > + (commit commit))) > + (sha256 > "01jnvw8qw33gnpzwrakwhsr05h6b609lm180jnspcrb7lds2p23d") > + (file-name (git-file-name "stex" version)))) > + (home-page "https://github.com/dybvig/stex") > + (synopsis > + "Tools for including Scheme in LaTeX and converting to > HTML") > + (description > + "The @dfn{stex} package consists of two main programs and > some > +supporting items, such as make files, make-file templates, class > files, > +and style files. The two main programs are @command{scheme-prep} > and > +@command{html-prep}. @command{scheme-prep} performs a conversion > from > +stex-formatted files into LaTeX-formatted files, while > @command{html-prep} > +converts (some) LaTeX-formatted files into html-formatted files. > + > +An stex file is really just a LaTeX file extended with a handful of > commands > +for including Scheme code (or pretty much any other kind of code, as > long as > +you don't plan to use the Scheme-specific transcript support) in a > document, > +plus a couple of additional features rather arbitrarily thrown in.") > + (license (list expat)))))) > > -(define stex > - (let ((version "1.2.2")) > - (origin > - (method git-fetch) > - (uri (git-reference > - (url "https://github.com/dybvig/stex") > - (commit (string-append "v" version)))) > - (sha256 (base32 > "1q5i8pf4cdfjsj6r2k1rih7ljbfggyxdng2p2fvsgarzihpsin2i")) > - (file-name (git-file-name "stex" version))))) Again, where is the benefit in having this as a hidden-package? Regards, Leo