From: Leo Prikler <leo.prikler@student.tugraz.at>
To: Philip McGrath <philip@philipmcgrath.com>, 47153@debbugs.gnu.org
Subject: [bug#47153] [PATCH] gnu: chez-scheme: simplify packaging
Date: Mon, 15 Mar 2021 11:32:33 +0100 [thread overview]
Message-ID: <cd84e81c9636899b80ef3e31fd0fbb2bd23de7ad.camel@student.tugraz.at> (raw)
In-Reply-To: <20210315084235.7051-1-philip@philipmcgrath.com>
Hi,
I'm not an expert on Chez Scheme, so take this with a grain of salt,
but I do have some questions/remarks.
Am Montag, den 15.03.2021, 04:42 -0400 schrieb Philip McGrath:
> * gnu/packages/chez.scm (nanopass): Rename it to ...
> (nanopass-framework-scheme): ... this variable. Change it from an
> origin
> to a package. Update to 1.9.2.
What advantages do we get from making this a package? Can it be
upgraded to 1.9.2 without this change at the same time?
> (stex): Rename it to ...
> (chez-stex): ... this variable. Change it from an origin to a hidden
> package. Update to commit 5405149, which helps us install it.
Same here, also does this need to be done at the same time as the
nanopass upgrade?
> (chez-scheme)[source](patches): Use it.
Use what?
> [source](snippet): Remove bundled libraries here, not during
> 'configure'
> phase. Also remove irrelevant bootfiles.
This seems okay.
> + (build-system gnu-build-system)
> + (arguments
> + `(#:phases
> + (modify-phases %standard-phases
> + (delete 'bootstrap)
> + (delete 'patch-usr-bin-file)
> + (delete 'configure)
> + (delete 'patch-generated-file-shebangs)
> + (delete 'build)
> + (delete 'check)
> + (replace 'install
> + (lambda* (#:key outputs #:allow-other-keys)
> + (copy-recursively "." (assoc-ref outputs "out"))
> + #t))
> + (delete 'patch-shebangs)
> + (delete 'strip)
> + (delete 'validate-runpath)
> + (delete 'validate-documentation-location)
> + (delete 'delete-info-dir-file)
> + (delete 'patch-dot-desktop-files)
> + (delete 'install-license-files)
> + (delete 'reset-gzip-timestamps)
> + (delete 'compress-documentation)))))))
copy-build-system exists. And again, what is the point of making this
a package if it contains the exact same files as the corresponding
origin?
> +(define chez-stex
> + ;; Hidden because of a circular dependency issue:
> + ;; stex needs chez-scheme to be used, but chez-scheme uses
> + ;; stex to build its documentation.
> + ;; The chez-scheme package has an stex output that exposes
> + ;; the useful version of this---or maybe there's a more elegant
> solution?
> + (hidden-package
> + (let ((version "1.2.2")
> + ;; This commit includes a fix for which we would
> + ;; otherwise want to use a snippet.
> + ;; When there's a new tagged release,
> + ;; go back to using (string-append "v" version)
> + (commit "54051494434a197772bf6ca5b4e6cf6be55f39a5")
> + (revision "1")) ;Guix package revision
> + (package
> + (inherit nanopass-framework-scheme)
> + (name "chez-stex")
> + (version (git-version version revision commit))
> + (source
> + (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://github.com/dybvig/stex")
> + (commit commit)))
> + (sha256
> "01jnvw8qw33gnpzwrakwhsr05h6b609lm180jnspcrb7lds2p23d")
> + (file-name (git-file-name "stex" version))))
> + (home-page "https://github.com/dybvig/stex")
> + (synopsis
> + "Tools for including Scheme in LaTeX and converting to
> HTML")
> + (description
> + "The @dfn{stex} package consists of two main programs and
> some
> +supporting items, such as make files, make-file templates, class
> files,
> +and style files. The two main programs are @command{scheme-prep}
> and
> +@command{html-prep}. @command{scheme-prep} performs a conversion
> from
> +stex-formatted files into LaTeX-formatted files, while
> @command{html-prep}
> +converts (some) LaTeX-formatted files into html-formatted files.
> +
> +An stex file is really just a LaTeX file extended with a handful of
> commands
> +for including Scheme code (or pretty much any other kind of code, as
> long as
> +you don't plan to use the Scheme-specific transcript support) in a
> document,
> +plus a couple of additional features rather arbitrarily thrown in.")
> + (license (list expat))))))
>
> -(define stex
> - (let ((version "1.2.2"))
> - (origin
> - (method git-fetch)
> - (uri (git-reference
> - (url "https://github.com/dybvig/stex")
> - (commit (string-append "v" version))))
> - (sha256 (base32
> "1q5i8pf4cdfjsj6r2k1rih7ljbfggyxdng2p2fvsgarzihpsin2i"))
> - (file-name (git-file-name "stex" version)))))
Again, where is the benefit in having this as a hidden-package?
Regards,
Leo
next prev parent reply other threads:[~2021-03-15 10:33 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-15 8:42 [bug#47153] [PATCH] gnu: chez-scheme: simplify packaging Philip McGrath
2021-03-15 10:32 ` Leo Prikler [this message]
2021-03-15 18:03 ` Philip McGrath
2021-03-15 18:28 ` Leo Prikler
2021-03-15 21:53 ` Philip McGrath
2021-03-15 22:21 ` Leo Prikler
2021-03-15 22:53 ` [bug#47153] [PATCH v2 1/3] gnu: chez-scheme: Update nanopass to 1.9.2 Philip McGrath
2021-03-15 22:53 ` [bug#47153] [PATCH v2 2/3] gnu: chez-scheme: Update stex Philip McGrath
2021-03-15 22:53 ` [bug#47153] [PATCH v2 3/3] gnu: chez-scheme: simplify packaging Philip McGrath
2021-03-16 7:37 ` [bug#47153] [PATCH v2] gnu: chez-scheme: Update nanopass to 1.9.2 Leo Prikler
2021-03-16 20:19 ` Philip McGrath
2021-03-16 21:09 ` Leo Prikler
2021-03-19 18:24 ` [bug#47153] [PATCH v3 1/3] " Philip McGrath
2021-03-19 18:24 ` [bug#47153] [PATCH v3 2/3] gnu: chez-scheme: Update stex Philip McGrath
2021-03-19 18:24 ` [bug#47153] [PATCH v3 3/3] gnu: chez-scheme: simplify packaging Philip McGrath
2021-04-05 10:02 ` [bug#47153] [PATCH] " Ludovic Courtès
2021-04-05 14:20 ` bug#47153: " Leo Prikler
2021-03-20 16:06 ` [bug#47153] [PATCH v2] gnu: chez-scheme: Update nanopass to 1.9.2 Philip McGrath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cd84e81c9636899b80ef3e31fd0fbb2bd23de7ad.camel@student.tugraz.at \
--to=leo.prikler@student.tugraz.at \
--cc=47153@debbugs.gnu.org \
--cc=philip@philipmcgrath.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).