From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id SC7dHyInh2C5lAAAgWs5BA (envelope-from ) for ; Mon, 26 Apr 2021 22:48:34 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id IBaLGyInh2BgOAAAB5/wlQ (envelope-from ) for ; Mon, 26 Apr 2021 20:48:34 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 3207F1761D for ; Mon, 26 Apr 2021 22:48:34 +0200 (CEST) Received: from localhost ([::1]:40718 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lb89h-0003rY-Au for larch@yhetil.org; Mon, 26 Apr 2021 16:48:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40312) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lb89D-0003hQ-Gu for guix-patches@gnu.org; Mon, 26 Apr 2021 16:48:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:35798) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lb89C-0001cO-9C for guix-patches@gnu.org; Mon, 26 Apr 2021 16:48:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lb89C-0005x3-7G for guix-patches@gnu.org; Mon, 26 Apr 2021 16:48:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#48028] [PATCH wip-gnome 1/8] gnu: gtkmm@2: Remove inheritance from gtkmm@3. Resent-From: Maxime Devos Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 26 Apr 2021 20:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48028 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Raghav Gururajan , 48028@debbugs.gnu.org Received: via spool by 48028-submit@debbugs.gnu.org id=B48028.161947006522855 (code B ref 48028); Mon, 26 Apr 2021 20:48:02 +0000 Received: (at 48028) by debbugs.gnu.org; 26 Apr 2021 20:47:45 +0000 Received: from localhost ([127.0.0.1]:47344 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lb88v-0005wY-EC for submit@debbugs.gnu.org; Mon, 26 Apr 2021 16:47:45 -0400 Received: from albert.telenet-ops.be ([195.130.137.90]:58264) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lb88t-0005wQ-W0 for 48028@debbugs.gnu.org; Mon, 26 Apr 2021 16:47:44 -0400 Received: from ptr-bvsjgyjmffd7q9timvx.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:aaf1:9810:a0b8:a55d]) by albert.telenet-ops.be with bizsmtp id xYnh2400Z0mfAB406Yniby; Mon, 26 Apr 2021 22:47:42 +0200 Message-ID: From: Maxime Devos Date: Mon, 26 Apr 2021 22:47:37 +0200 In-Reply-To: <20210426081145.28926-1-rg@raghavgururajan.name> References: <7c08ca5b-a7cb-cdf3-c8bb-673cec8876a8@raghavgururajan.name> <20210426081145.28926-1-rg@raghavgururajan.name> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-wnsoLvViBqbOiekQIgvL" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r21; t=1619470062; bh=D8OEWsq3cIu752S7oji/9h5IEiPcYwELyYpvZO3N1Ds=; h=Subject:From:To:Date:In-Reply-To:References; b=IfmPZkxN3ITjNWh1F2y15leT91wfRS9rFIBxWMTu8CQyGtDBFmIt74DOcotMhTEen w9Pjhe4ZAeYtrbYdgZ3hfYs6GCbxa8OjUDWl3tQcY+b3IIaJfXGx0Jw979F4ETSNed ucS39n418fBYkM/ZZrllp+DeRsO7o8QK84fxT3U+aYmX8BnMDtwXVavAhMUk99bfXG iMI7kNORWHNr+6yxIKcbBguW/y02LAZ36EeffBDpbfUV2PtL6/Sv1MpfIvUE1WUEGW 5LnWOx91DlRaCPTwRPYORF4RudkqitIKO5JzEF/uaGAOYyuylDyQvWgNogQS8qj4yE xUiqXW+mLzO8g== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -4.00 Authentication-Results: aspmx1.migadu.com; none X-Migadu-Queue-Id: 3207F1761D X-Spam-Score: -4.00 X-Migadu-Scanner: scn0.migadu.com X-TUID: JQ2mkhVKUKCv --=-wnsoLvViBqbOiekQIgvL Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable IIUC, the commit message is =E2=80=98gnu: gtkmm@2: Remove inheritance from = gtkmm@3=E2=80=99. But this patch also adds some inputs, a description, starts an X server for tests, places documentation in the correct place ... Could you split up this patch? Raghav Gururajan via Guix-patches via schreef op ma 26-04-2021 om 04:11 [-0= 400]: > Remove inheritance to prevent rebuilds of packages like inkscape > and gtk+, whenever changes are made gtkmm@3. If changes are made to gtkmm@3, wouldn't gtkmm@2 require similar changes anyway? For example ... > * gnu/packages/gtk.scm (gtkmm-2)[build-system,outputs,arguments, > native-inputs,synopsis,description,home-page,license]: New fields. > --- > gnu/packages/gtk.scm | 48 ++++++++++++++++++++++++++++++++++++++++++-- > 1 file changed, 46 insertions(+), 2 deletions(-) >=20 > diff --git a/gnu/packages/gtk.scm b/gnu/packages/gtk.scm > index 04a0db1161..81ac4a7197 100644 > --- a/gnu/packages/gtk.scm > +++ b/gnu/packages/gtk.scm > @@ -1660,7 +1660,6 @@ tutorial.") > =20 > (define-public gtkmm-2 > (package > - (inherit gtkmm) > (name "gtkmm") > (version "2.24.5") > (source > @@ -1672,12 +1671,57 @@ tutorial.") > name "-" version ".tar.xz")) > (sha256 > (base32 "0wkbzvsx4kgw16f6xjdc1dz7f77ldngdila4yi5lw2zrgcxsb006"))= )) > + (build-system glib-or-gtk-build-system) > + (outputs '("out" "doc")) > + (arguments btw, the following has been dropped in , I wonder why? My guess: disallowed-references refers to the wrong version when cross-comp= iling. But that seems rather harmless to me? (Though ideally there would be exist= a disallowed-references/native or something ...) > + `(#:phases > + (modify-phases %standard-phases > + (add-before 'check 'pre-check > + (lambda _ > + ;; Tests require a running X server. > + (system "Xvfb :1 +extension GLX &") > + (setenv "DISPLAY" ":1") > + ;; For missing '/etc/machine-id'. > + (setenv "DBUS_FATAL_WARNINGS" "0") > + #t)) > + (add-after 'install 'move-doc > + (lambda* (#:key outputs #:allow-other-keys) > + (let* ((out (assoc-ref outputs "out")) > + (doc (assoc-ref outputs "doc"))) > + (mkdir-p (string-append doc "/share")) > + (rename-file > + (string-append out "/share/doc") > + (string-append doc "/share/doc")) > + #t)))))) These phases were added to gtkmm@3 in . It seems they are also required in gtkmm@2. > + (native-inputs > + `(("dot" ,graphviz) > + ("doxygen" ,doxygen) > + ("m4" ,m4) > + ("mm-common" ,mm-common) > + ("perl" ,perl) > + ("pkg-config" ,pkg-config) > + ("xsltproc" ,libxslt) > + ("xorg-server" ,xorg-server-for-tests))) Likewise. > (propagated-inputs > `(("atkmm" ,atkmm-2.28) > ("cairomm" ,cairomm-1.13) > ("glibmm" ,glibmm-2.64) > ("gtk+" ,gtk+-2) > - ("pangomm" ,pangomm-2.42))))) > + ("pangomm" ,pangomm-2.42))) > + (synopsis "C++ Interfaces for GTK+ and GNOME") > + (description "GTKmm is the official C++ interface for the popular GU= I > +library GTK+. Highlights include typesafe callbacks, and a comprehensiv= e set of > +widgets that are easily extensible via inheritance. You can create user > +interfaces either in code or with the Glade User Interface designer, usi= ng > +libglademm. There's extensive documentation, including API reference an= d a > +tutorial.") Duplication. > + (home-page "https://gtkmm.org/") > + (license > + (list > + ;; Library > + license:lgpl2.1+ > + ;; Tools > + license:gpl2+)))) More duplication. So I don't see the value of removing inheritance from gtkmm@3. Greetings, Maxime. --=-wnsoLvViBqbOiekQIgvL Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYIcm6RccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7sycAP9wJB068NgREL222NQU6ssFc7Nj DnU3wR9jYoi48WMdlgEA3Z7CYpKSTGQappEp1o0A5BM3XsrhqYYbeIOAbfui9gE= =0Ig0 -----END PGP SIGNATURE----- --=-wnsoLvViBqbOiekQIgvL--