From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id wFrSJpOql2PzEwAAbAwnHQ (envelope-from ) for ; Mon, 12 Dec 2022 23:26:27 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id eKbxJpOql2MKfwEAauVa8A (envelope-from ) for ; Mon, 12 Dec 2022 23:26:27 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 406FDB767 for ; Mon, 12 Dec 2022 23:26:27 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p4rFP-0006PZ-GT; Mon, 12 Dec 2022 17:26:07 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4rFK-0006Ob-FT for guix-patches@gnu.org; Mon, 12 Dec 2022 17:26:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p4rFK-0001xk-5I for guix-patches@gnu.org; Mon, 12 Dec 2022 17:26:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p4rFJ-00051A-Sg for guix-patches@gnu.org; Mon, 12 Dec 2022 17:26:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#60014] [PATCH] activation: make install-special-file match against pairs as well. Resent-From: mirai Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 12 Dec 2022 22:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60014 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Tobias Geerinckx-Rice , Josselin Poiret Cc: 60014@debbugs.gnu.org X-Debbugs-Original-Cc: 60014@debbugs.gnu.org, guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.167088391619257 (code B ref -1); Mon, 12 Dec 2022 22:26:01 +0000 Received: (at submit) by debbugs.gnu.org; 12 Dec 2022 22:25:16 +0000 Received: from localhost ([127.0.0.1]:55800 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4rEZ-00050X-On for submit@debbugs.gnu.org; Mon, 12 Dec 2022 17:25:16 -0500 Received: from lists.gnu.org ([209.51.188.17]:50222) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4rEY-00050R-9V for submit@debbugs.gnu.org; Mon, 12 Dec 2022 17:25:14 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4rEY-0006Ad-2x for guix-patches@gnu.org; Mon, 12 Dec 2022 17:25:14 -0500 Received: from smtpmciv5.myservices.hosting ([185.26.107.241]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4rEW-0001fV-H5 for guix-patches@gnu.org; Mon, 12 Dec 2022 17:25:13 -0500 Received: from mail1.netim.hosting (unknown [185.26.106.172]) by smtpmciv5.myservices.hosting (Postfix) with ESMTP id DD2922076C; Mon, 12 Dec 2022 23:25:06 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by mail1.netim.hosting (Postfix) with ESMTP id 8ACDE80097; Mon, 12 Dec 2022 23:25:06 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at mail1.netim.hosting Received: from mail1.netim.hosting ([127.0.0.1]) by localhost (mail1-1.netim.hosting [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id hQwEoMRXwOUY; Mon, 12 Dec 2022 23:25:06 +0100 (CET) Received: from [192.168.1.239] (unknown [10.192.1.83]) (Authenticated sender: lumen@makinata.eu) by mail1.netim.hosting (Postfix) with ESMTPSA id 0FB7280093; Mon, 12 Dec 2022 23:25:05 +0100 (CET) Message-ID: Date: Mon, 12 Dec 2022 22:25:05 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Content-Language: en-US References: <43e937e1625b47a80887e68847fb8a8811d3f39f.1670867103.git.mirai@makinata.eu> <87k02wfjk5.fsf@jpoiret.xyz> <87v8mgcp45.fsf@nckx> From: mirai In-Reply-To: <87v8mgcp45.fsf@nckx> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=185.26.107.241; envelope-from=mirai@makinata.eu; helo=smtpmciv5.myservices.hosting X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1670883987; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=UrEfWZflfnW6/dRsPZLsW/XE0M/QipYwuVHYELe9kLA=; b=OoX3Zzr3Dfg9420oHN199KbK/skYGWlnGp7BJakzbiCU0OXGts/QqwLl/eFajPjeYBhXZP 7T9j9FN2z4L/7FkRlySHhk57UtFrR4p3O7SaOIAUnCsDCPEQ/C+rtZ74BBRhlfWBWc33oK z7ridxxQguleduCHfzPku7eVYG0a+MRbv7amHcXUMIgqvunoL7V259SZ/s0lc26gu2lOVp m8tOKn3cpI71ISdppZwf251VV0oE09YtfRxj4xFhtTcTxgyi2ylRcAel14EzY3wJb+p/hC Q/rac1hTeM2LBJedgFoJR8+xzCYXCzCaTjq8RIgtr8xgWF2NFe72JRUTPAqYQQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Seal: i=1; s=key1; d=yhetil.org; t=1670883987; a=rsa-sha256; cv=none; b=SCTDqpJIsOGuzCHNMv6T6mGd9V3SIjt64HCdLHEUtJgAfQizWYqYfdZEcMl6NtaCA2mx9G frdBbxDVHRji/ErrfhJGUYigNPlKCbt4Q5DGyRzcUekQKmk2wF8g6uDvr68Bgxv3l+//ac OV+XZbW0Dc+V9v2P4CLUB84cOxoVQ71u6UwWwUTnGQd+EXJcyKvhP8rWcXhgm3SzelJ1xY P1BqaMna4v+5lTgd6eovQmtRAIUzVGglfGXyQiYNpK+z1i9pztOrVnZsN/+P4gm+yYLPNi r2dY6z3losj7n9InGLXvaNtOZcCuiENzOP30rL7adZURW33zkTj1B2JaanhrNQ== X-Migadu-Spam-Score: -3.16 X-Spam-Score: -3.16 X-Migadu-Queue-Id: 406FDB767 X-Migadu-Scanner: scn1.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none X-TUID: GdFKR96jTzDk On 2022-12-12 20:52, Tobias Geerinckx-Rice wrote: > Josselin Poiret via Guix-patches via 写道： >> I personally would prefer keeping the special file interface as-is, and >> not mix two different kinds of entries: lists with 2 elements, and >> pairs.  That would avoid having to manage even more edge-cases down the >> line if some more processing is needed. > > I agree with this reasoning, and would go as far as to say that if this fixes anything, that thing should probably be fixed instead…? > > ‘Takes a list of As, but as a special case, a single A’ is confusing and makes it that much harder for newcomers to move beyond cargo-culting magical snippets. That's not what's happening here, right now what guix does is: take a list of tuples, where tuples are 2-element lists of path + file-like. This patch does: take a list of tuples, where tuples are pairs of path + file-like (and as a bonus, preserve existing configurations by allowing the pairs to be lists as well).