From: mirai <mirai@makinata.eu>
To: Tobias Geerinckx-Rice <me@tobias.gr>, Josselin Poiret <dev@jpoiret.xyz>
Cc: 60014@debbugs.gnu.org
Subject: [bug#60014] [PATCH] activation: make install-special-file match against pairs as well.
Date: Mon, 12 Dec 2022 22:25:05 +0000 [thread overview]
Message-ID: <cc11dcaa-3acd-dd47-0c80-1a98197c9738@makinata.eu> (raw)
In-Reply-To: <87v8mgcp45.fsf@nckx>
On 2022-12-12 20:52, Tobias Geerinckx-Rice wrote:
> Josselin Poiret via Guix-patches via 写道：
>> I personally would prefer keeping the special file interface as-is, and
>> not mix two different kinds of entries: lists with 2 elements, and
>> pairs. That would avoid having to manage even more edge-cases down the
>> line if some more processing is needed.
>
> I agree with this reasoning, and would go as far as to say that if this fixes anything, that thing should probably be fixed instead…?
>
> ‘Takes a list of As, but as a special case, a single A’ is confusing and makes it that much harder for newcomers to move beyond cargo-culting magical snippets.
That's not what's happening here, right now what guix does is: take a list of tuples, where tuples are 2-element lists of path + file-like.
This patch does: take a list of tuples, where tuples are pairs of path + file-like (and as a bonus,
preserve existing configurations by allowing the pairs to be lists as well).
next prev parent reply other threads:[~2022-12-12 22:26 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-12 17:45 [bug#60014] [PATCH] activation: make install-special-file match against pairs as well mirai
2022-12-12 20:34 ` Josselin Poiret via Guix-patches via
2022-12-12 20:52 ` Tobias Geerinckx-Rice via Guix-patches via
2022-12-12 22:25 ` mirai [this message]
2022-12-13 20:04 ` Tobias Geerinckx-Rice via Guix-patches via
2022-12-12 22:09 ` mirai
2022-12-13 10:15 ` Josselin Poiret via Guix-patches via
2022-12-13 13:04 ` mirai
2022-12-13 19:56 ` Josselin Poiret via Guix-patches via
2022-12-20 14:47 ` Ludovic Courtès
2022-12-21 13:20 ` mirai
2022-12-21 13:31 ` [bug#60014] [PATCH v2] doc: Clarify special-files-service-type expected value mirai
2023-02-18 2:33 ` Bruno Victal
2023-03-21 14:15 ` bug#60014: " Maxim Cournoyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cc11dcaa-3acd-dd47-0c80-1a98197c9738@makinata.eu \
--to=mirai@makinata.eu \
--cc=60014@debbugs.gnu.org \
--cc=dev@jpoiret.xyz \
--cc=me@tobias.gr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).