From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id ABRrOixM3GAYXQAAgWs5BA (envelope-from ) for ; Wed, 30 Jun 2021 12:49:16 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id sFotNixM3GAANAAAB5/wlQ (envelope-from ) for ; Wed, 30 Jun 2021 10:49:16 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 95F7E12C76 for ; Wed, 30 Jun 2021 12:49:16 +0200 (CEST) Received: from localhost ([::1]:56750 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lyXmN-00008E-Is for larch@yhetil.org; Wed, 30 Jun 2021 06:49:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52116) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lyXmA-00007E-69 for guix-patches@gnu.org; Wed, 30 Jun 2021 06:49:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:45000) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lyXm9-0003qw-UU for guix-patches@gnu.org; Wed, 30 Jun 2021 06:49:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lyXm9-0001ha-Re for guix-patches@gnu.org; Wed, 30 Jun 2021 06:49:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#49284] [PATCH] gnu: Add fheroes2 Resent-From: Leo Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 30 Jun 2021 10:49:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49284 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Andrew Tropin , 49284@debbugs.gnu.org Received: via spool by 49284-submit@debbugs.gnu.org id=B49284.16250501006493 (code B ref 49284); Wed, 30 Jun 2021 10:49:01 +0000 Received: (at 49284) by debbugs.gnu.org; 30 Jun 2021 10:48:20 +0000 Received: from localhost ([127.0.0.1]:56546 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lyXlT-0001ge-So for submit@debbugs.gnu.org; Wed, 30 Jun 2021 06:48:20 -0400 Received: from mailrelay.tugraz.at ([129.27.2.202]:1409) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lyXlP-0001gR-AU for 49284@debbugs.gnu.org; Wed, 30 Jun 2021 06:48:19 -0400 Received: from nijino.local (62-116-34-49.adsl.highway.telekom.at [62.116.34.49]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4GFJ3J0dhwz1LZVs; Wed, 30 Jun 2021 12:48:12 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 mailrelay.tugraz.at 4GFJ3J0dhwz1LZVs DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1625050092; bh=2gCnyccYxLTHg+nAUEd7VfAYJbbBug/oz26uHCPg86M=; h=Subject:From:To:Date:In-Reply-To:References:From; b=o14OxVZQ9U+C88ytzA5gC+cMzj/780MV6VwGM5dlU3rZmRJ4ukMX1qtZ6a8PpMAot HVzu5iE/bDaVGtYTwTRin0MJoYq2/J+xR5UV6SxfKVNwvV0EEHyFNBSAjo5d6Zn7fr 20pceegYjXzJEEr/bNt5luJA/dEpi2KvMcWM0Z0I= Message-ID: From: Leo Prikler Date: Wed, 30 Jun 2021 12:48:11 +0200 In-Reply-To: <871r8jvekq.fsf@trop.in> References: <871r8jvekq.fsf@trop.in> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-TUG-Backscatter-control: bt4lQm5Tva3SBgCuw0EnZw X-Spam-Scanner: SpamAssassin 3.003001 X-Spam-Score-relay: -1.9 X-Scanned-By: MIMEDefang 2.74 on 129.27.10.116 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1625050156; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=2gCnyccYxLTHg+nAUEd7VfAYJbbBug/oz26uHCPg86M=; b=hC245gbeV4J1mshlN0bUVZQbkIrikATlbl4rbIQrJkxj+Z/gNwQy0cspIanau6nRt6I+hg hkI4bNxW5eyFe8tI+Q/fFDiFJbVz3m0OUVNmxaImNtlcj5mB6kSmX9SOd4+9jw9xdY7bWm uvoRtnpCV8AqFeCCeqsvu1F+jjf/uk1Jh8smuvXBtXTIgXkKa7U04eqRQEYB9ziwEQiUfy 8d2RtNkC2GBnggF9mdPQJlk4LglGvHy/mxzlPAyHy/7KNvbfth+4eMIq178w+XXYsUgCeQ 31ffAPUSTgnPkD40GOLQt77PfrocMJ91ecQfA03qvGVeTh8gHNEIMqNp1zJKUQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1625050156; a=rsa-sha256; cv=none; b=MVhpwTXRKsdxF5jYSrzem+Pmy9riIKPEnqY5OtZVtqsMpY7gkY3ixfmUxELbOmKOYX706T YAB17XIpECN362pWcClTD6jhuonM+TExSt2MTBHozaknV1pTVk7hj29iDSouiSl9t4pduD riNmDvIMaOLIx6PPgBYIv7Jq7rQ7vuXn50w09SMvdot46Y3mj/egLPR72CVhMKZb71ndZa S9uVonAaT8iwXNNdjY+kqlwXyyr/C7ArbET821INVz4tc4wfYw2rcBAg5Pz1CSI2oBhsJF 57b8O1SeUefUnBIIxeqfWkLJXaMhdnyii95L6gwz4qG2ODHZBnc/01jVYVCyAA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tugraz.at header.s=mailrelay header.b=o14OxVZQ; dmarc=fail reason="SPF not aligned (relaxed)" header.from=student.tugraz.at (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.32 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tugraz.at header.s=mailrelay header.b=o14OxVZQ; dmarc=fail reason="SPF not aligned (relaxed)" header.from=student.tugraz.at (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 95F7E12C76 X-Spam-Score: -1.32 X-Migadu-Scanner: scn1.migadu.com X-TUID: vII8UMkHxpBQ Am Mittwoch, den 30.06.2021, 13:20 +0300 schrieb Andrew Tropin: > Leo Prikler writes: > > > Am Mittwoch, den 30.06.2021, 08:49 +0300 schrieb Andrew Tropin: > > > * gnu/packages/games.scm (fheroes2): New variable. > > > --- > > > There are no tests in the project, so they are disabled. > > #:tests? #f should always be documented inside the code > > > gnu/packages/games.scm | 30 ++++++++++++++++++++++++++++++ > > > 1 file changed, 30 insertions(+) > > > > > > diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm > > > index 83cb738b9c..7a87123df3 100644 > > > --- a/gnu/packages/games.scm > > > +++ b/gnu/packages/games.scm > > > @@ -12511,3 +12511,33 @@ wreckage. You're stranded on a desert > > > island and have to survive. In order to > > > do so you need to explore the island, find food, build a shelter > > > and > > > try to > > > get attention, so you get found.") > > > (license license:cc-by4.0)))) > > > + > > > +(define-public fheroes2 > > > + (package > > > + (name "fheroes2") > > > + (version "0.9.4") > > > + (build-system cmake-build-system) > > > + (arguments > > > + `(#:tests? #f > > Add a comment here along the lines of "no tests" or "no check > > target". > > > + #:make-flags '("FHEROES2_STRICT_COMPILATION=1" > > > + "RELEASE=1"))) > > > + (native-inputs > > > + `(("gettext" ,gettext-minimal))) > > > + (inputs > > > + `(("zlib" ,zlib) > > > + ("libpng" ,libpng) > > > + ("sdl" ,(sdl-union (list sdl2 sdl2-image sdl2-mixer sdl2- > > > ttf))))) > > > + (source (origin > > > + (method git-fetch) > > > + (uri (git-reference > > > + (url "https://github.com/ihhub/fheroes2") > > > + (commit version))) > > > + (file-name (git-file-name name version)) > > > + (sha256 > > > + (base32 > > > + "0a3xi3k7ngp0byhmg7wq22l1hix3jwr68prk2y6frqhzbfs > > > krvy > > > g")))) > > > + (home-page "https://ihhub.github.io/fheroes2/") > > > + (synopsis "Turn-based strategy game engine") > > > + (description "Free implementation of Heroes of Might and > > > Magic > > > II (aka > > > +HOMM2) game engine.") > > > + (license license:gpl2))) > > The description is a bit lacking in information. Is this engine > > usable? If so, how? We ought not to steer users towards non-free > > software. > > Yep, it's usable. It requires game resources (assets like music, > maps, > sprites), the assets from original game is not distributed with it > because of legal reasons I suppose, but AFAIK nothing stops people > from > creating their own set of assets to use with this game engine. Also, > taking only assets from original game and using them with this engine > will help people not to use unfree software. > > Added comment, updated description. Without a package providing those assets, this is still pretty much "here, go seek out this nonfree software thingy for assets". This is not to say, that we can never ever ship fheroes2, but I'd personally hold back on it until we can package some fheroes2-data to make it useful without requiring people seek out these assets. This is just my own opinion however, and it's certainly not reflected all over guix source. For instance, both oshu and stepmania require beatmaps and stepfiles respectively to be useful and ship without them while most of what you'll find online will be somewhat dubious in terms of copyright. However, both also offer the tools to create those using your own (hopefully GPL-compatible) album collection, so it's not a big problem. I don't think fheroes2 has that low of an entry barrier to full playability, does it?