From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id ODntFPl4E2W0mQAAauVa8A:P1 (envelope-from ) for ; Wed, 27 Sep 2023 02:36:09 +0200 Received: from aspmx1.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id ODntFPl4E2W0mQAAauVa8A (envelope-from ) for ; Wed, 27 Sep 2023 02:36:09 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E7DE4329CC for ; Wed, 27 Sep 2023 02:36:08 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=posteo.net header.s=2017 header.b=ITFxBGY7; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (strict)" header.from=posteo.net (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1695774969; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=vf+DDlfqO0EMcfpBSnMwIkbk4WcYbJ9DS9DJD+PvXbA=; b=Q8ExJd50aEfji4v53wAPPCp/0U4Kvvapqhz88mEAliqhjJyhzH3IJwFQFsCa97UVMwNKuG R+yx9R/x6CTK8ovWlwDkJ2pNaUlubjF8qmqgqzG0UX+Z1MEy2uH+353/UfO4FCErGTauxh bdwPu9c7aFBa2Z/VqNmzZN9UjmENiyeXTUuGFhTB8NI3H3dvIwxZElh4uJ2ubHqGpaOX8S DW4QNXOhV4gC8OWPoOFboX2FUsS/gg6exgC13i5i33Hm/MbatRH+V9YJ679kfBHzPbnDOc BpmZptZtt7GHc21Q9WygJ9pzT5PjJqdGSrddb8kdPHnRDJjkCDTbLEDOnPWeNQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=posteo.net header.s=2017 header.b=ITFxBGY7; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (strict)" header.from=posteo.net (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1695774969; a=rsa-sha256; cv=none; b=lei3sSacJ/MaMDUJ7m6YdbQe0SUNF84PyNj84La98+SfLSM6iug3U2ULX1wpA58lwTFAlP ZXUv+Dba4X5ucO4fzKGJ/X+YBM2IXs6Ko+LtXaBBRq0Nr6b+kXaakI9Gx+7CjL2I/8ipKF SRRspF5TLwf+xFuNoxqAkp0uLGwDjpZOSCfsRU4frCCkhkCYsAnPebiG0TWNjqvXE+J9vT fSRSxZuh9rifs0sggjT3LL/kt0EcYxiIAvgSVQRygw/kt+jI4DUSDqjxi9WQsvYr7ZEujq bM628uhy8CL2DlXWODEX5XSJLCi/i0NGBq8RUtJZDHaZysyqiUsUnl20q4FF7Q== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qlIX1-0008Bq-PI; Tue, 26 Sep 2023 20:35:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qlIWs-0008B3-PB for guix-patches@gnu.org; Tue, 26 Sep 2023 20:35:52 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qlIWr-00071r-Km for guix-patches@gnu.org; Tue, 26 Sep 2023 20:35:50 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qlIX4-00038B-H7 for guix-patches@gnu.org; Tue, 26 Sep 2023 20:36:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#66199] [PATCH] gnu: librepcb: Update to 1.0.0. Resent-From: Vinicius Monego Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 27 Sep 2023 00:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66199 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: pinoaffe Cc: 66199@debbugs.gnu.org Received: via spool by 66199-submit@debbugs.gnu.org id=B66199.169577494112004 (code B ref 66199); Wed, 27 Sep 2023 00:36:02 +0000 Received: (at 66199) by debbugs.gnu.org; 27 Sep 2023 00:35:41 +0000 Received: from localhost ([127.0.0.1]:50106 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qlIWi-00037Y-Rk for submit@debbugs.gnu.org; Tue, 26 Sep 2023 20:35:41 -0400 Received: from mout02.posteo.de ([185.67.36.66]:50391) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qlIWf-00037F-U8 for 66199@debbugs.gnu.org; Tue, 26 Sep 2023 20:35:39 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 308EC240101 for <66199@debbugs.gnu.org>; Wed, 27 Sep 2023 02:35:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1695774918; bh=y/zrI7ynDApVhAPSVxwUSjpG8BNcHKL+dOU5U2/TWDU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:From: Content-Transfer-Encoding:From; b=ITFxBGY7YpmgwXLr6nZs3o5nU5Gh/3U7gEUhDN37vLevfYKfT0/ykxN8LEtYOszEn wRcR3euANz4hKv8J//eklSFDCAMnefzymBhCi48xlkp0SMeysZHUJ+FufkZ9yCvZ43 8QnL5q/oK7RFtSSn0KnG5bD1MKWFvO/78e9UOdqxi1p/gyLKYZM0HXuZ6yaUI6Zrpo EgMj7M0w1m4tcVhpgE5G1jucvxRSjF9qYMAHMzUvIbLzNWI+TWk7+wkXdNHO35q2g9 h8o+a6A4fHnyq58tZ5YHX3M/+uDKIM84zLnu5uXCDfFVJbVq76d+lakBN/53aYlSy3 Gx0JCizx15hSQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4RwHh43wB3z9rxT; Wed, 27 Sep 2023 02:35:16 +0200 (CEST) Message-ID: Date: Wed, 27 Sep 2023 00:35:14 +0000 MIME-Version: 1.0 Content-Language: en-US References: <3e28337e7ead18b49e5e2e99d0e3d1d22e3f9d47.1695673614.git.pinoaffe@gmail.com> <2f4f0210-ea10-27e0-55fc-ccd55e807576@posteo.net> <87h6nhdtbh.fsf@gmail.com> From: Vinicius Monego In-Reply-To: <87h6nhdtbh.fsf@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -5.11 X-Migadu-Scanner: mx2.migadu.com X-Migadu-Queue-Id: E7DE4329CC X-Spam-Score: -5.11 X-TUID: pDW6bgzhMZUa Em 26/09/2023 09:08, pinoaffe escreveu: > Hi, Hi! > thank you for your review! > > Vinicius Monego writes: >> The commit message should also mention the switch to >> cmake-build-system, the "not overriding" of the configure phase, the >> new inputs and the test skip.. > I wasn't sure how to phrase / format this, is what I arrived at OK? You can check the logs of e.g. commit 19617735df2b1af3b169d8153ae543ad3e0fc1a1 for reference. >> Inputs should be sorted alphabetically. > Done > 'googletest' should be a native input, it's a test requirement only. [...] > I'll send some updated patches in a minute > > Kind regards, > pinoaffe [Comment on the LibrePCB update patch specifically]: This v2 is much better, thanks. While investigating the build I also found a few more things that could be improved: - The bundles that were unvendored can be deleted in a source snippet (see e.g. the mixxx package). - LibrePCB builds a test executable at tests/unittests/librepcb-unittests. Instead of 'make test', that file could be run manually when overriding the check phase. - The license list should be updated as some of the bundles listed there are not being provided anymore, or even better let it be only gpl3+ because that's the license of the final product. - I got two merge conflicts on 06dc36ffb7cde821a4762b299d1c95b3788ba110, please rebase it to the latest commit. If the tests are too problematic that's fine, I can merge this patch with the other changes later this week. Vinicius