From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 4BreIQs55mBOxgAAgWs5BA (envelope-from ) for ; Thu, 08 Jul 2021 01:30:19 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id SLuTHQs55mCKMwAAB5/wlQ (envelope-from ) for ; Wed, 07 Jul 2021 23:30:19 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E7AD820236 for ; Thu, 8 Jul 2021 01:30:18 +0200 (CEST) Received: from localhost ([::1]:52820 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m1Gzh-0001Dk-Tb for larch@yhetil.org; Wed, 07 Jul 2021 19:30:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55884) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m1GzS-0001Dc-R7 for guix-patches@gnu.org; Wed, 07 Jul 2021 19:30:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:42188) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m1GzS-0005Se-J1 for guix-patches@gnu.org; Wed, 07 Jul 2021 19:30:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1m1GzS-00086O-Aj for guix-patches@gnu.org; Wed, 07 Jul 2021 19:30:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#47910] [PATCH] gnu: python-wtforms: Update to 2.3.3. References: <432e457285cdabe78e9db89f760a387c@dismail.de> In-Reply-To: <432e457285cdabe78e9db89f760a387c@dismail.de> Resent-From: Vinicius Monego Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 07 Jul 2021 23:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47910 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 47910@debbugs.gnu.org Received: via spool by 47910-submit@debbugs.gnu.org id=B47910.162570058031094 (code B ref 47910); Wed, 07 Jul 2021 23:30:02 +0000 Received: (at 47910) by debbugs.gnu.org; 7 Jul 2021 23:29:40 +0000 Received: from localhost ([127.0.0.1]:53734 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m1Gz6-00085S-55 for submit@debbugs.gnu.org; Wed, 07 Jul 2021 19:29:40 -0400 Received: from mout02.posteo.de ([185.67.36.66]:55061) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m1Gz2-00085B-C1 for 47910@debbugs.gnu.org; Wed, 07 Jul 2021 19:29:39 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id E3A152400E5 for <47910@debbugs.gnu.org>; Thu, 8 Jul 2021 01:29:29 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1625700569; bh=El2uJev5yoA//DGUNKz2oxpInKPckWrZqOUV7S959fI=; h=Subject:From:To:Date:From; b=gCvDUC9A+UsBRTiI+0ybaIgv67xe2YQX6M899Z+kOV0JZhC/OltdfaRdR24kan/Wg m4vF6mAk9Col4CR16q8z4qGWdFfQvGzeg1s1UlNCvIVmTKYT0NKLJiaBmsdzMQZ6dT GWzOTbrWL8IKVYTT1M4NUnKkaghPH5iOUhe0eCX/fS8YSxRWlPNlr1LzWsJvrjxcLj pCBJculdtifQD8yPHCGAgsqtyPnUWVoZkbsDgBiSTLsfbkThk4zlX7VNyy4b4l0Yyd jYFCczQr3gOjhm62IKsFSYfTv+J8E6aAOY2XR+5+D0aNzkWZON9vxUkXmzLlHf+Jzu W2ReOP4Xz+YvA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4GKwcS4Rwqz6tm6 for <47910@debbugs.gnu.org>; Thu, 8 Jul 2021 01:29:28 +0200 (CEST) Message-ID: From: Vinicius Monego Date: Wed, 07 Jul 2021 23:29:10 +0000 Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1625700619; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=El2uJev5yoA//DGUNKz2oxpInKPckWrZqOUV7S959fI=; b=TRRdw2ZjiYNRbx8egQ5vOVY1KZns4nhhYDyll0u+oGkZAyngrd0ykwBrk7/toLE/IHchHe G90cf0js1aN76dcnpyHQz5zAOIuWRYsUr3KzpwmTupZdu5gVCBEQwIALy5fxVIQHoH3uBE cYPN3avZp/9XYEg6GMaHX2YXVcz8xq7hPnJRjxBVqlf6xmjszex8eTlY+4uJ/9mVDJSEoJ 5ShfUpF5TKU0jJ2Dcy/B28Zx5n4+t/IW7qG2UI/yu37JQgPt3nNzKkNtYVIaT3knmktMSb cUG/0J9jC2lBuybYwRfQWwafZLd+npbIQUf/Jian45VqVsThJUiOVfQLgm6VGg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1625700619; a=rsa-sha256; cv=none; b=CxiFnM8WnrppojZF4GKYSop/rk8vMQBbIw5KvEjBj7Lc5OdjLl3oI1JrNUzcq6mPfTeGP5 XrITsl0IaUiceAuyoIqeLhuqzxpUQ9BrjJO1RATEzHmp66dMWe+MVNUmo7aOR5kgn1jybj 6bBYBdMy506lgEU4WzTbGTCUlqUmjEaavK2sjHcSdDVt3/FVAJc+nnVIUW5QDn9wdnIpZ0 jUC+nMMd8Osiy0COr9HwlhtIGU/b4+4xc5PBhK4DhoYzRjAUw4kXW4ZpDKQYveAlY/rHPp sbkBQwCS+15m9eWp3FCjy2iPsN/jsu6LZ9Nw6VSPagBWZUhATphNcJNlXxR6Tg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=posteo.net header.s=2017 header.b=gCvDUC9A; dmarc=fail reason="SPF not aligned (strict)" header.from=posteo.net (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.31 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=posteo.net header.s=2017 header.b=gCvDUC9A; dmarc=fail reason="SPF not aligned (strict)" header.from=posteo.net (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: E7AD820236 X-Spam-Score: -1.31 X-Migadu-Scanner: scn1.migadu.com X-TUID: BcBY36jmPQ+r Hi, > I have not been able to successfully run all the tests without using > tox manually. [...] > What is the consensus for using tox with guix? Tox is an environment manager. As such, it is redundant in Guix. Tox is not a hard requirement for tests in any project. You can inspect the tox.ini file that is shipped in projects. This is the tox.ini from wtforms, in the 2.3.3 tag: [1]. Note that the test command that tox will run is: > python setup.py compile_catalog > coverage run tests/runtests.py --with-pep8 After running these commands in the custom check phase, I could succesfully run the tests. I also added python-sqlalchemy and python- dateutil to native-inputs. Note that it requires django<1.7 which we don't have, but it's optional. It seems that the testing command will change again in version 3 to a standard pytest call and the legacy dependencies will be removed [2] (also see tox.ini in the master branch). > python-hy is also broken (it depends on python-funcparserlib and > fails because of it) funcparserlib is broken because version 0.3.6 is compatible with only up to Python 3.5 (it was released in 2013). There should be a 1.0.0 release this year [3] and it doesn't seem that 0.3.6 can be fixed from our side. It does not depend on tox either. Once 1.0.0 is released and packaged, tox can be removed and it should run without replacing the check phase (it uses unittest). Tox is still there because that package is currently stagnating. Vinicius [1] https://github.com/wtforms/wtforms/blob/2.3.3/tox.ini [2] https://github.com/wtforms/wtforms/commit/c49ecfb7e76f919eafb5c6a11c3b795c4e613757 [3] https://github.com/vlasovskikh/funcparserlib/issues/65