From: phodina via Guix-patches via <guix-patches@gnu.org>
To: 49576@debbugs.gnu.org
Subject: [bug#49576] [PATCH] Add sterm
Date: Sat, 17 Jul 2021 10:50:10 +0000 [thread overview]
Message-ID: <cQDKVJqFNB3X3xT28uPfYxrOeFDKCeG9N-d5LuEBkyB_YDeZ9gdbjZWHZucyrAFxPxd6k9kfqRk4_1Yxlj8LckNds-MAxjBBn6DP9Abs4xI=@protonmail.com> (raw)
In-Reply-To: <OSZP286MB06643687F4E7D1BAFEFB92C8A3119@OSZP286MB0664.JPNP286.PROD.OUTLOOK.COM>
Hi iyzsong!
here is the patch with the changes as you suggested.
> Doesn't the builtin Makefile works? It also install a man page and
>
> shell completion files.
Unfortunately, the Makefile tries to install the binary under /usr
> I think "PREFIX=$out" is no effect here, also instead of 'gcc' you can
>
> use 'cc-for-target' for cross-compile support, examples can be found in
>
> suckless.scm:
I made the changes as you suggested but now I get the error due to 'cc-for-target':
/gnu/store/gqp3fqgb9h5l7ibzvsnqkv6gahy3r97i-sterm-20200306-guile-builder:1:2534: unquote: expression not valid outside of quasiquote in form (unquote (cc-for-target))
Could you help me fix that? Thanks
---
index 4429a2b75a..4ffb6060fe 100644
--- a/gnu/packages/engineering.scm
+++ b/gnu/packages/engineering.scm
@@ -1297,6 +1297,36 @@ replacement for the OpenDWG libraries.")
(description "@code{minicom} is a serial terminal emulator.")
(license license:gpl2+)))
+(define-public sterm
+(package
+ (name "sterm")
+ (version "20200306")
+ (source (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/wentasah/sterm")
+ (commit version)))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32
+ "031pd8yz2bfzqbari6za1c3xcqmw94ap4vbrjzb3v6izjcrca58c"))))
+ (build-system gnu-build-system)
+ (arguments
+ '(#:tests? #f ; no tests
+ #:make-flags
+ (list (string-append "CC=" ,(cc-for-target))
+ (string-append "PREFIX=" %output))
+ #:phases
+ (modify-phases %standard-phases (delete 'configure))))
+ (synopsis "Simple serial terminal")
+ (description "This is a minimalist terminal program like minicom or cu.
+The only thing it does is creating a bidirectional connection between
+stdin/stdout and a terminal device (e.g. serial line).
+It can also set serial line baudrate, manipulate DTR/RTS modem lines,
+send break and throttle transmission speed.")
+ (home-page "https://github.com/wentasah/sterm")
+ (license license:gpl3+)))
+
(define-public harminv
(package
(name "harminv")
--
2.31.1
‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On Friday, July 16th, 2021 at 3:03 PM, 宋文武 <iyzsong@outlook.com> wrote:
> Hello!
>
> phodina phodina@protonmail.com writes:
>
> > index 4429a2b75a..a6f866cbea 100644
> >
> > --- a/gnu/packages/engineering.scm
> >
> > +++ b/gnu/packages/engineering.scm
> >
> > @@ -24,6 +24,7 @@
> >
> > ;;; Copyright © 2021 qblade qblade@protonmail.com
> >
> > ;;; Copyright © 2021 Gerd Heber gerd.heber@gmail.com
> >
> > ;;; Copyright © 2021 Guillaume Le Vaillant glv@posteo.net
> >
> > +;;; Copyright © 2021 Petr Hodina phodina@protonmail.com
> >
> > ;;;
> >
> > ;;; This file is part of GNU Guix.
> >
> > ;;;
> >
> > @@ -1297,6 +1298,35 @@ replacement for the OpenDWG libraries.")
> >
> > (description "@code{minicom} is a serial terminal emulator.")
> >
> > (license license:gpl2+)))
> >
> > +(define-public sterm
> >
> > +(package
> >
> > - (name "sterm")
> > - (version "20200306")
> > - (source (origin
> > - (method git-fetch)
> >
> >
> > - (uri
> >
> >
> > - (git-reference
> >
> >
> > - (url "https://github.com/wentasah/sterm")
> >
> >
> > - (commit version)))
> >
> >
>
> The indention seems wrong here, we usually use:
>
> --8<---------------cut here---------------start------------->8---
>
> (source (origin
> (method git-fetch)
> (uri (git-reference
> (url "...")
> (commit ...)))
> (file-name (git-file-name name version))
> (sha256
> (base32
> "..."))))
>
>
> --8<---------------cut here---------------end--------------->8---
>
> Also a 'file-name' field is needed to get a better store directory name
>
> for the checkout.
>
> > - (sha256
> >
> >
> > - (base32
> >
> >
> > - "031pd8yz2bfzqbari6za1c3xcqmw94ap4vbrjzb3v6izjcrca58c"))))
> >
> >
> > - (build-system gnu-build-system)
> > - (arguments
> > - '(#:tests? #f
>
> When disable tests, we should add a comment, a simple "no tests" will
>
> do.
>
> > - #:make-flags (list "PREFIX=$out" "CC=gcc")
> >
> >
>
> I think "PREFIX=$out" is no effect here, also instead of 'gcc' you can
>
> use 'cc-for-target' for cross-compile support, examples can be found in
>
> suckless.scm:
>
> --8<---------------cut here---------------start------------->8---
>
> #:make-flags
> (list (string-append "CC=" ,(cc-for-target))
> (string-append "PREFIX=" %output))
>
>
> --8<---------------cut here---------------end--------------->8---
>
> > - #:phases (modify-phases %standard-phases
> >
> >
> > - (delete 'configure)
> >
> >
> > - (replace 'install
> >
> >
> > - (lambda* (#:key outputs #:allow-other-keys)
> >
> >
> > - (let ((bin (string-append (assoc-ref outputs "out") "/bin")))
> >
> >
> > - (install-file "sterm" bin)
> >
> >
> > - #t))))))
> >
> >
>
> Doesn't the builtin Makefile works? It also install a man page and
>
> shell completion files.
>
> > - (synopsis "Simple serial terminal")
> > - (description "This is a minimalist terminal program like minicom or cu. The only thing it does is creating a bidirectional connection between stdin/stdout and a terminal device (e.g. serial line). It can also set serial line baudrate, manipulate DTR/RTS modem lines, send break and throttle transmission speed.")
>
> Please keep lines below 80 characters, and use two spaces between
>
> the two sentences.
>
> > - (home-page "https://github.com/wentasah/sterm")
> > - (license #f)))
>
> According to the files, the license is GPLv3+.
>
> Could you send an update patch? Thank you!
next prev parent reply other threads:[~2021-07-17 10:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-15 16:17 [bug#49576] [PATCH] Add sterm phodina via Guix-patches via
2021-07-16 13:03 ` 宋文武
2021-07-17 10:50 ` phodina via Guix-patches via [this message]
2021-07-17 11:41 ` Tobias Geerinckx-Rice via Guix-patches via
2021-07-17 12:08 ` phodina via Guix-patches via
2021-07-18 9:42 ` bug#49576: " 宋文武
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='cQDKVJqFNB3X3xT28uPfYxrOeFDKCeG9N-d5LuEBkyB_YDeZ9gdbjZWHZucyrAFxPxd6k9kfqRk4_1Yxlj8LckNds-MAxjBBn6DP9Abs4xI=@protonmail.com' \
--to=guix-patches@gnu.org \
--cc=49576@debbugs.gnu.org \
--cc=phodina@protonmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).