unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: jaeme via Guix-patches via <guix-patches@gnu.org>
To: 66694@debbugs.gnu.org
Cc: me@tobias.gr
Subject: [bug#66694] Revision
Date: Sun, 29 Oct 2023 02:16:03 -0400	[thread overview]
Message-ID: <c90f6525-fcce-4006-be25-d65c84e6cdfc@runbox.com> (raw)
In-Reply-To: <20231023051055.1470319-1-jaeme@runbox.com>

Hello T,


T wrote:

 > We don't sign off on our own patches in Guix. Our Signed-off-by does 
not have the same DCO meaning as it does for, e.g., Linux. Ours is 
merely a stamp of approval by a committer.

I see, I do wish I knew that earlier before sending my other patches. 
Maybe that should be written somewhere in the Contributing section of 
the Guix manual because I have my ~/.gitconfig automatically add the 
signed-off line to all my commits. Thank you for mentioning that.


T wrote:

 > Apparently the copy-build-system doesn't acknowledge the existence of 
cross compilation, like, at all?

That not surprisingly went over my head. Can you tell me how you 
discovered that? I would like to know.


T wrote:

 > ...you don't want the  script calling the build-time ‘native’ grep at 
run time.

Noted (still learning lots').


T wrote:

 > I also added bash-minimal at ‘guix lint’'s suggestion.

I also saw that suggestion but I didn't add it since I already had 
coreutils which in my mind eclipsed bash-minimal.


T wrote:

 > we conventionally put fields in this order:

Duly Noted.


T wrote:

 > Here's a random Deep Guix Thing that I'm too tired to explain further:

I remember reading about 'search-native-paths' in a Guix blog, I'm glad 
the --pure situation is cleared up.


T wrote:

 > I do wonder: just how legal is this script, and the one Web site to 
which it's tightly bound?

 From looking at <https://repology.org/project/ani-cli/versions> for the 
other third-party packagers: Debian, Ubuntu, Gentoo as well as nixpkgs 
have this script in their repositories. In addition, disclaimer.md 
posits that ani-cli can be thought of as a browser/wrapper rather than 
being a direct source for copyrighted content. We don't know when the 
website(s) will stop working but we can assume that the script will be 
updated as well as it's fairly active and popular in the GNU/Linux 
world. But to offer a more principled rebuttal, yt-dlp also has this 
similar issue of relying on a nonfree, non-federated network service 
(google videos/YouTube). However, one of the niches of yt-dlp is that it 
offers a way for users to stream/download videos hosted on YouTube 
without having to load the proprietary JS through their web browser. 
This package could serve a similar purpose to guix users as it's much 
safer to stream content directly rather than having to connect to and 
load the website (if it is possible at all with GNU Icecat) via web 
browser.


On a side note, this is my first time interacting with a mailing 
list/submitting patches. I have a lot of growing pains to get through.


Thanks,

Jaeme








  parent reply	other threads:[~2023-10-29  6:17 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-23  5:10 [bug#66694] [PATCH] gnu: Add ani-cli Jaeme Sifat via Guix-patches via
2023-10-26 20:36 ` [bug#66694] Revised Patch jaeme via Guix-patches via
2023-10-26 23:48 ` [bug#66694] (no subject) jaeme via Guix-patches via
2023-10-28 22:46 ` [bug#66694] [PATCH] gnu: Add ani-cli Tobias Geerinckx-Rice via Guix-patches via
2023-10-29  6:16 ` jaeme via Guix-patches via [this message]
2023-11-14 18:00 ` [bug#66694] Update on ani-cli? Jaeme Sifat via Guix-patches via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c90f6525-fcce-4006-be25-d65c84e6cdfc@runbox.com \
    --to=guix-patches@gnu.org \
    --cc=66694@debbugs.gnu.org \
    --cc=jaeme@runbox.com \
    --cc=me@tobias.gr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).