unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Liliana Marie Prikler <liliana.prikler@ist.tugraz.at>
To: Vivien Kraus <vivien@planete-kraus.eu>, 56504@debbugs.gnu.org
Subject: [bug#56504] [PATCH] Mingw support for zlib
Date: Wed, 13 Jul 2022 07:49:17 +0200	[thread overview]
Message-ID: <c8697df7788f2ad06ed07296f627b59b939cdc01.camel@ist.tugraz.at> (raw)
In-Reply-To: <29fa1e573d51f351796ba22d7344d9738d71c9be.camel@planete-kraus.eu>

Am Dienstag, dem 12.07.2022 um 18:45 +0200 schrieb Vivien Kraus:
> Le mardi 12 juillet 2022 à 08:07 +0200, Liliana Marie Prikler a
> écrit :
> > Am Dienstag, dem 12.07.2022 um 01:53 +0200 schrieb Vivien Kraus:
> > 
> > > +               ,@(if (and (%current-target-system)
> > > +                          (string-suffix? "-w64-mingw32"
> > > (%current-
> > > target-system)))
> > I'm pretty sure there's an abbreviation for this like target-mingw?
> Precisely! Fixed it, thank you.
> 
> > > +                     `((substitute* "win32/Makefile.gcc"
> > > +                         (("PREFIX =")
> > > +                          (string-append "PREFIX = " ,(%current-
> > > target-system) "-"))
> > > +                         (("prefix \\?= /usr/local")
> > > +                          (string-append "prefix ?= " out))
> > > +                         (("# BINARY_PATH, INCLUDE_PATH and
> > > LIBRARY_PATH must be set.")
> > > +                          "\
> > > +BINARY_PATH = $(prefix)/bin
> > > +INCLUDE_PATH = $(prefix)/include
> > > +LIBRARY_PATH = $(prefix)/lib"))
> > > +                       (rename-file "win32/Makefile.gcc"
> > > "Makefile"))
> > I think these can be conditionally added to #:make-flags
> I did it for all but prefix, because I have to have the output path.
> Is there a way to get it from within the make-flags?
With the gexp-style you'd write #$output, otherwise ,(assoc-ref %build-
outputs "out").

> > > +                     `((invoke "./configure"
> > > +                               (string-append "--prefix="
> > > out)))))))
> > 
> > > +         ,@(if (and (%current-target-system)
> > > +                    (string-suffix? "-mingw32" (%current-target-
> > > system)))
> > > +               `(add-after 'install 'install-mingw-shared
> > > +                  (lambda* (#:key make-flags #:allow-other-keys)
> > > +                    (apply invoke "make"
> > > +                           (append make-flags
> > > +                                   '("install"
> > > "SHARED_MODE=1")))))
> > SHARED_MODE might likewise be conditionally added to #:make-flags.
> I get both the DLL loader and the DLL in the default output, and the
> static lib in the static output, so it works.
Oh, so you mean the static output should be built without SHARED_MODE?


Cheers




  reply	other threads:[~2022-07-13  5:50 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-11 23:53 [bug#56504] [PATCH] Mingw support for zlib Vivien Kraus via Guix-patches via
2022-07-12  6:07 ` Liliana Marie Prikler
2022-07-12 16:45   ` Vivien Kraus via Guix-patches via
2022-07-13  5:49     ` Liliana Marie Prikler [this message]
2022-07-13 15:19       ` Vivien Kraus via Guix-patches via
2022-07-14  6:01         ` Liliana Marie Prikler
2022-07-15 14:28           ` Vivien Kraus via Guix-patches via
2022-07-15 14:30             ` Liliana Marie Prikler
2022-07-19 21:07               ` Ludovic Courtès
2022-07-31 11:21                 ` bug#56504: " Liliana Marie Prikler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c8697df7788f2ad06ed07296f627b59b939cdc01.camel@ist.tugraz.at \
    --to=liliana.prikler@ist.tugraz.at \
    --cc=56504@debbugs.gnu.org \
    --cc=vivien@planete-kraus.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).