From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:35633) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iEa8G-0000Lw-95 for guix-patches@gnu.org; Sun, 29 Sep 2019 10:25:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iEa8E-0001w6-PW for guix-patches@gnu.org; Sun, 29 Sep 2019 10:25:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:46578) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iEa8E-0001vs-Lu for guix-patches@gnu.org; Sun, 29 Sep 2019 10:25:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iEa8E-0006ey-FG for guix-patches@gnu.org; Sun, 29 Sep 2019 10:25:02 -0400 Subject: [bug#37465] add xftwidth displayed textwidth calculator package Resent-Message-ID: Message-ID: From: Kyle Andrews Date: Sun, 29 Sep 2019 10:24:32 -0400 In-Reply-To: <87wodwlcwf.fsf@gnu.org> References: <4e2e655c245cfc810b0faaf4c63b8fd99b384269.camel@gmail.com> <87wodwlcwf.fsf@gnu.org> Content-Type: multipart/mixed; boundary="=-nbFVg6+8Lj4Rr+JhHgj+" Mime-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 37465@debbugs.gnu.org --=-nbFVg6+8Lj4Rr+JhHgj+ Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Hi Ludo, On Wed, 2019-09-25 at 15:32 +0200, Ludovic Courtès wrote: > Hello Kyle, > > Kyle Andrews skribis: > > > From 60deaa526b4a6ca5a66f3b67ba77aa353409d542 Mon Sep 17 00:00:00 > > 2001 > > From: Kyle Andrews > > Date: Thu, 19 Sep 2019 20:16:28 -0400 > > Subject: [PATCH] gnu: Add xftwidth. > > > > * gnu/packages/wm.scm: added xftwidth package. > > I think this should rather go to xdisorg.scm, WDYT? That makes sense to me. I have added fontutils as an additional module dependency in xdisorg.scm to satisfy the inputs. > > + (build-system gnu-build-system) > > + (inputs `(("freetype" ,freetype) > > + ("libx11" ,libx11) > > + ("fontconfig" ,fontconfig) > > + ("libxft" ,libxft))) > > Nitpicking: we don’t usually align input tuples like that. :-) > Okay. I've removed the alignment. However, note that the dzen package in xdisorg.scm uses this same aligned format for it's inputs. > > + (synopsis "Calculator for determining displayed text widths > > using Xft fonts.") > > + (description "A small C program to calculate pixel widths for > > displayed > > +text using Xft fonts (given a specific font name and size). It is > > ideal for > > +scripts including text into the custom (e.g. dzen and xmobar > > based) panels > > +often used in conjunction with minimalistic window managers.") > > Could you address the warnings reported by ‘guix lint’ here? Also, > make > sure to write full sentences in the description: > > https://guix.gnu.org/manual/en/html_node/Synopses-and-Descriptions. > html > The rest LGTM! Could you send an updated patch? > > Thanks, > Ludo’. I've fixed the notes I saw from guix lint: 1. https -> http for github urls 2. Removed period from synopsis 3. Rewrote the description using full sentences Please see the attached patch. Regards, Kyle --=-nbFVg6+8Lj4Rr+JhHgj+ Content-Disposition: attachment; filename="0001-gnu-Add-xftwidth.patch" Content-Type: text/x-patch; name="0001-gnu-Add-xftwidth.patch"; charset="UTF-8" Content-Transfer-Encoding: base64 RnJvbSAxYzIzZWRiOWJkZDdhNzY3ODYzNmM5N2FkMjU2OTk1ZGMzMWMyMmQyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBLeWxlIEFuZHJld3MgPGt5bGUuYy5hbmRyZXdzQGdtYWlsLmNv bT4KRGF0ZTogU3VuLCAyOSBTZXAgMjAxOSAxMDowNjo0OSAtMDQwMApTdWJqZWN0OiBbUEFUQ0hd IGdudTogQWRkIHhmdHdpZHRoLgoKKiBnbnUvcGFja2FnZXMveGRpc29yZy5zY206IGFkZGVkIHhm dHdpZHRoIHBhY2thZ2UuCi0tLQogZ251L3BhY2thZ2VzL3hkaXNvcmcuc2NtIHwgNDIgKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKwogMSBmaWxlIGNoYW5nZWQsIDQyIGlu c2VydGlvbnMoKykKCmRpZmYgLS1naXQgYS9nbnUvcGFja2FnZXMveGRpc29yZy5zY20gYi9nbnUv cGFja2FnZXMveGRpc29yZy5zY20KaW5kZXggMGI0MGNhNjkwOS4uNzllMGY2MTdmZCAxMDA2NDQK LS0tIGEvZ251L3BhY2thZ2VzL3hkaXNvcmcuc2NtCisrKyBiL2dudS9wYWNrYWdlcy94ZGlzb3Jn LnNjbQpAQCAtMjYsNiArMjYsNyBAQAogOzs7IENvcHlyaWdodCDCqSAyMDE4LCAyMDE5IFBpZXJy ZSBOZWlkaGFyZHQgPG1haWxAYW1icmV2YXIueHl6PgogOzs7IENvcHlyaWdodCDCqSAyMDE4IE5h bSBOZ3V5ZW4gPG5hbW5AYmVya2VsZXkuZWR1PgogOzs7IENvcHlyaWdodCDCqSAyMDE5IFdpa3Rv ciDFu2VsYXpueSA8d3plbGF6bnlAdnVydi5jej4KKzs7OyBDb3B5cmlnaHQgwqkgMjAxOSBLeWxl IEFuZHJld3MgPGt5bGUuYy5hbmRyZXdzQGdtYWlsLmNvbT4KIDs7OwogOzs7IFRoaXMgZmlsZSBp cyBwYXJ0IG9mIEdOVSBHdWl4LgogOzs7CkBAIC04Myw2ICs4NCw3IEBACiAgICM6dXNlLW1vZHVs ZSAoZ251IHBhY2thZ2VzIHhtbCkKICAgIzp1c2UtbW9kdWxlIChnbnUgcGFja2FnZXMgZ3RrKQog ICAjOnVzZS1tb2R1bGUgKGdudSBwYWNrYWdlcyB4b3JnKQorICAjOnVzZS1tb2R1bGUgKGdudSBw YWNrYWdlcyBmb250dXRpbHMpCiAgICM6dXNlLW1vZHVsZSAoZ251IHBhY2thZ2VzIGJpc29uKQog ICAjOnVzZS1tb2R1bGUgKGljZS05IG1hdGNoKSkKIApAQCAtMTMyMiw2ICsxMzI0LDQ2IEBAIHBy b2dyYW0gZm9yIFgxMS4gIEl0IHdhcyBkZXNpZ25lZCB0byBiZSBmYXN0LCB0aW55IGFuZCBzY3Jp cHRhYmxlIGluIGFueSBsYW5ndWFnCiAgICAgIChob21lLXBhZ2UgImh0dHBzOi8vZ2l0aHViLmNv bS9yb2JtL2R6ZW4iKQogICAgICAobGljZW5zZSBsaWNlbnNlOmV4cGF0KSkpKQogCisoZGVmaW5l LXB1YmxpYyB4ZnR3aWR0aAorICAocGFja2FnZQorICAgIChuYW1lICJ4ZnR3aWR0aCIpCisgICAg KHZlcnNpb24gIjIwMTcwNDAyIikKKyAgICAoc291cmNlCisgICAgIChvcmlnaW4KKyAgICAgICAo bWV0aG9kIGdpdC1mZXRjaCkKKyAgICAgICAodXJpIChnaXQtcmVmZXJlbmNlCisJICAgICAodXJs ICJodHRwOi8vZ2l0aHViLmNvbS92aXh1czAveGZ0d2lkdGgiKQorCSAgICAgKGNvbW1pdCAiMzVm Zjk2MzkwOGQ0MWE4YTZhNzEwMWM0MzRjODgyNTU3MjgwMjVlZSIpKSkKKyAgICAgICAoc2hhMjU2 CisJKGJhc2UzMgorCSAiMWp3bDI1Nzg1bGkyNGticDBtMXd4ZndrNGRneGtsaXlubjAzbnNqODEz Y2pyMzRrcTE2aCIpKQorICAgICAgIChmaWxlLW5hbWUgKHN0cmluZy1hcHBlbmQgbmFtZSAiLSIg dmVyc2lvbiAiLWNoZWNrb3V0IikpKSkKKyAgICAoYnVpbGQtc3lzdGVtIGdudS1idWlsZC1zeXN0 ZW0pCisgICAgKGlucHV0cyBgKCgiZnJlZXR5cGUiICxmcmVldHlwZSkKKyAgICAgICAgICAgICAg KCJsaWJ4MTEiICxsaWJ4MTEpCisgICAgICAgICAgICAgICgiZm9udGNvbmZpZyIgLGZvbnRjb25m aWcpCisgICAgICAgICAgICAgICgibGlieGZ0IiAsbGlieGZ0KSkpCisgICAgKG5hdGl2ZS1pbnB1 dHMKKyAgICAgYCgoInBrZy1jb25maWciICxwa2ctY29uZmlnKSkpCisgICAgKGFyZ3VtZW50cwor ICAgICAnKCM6cGhhc2VzCisgICAgICAgKG1vZGlmeS1waGFzZXMgJXN0YW5kYXJkLXBoYXNlcwor ICAgICAgICAgKGFkZC1hZnRlciAndW5wYWNrICdmaXgtbWFrZWZpbGUgOyAvdXNyL2JpbiBkb2Vz bid0IHNob3cgdXAgaW4gUEFUSAorICAgICAgICAgICAobGFtYmRhIF8gKHN1YnN0aXR1dGUqICJN YWtlZmlsZSIgKCgidXNyLyIpICIiKSkgI3QpKQorICAgICAgICAgKGRlbGV0ZSAnY2hlY2spIDsg bm8gY2hlY2sgaW5jbHVkZWQgaW4gTWFrZWZpbGUKKyAgICAgICAgIChkZWxldGUgJ2NvbmZpZ3Vy ZSkpCisgICAgICAgIzptYWtlLWZsYWdzCisgICAgICAgKGxldCAoKG91dCAoYXNzb2MtcmVmICVv dXRwdXRzICJvdXQiKSkpCisgICAgICAgICAobGlzdCAoc3RyaW5nLWFwcGVuZCAiREVTVERJUj0i IG91dCkpKSkpCisgICAgKHN5bm9wc2lzICJDYWxjdWxhdG9yIGZvciBkZXRlcm1pbmluZyBwaXhl bCB3aWR0aHMgb2YgZGlzcGxheWVkIHRleHQgdXNpbmcgWGZ0IGZvbnRzIikKKyAgICAoZGVzY3Jp cHRpb24gInhmdHdpZHRoIGlzIGEgc21hbGwgQyBwcm9ncmFtIGZvciBjYWxjdWxhdGluZyB0aGUg cGl4ZWwKK3dpZHRocyBvZiBkaXNwbGF5ZWQgdGV4dCB1c2luZyBYZnQgZm9udHMuIEl0IGlzIGVz cGVjaWFsbHkgdXNlZnVsIGluIHNjcmlwdHMKK2ZvciBkaXNwbGF5aW5nIHRleHQgaW4gZ3JhcGhp Y2FsIHBhbmVscywgbWVudXMsIHBvcHVwcywgYW5kIG5vdGlmaWNhdGlvbgord2luZG93cyBnZW5l cmF0ZWQgdXNpbmcgZHplbi4gVGhlc2Ugc2NyaXB0cyBhcmUgb2Z0ZW4gdXNlZCBpbiBjb25qdW5j dGlvbiB3aXRoCittaW5pbWFsaXN0aWMgdGlsaW5nIHdpbmRvdyBtYW5hZ2VycyBzdWNoIGFzIGhl cmJzdGx1ZnR3bSBhbmQgYnNwd20uIikKKyAgICAoaG9tZS1wYWdlICJodHRwOi8vZ2l0aHViLmNv bS92aXh1czAveGZ0d2lkdGgiKQorICAgIChsaWNlbnNlIGxpY2Vuc2U6ZXhwYXQpKSkKKwogKGRl ZmluZS1wdWJsaWMgeGNiLXV0aWwteHJtCiAgIChwYWNrYWdlCiAgICAgKG5hbWUgInhjYi11dGls LXhybSIpCi0tIAoyLjIzLjAKCg== --=-nbFVg6+8Lj4Rr+JhHgj+--