From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id 0CCBENZI32PKlwAAbAwnHQ (envelope-from ) for ; Sun, 05 Feb 2023 07:12:38 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id 4GqWD9ZI32NyGwAAG6o9tA (envelope-from ) for ; Sun, 05 Feb 2023 07:12:38 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0E2C11010C for ; Sun, 5 Feb 2023 07:12:37 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pOYFx-00058S-P0; Sun, 05 Feb 2023 01:12:05 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pOYFu-00057d-Sw for guix-patches@gnu.org; Sun, 05 Feb 2023 01:12:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pOYFu-0003ZF-KY for guix-patches@gnu.org; Sun, 05 Feb 2023 01:12:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pOYFu-0003Gz-FU for guix-patches@gnu.org; Sun, 05 Feb 2023 01:12:02 -0500 Subject: bug#59866: [PATCH v6 2/3] services: mpd: Refactor MPD service. Resent-From: Liliana Marie Prikler Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Sun, 05 Feb 2023 06:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 59866 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Bruno Victal , 59866-done@debbugs.gnu.org Mail-Followup-To: 59866@debbugs.gnu.org, liliana.prikler@gmail.com, mirai@makinata.eu Received: via spool by 59866-done@debbugs.gnu.org id=D59866.167557747912372 (code D ref 59866); Sun, 05 Feb 2023 06:12:02 +0000 Received: (at 59866-done) by debbugs.gnu.org; 5 Feb 2023 06:11:19 +0000 Received: from localhost ([127.0.0.1]:43851 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pOYFD-0003DU-24 for submit@debbugs.gnu.org; Sun, 05 Feb 2023 01:11:19 -0500 Received: from mail-ej1-f67.google.com ([209.85.218.67]:33728) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pOYFA-0003DB-0J for 59866-done@debbugs.gnu.org; Sun, 05 Feb 2023 01:11:16 -0500 Received: by mail-ej1-f67.google.com with SMTP id ml19so26107226ejb.0 for <59866-done@debbugs.gnu.org>; Sat, 04 Feb 2023 22:11:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id:from:to:cc:subject:date :message-id:reply-to; bh=goVjraSUa4fGeJArwkLMNIITf4M8S0XvdkGYISXSnb0=; b=ARjc6HS8wEVf1aWivIS9zmebAAOATtr8xwLTo5VbRqePSb6nfR5voTaUPtJ/fs5ITs ddaBNGcZ1uMBxwzMd1MR0QbAAfs2Ta4Vcb+WnkJ/d9KQq8EVFPZmx9qgitEjFgN06Xor 5n6QthC3oyy74CtwLWeseE6S4XZbutQFsbZdaKbUy+aanWvSKO5Ks1N+G5+qhTx/OBoe 59AMQzD6D2fgkdbevFWknfG5n7hqKe9Q+IaxllohrTC8dat463f7jJf73xDK8f8HmVr3 XtChkGtDLcN10T/V9PSbjxP5Z31lOEdl9St9bbu+uxpqdoTEqJWMPbtnLUPpuGfaeuNv JGug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=goVjraSUa4fGeJArwkLMNIITf4M8S0XvdkGYISXSnb0=; b=hd+dzOVzyp5lYjoit/8+I9XfK9p36yhrkiFUBM618GybkbA3rnjlu8p7DKtTA995RN huuzmCTrtmuwhprqejWOgp/0jPulG+3RV1IrP/wHPqeN5QCnnl7mSap12VUWN0aEM78m u1BXrDwCQFMvCIS0mu74YXMIbVdEiaULLeOoeXd8XwFSYmaemHhwOgIRCy+kD59HTamZ aji9CpPiU9QGQH5tpzGAThL32eRQNhQtpVGloy62zZWcH8P/qSRwYE3miZSScQgmm3K1 YCv1GSmLSW+yAe9xDfejiJwsFnc1emYWoomWAdCWW1lcRK5g3+CJ2povCdAhnGFp3mhr /5fg== X-Gm-Message-State: AO0yUKXXOeQhEXa1KkuEqBleQzGx3vvhHag9t/tgLaCbTcAsIxkIkSgs pdkH5Vw3A7DHqDRS5Wi/vWw= X-Google-Smtp-Source: AK7set/awmXtBxNhizVGtC9z1IKLvUImgq0hlqhQfpdcBcwOPB3BMzzyGkXfduqXPZQkvUMBAXjSYQ== X-Received: by 2002:a17:907:3e82:b0:85f:5d72:1841 with SMTP id hs2-20020a1709073e8200b0085f5d721841mr21176610ejc.39.1675577470076; Sat, 04 Feb 2023 22:11:10 -0800 (PST) Received: from lumine.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id a26-20020a17090640da00b0087851a76573sm3733737ejk.74.2023.02.04.22.11.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 04 Feb 2023 22:11:09 -0800 (PST) Message-ID: From: Liliana Marie Prikler Date: Sun, 05 Feb 2023 07:11:08 +0100 In-Reply-To: <88e71adf846525fbc1a964b24fb45e3e4b5c9208.camel@gmail.com> References: <23b0f83d1fd58fce9262d0b281b34e9678e21471.1675367583.git.mirai@makinata.eu> <88e71adf846525fbc1a964b24fb45e3e4b5c9208.camel@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.0 MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1675577558; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-to: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=goVjraSUa4fGeJArwkLMNIITf4M8S0XvdkGYISXSnb0=; b=QPFx9nX73GLR8JKUAeTUR/s4D36ge5wZASaDaXeY4PgVC3hjJuh+PewD/erRKIuqunIUOR 1aaeMqXbt3eKeU+i0Mq0Xk51K6omt5qe7zdWsFEa9T+VhcGrID64M3iK0JBj+rxFDy5yyM YderjwUpThBvZ8R81my2YUeBH0mWy6A1OHyXrZ8Vv4z78UXOi0JgS0h1ULW9faASPZLOpv 1sqjqC+WnR1b3HU5u4abfcXMuXPyizGHCYE+GDb0Jash1x3DumKv1EapUYJU7MexhmGiuJ w9F9ZkgsyqqNLTxk4bQXbvDqsxE9x4Lj5gt4pHZu0GAjh5lCS1GNzDr/57Xzdg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=ARjc6HS8; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1675577558; a=rsa-sha256; cv=none; b=PlzfNTEeyc5B4olXjmbCsZX3W5fVpxMEN18yxEvp1q8InLf8utF+I2TuD89vuGhU0W1X9Y 97vuJPrYzgEfyNvUggGDmJZJzQ4KPt6GL8KS6XzkqVaR8UMnR+sJy6sLV7yH2G9q0lQrCH TOTQNG88GBXRs4nWbra4jWiDrVi57J32oSfj19Lqkmy9BA+lCIMiZBBXUcXByWepHFDKz2 iCuYX+zPKkRHDxCVexichC4ai1nHKoAwh5EaQoCdellaz7xkXjuNNVHD1quR9AY12EFmCw 8ZC+c2+l60xYLGdMclO/zY7QflCt+ugEYd0qCaHYIm+Xa/4MDOksLLOZlhSsiw== X-Migadu-Queue-Id: 0E2C11010C X-Migadu-Scanner: scn0.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=ARjc6HS8; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 4.61 X-Spam-Score: 4.61 X-TUID: HbBmeoPUYS/6 Am Donnerstag, dem 02.02.2023 um 22:08 +0100 schrieb Liliana Marie Prikler: > Not a complete review yet, just some quick pointers. >=20 > Am Donnerstag, dem 02.02.2023 um 20:07 +0000 schrieb Bruno Victal: > > Refactor mpd-service-type to support additional mpd.conf directives > > and move activation-service-extension into service constructor. > >=20 > > * gnu/services/audio.scm > > (mpd-plugin, mpd-partition): New record. > No need to break the line before the paren here. >=20 > > (mpd-serialize-boolean, mpd-serialize-field): Integrate serializers > > into a single procedure for alist interop. > That's not a good docstring here.=C2=A0 I think=C2=A0 > =C2=A0 (mpd-serialize-boolean): Delete variable.=C2=A0 Move logic into... > =C2=A0 (mpd-serialize-field): ... this. > explains what's going on better. It actually didn't, because mpd-serialize-boolean wasn't deleted, but aliased. > > [...] > > =C2=A0=C2=A0 #:use-module (srfi srfi-1) > > +=C2=A0 #:use-module (srfi srfi-8) > > =C2=A0=C2=A0 #:use-module (srfi srfi-26) > We generally prefer SRFI 71. I fixed up the above, plus some compiler warnings and pushed it. Cheers