[bug#50397] [PATCH] gnu: Add python-crontab

[Pradana Adrinusa AUMARS via Guix-patches via <guix-patches@gnu.org>]

Le dimanche 05 septembre 2021 à 15:29 +0200, Xinglu Chen a écrit :
> On Sun, Sep 05 2021, Pradana Adrinusa AUMARS via Guix-patches via
> wrote:
> 
> > From 1a41d362dd97eae4c236c689bea871d0512c2f4d Mon Sep 17 00:00:00
> > 2001
> > From: Pradana AUMARS <paumars@courrier.dev>
> > Date: Sun, 5 Sep 2021 09:46:58 +0200
> > Subject: [PATCH] gnu: Add python-crontab
> > 
> > * gnu/packages/python-xyz.scm (python-crontab): New variable.
> > ---
> >  gnu/packages/python-xyz.scm | 23 +++++++++++++++++++++++
> >  1 file changed, 23 insertions(+)
> > 
> > diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-
> > xyz.scm
> > index 7c70829de9..bbc5bad51c 100644
> > --- a/gnu/packages/python-xyz.scm
> > +++ b/gnu/packages/python-xyz.scm
> > @@ -108,6 +108,7 @@
> >  ;;; Copyright © 2021 Franck Pérignon <
> > franck.perignon@univ-grenoble-alpes.fr>
> >  ;;; Copyright © 2021 Petr Hodina <phodina@protonmail.com>
> >  ;;; Copyright © 2021 Simon Streit <simon@netpanic.org>
> > +;;; Copyright © 2021 Pradana Aumars <paumars@courrier.dev>
> >  ;;;
> >  ;;; This file is part of GNU Guix.
> >  ;;;
> > @@ -26556,3 +26557,25 @@ files and directories and adds a datestamp
> > in standard ISO 8601+ format
> >  YYYY-MM-DD at the beginning of the file or directory name.")
> >        (home-page "https://github.com/novoid/date2name")
> >        (license license:gpl3+))))
> > +
> > +(define-public python-crontab
> > +  (package
> > +   (name "python-crontab")
> > +   (version "2.5.1")
> > +   (source
> > +    (origin
> > +     (method url-fetch)
> > +     (uri (pypi-uri name version))
> > +     (sha256
> > +      (base32
> > +       "0cccrqc10r8781ba81x8r2frs3pl2m4hkm599k5358ak0xr7xgjb"))))
> > +   (build-system python-build-system)
> > +   (arguments
> > +    `(#:tests? #f))
> 
> What’s the reason for disabling tests?  There is a test directory in
> the
> Git repo; maybe test tests aren’t included in the PyPi tarball?  If
> so,
> I would suggest using the Git repo instead.

Compatibility tests fail so they are disabled, they are also disabled
in the AUR so I assumed they are unnecessary.

> 
> > +   (native-inputs
> > +    `(("python-dateutil" ,python-dateutil)))
> > +   (synopsis "Module for reading and writing crontab files")
> > +   (description "Crontab module for reading and writing crontab
> > files and accessing the 
> > +system cron automatically and simply using a direct API.")
> 
> The description should consists of one or more complete sentences,
> see
> “16.4.4 Synopses and Descriptions” in the manual.  Maybe prefix the
> description with “This Python package provides a …”?
> 
>   This Python package provides a crontab module for reading and
> writing
>  crontab files and accessing the system cron automatically and simply
>  using a direct API.
> 
> Also, wrap lines at 80 characters.

Applied.

> 
> > +   (home-page "https://gitlab.com/doctormo/python-crontab/")
> > +   (license license:lgpl3+)))
> > -- 
> > 2.33.0
> 
> I am having some trouble applying the patch.
> 
> --8<---------------cut here---------------start------------->8---
> Applying: gnu: Add python-crontab
> error: sha1 information is lacking or useless (gnu/packages/python-
> xyz.scm).
> error: could not build fake ancestor
> hint: Use 'git am --show-current-patch=diff' to see the failed patch
> Patch failed at 0001 gnu: Add python-crontab
> When you have resolved this problem, run "git am --continue".
> If you prefer to skip this patch, run "git am --skip" instead.
> To restore the original branch and stop patching, run "git am --
> abort".
> --8<---------------cut here---------------end--------------->8---
> 
> Are you able to apply it to the ‘master’ branch, or is it just me?

My mistake. There was a trailing whitespace. This has been fixed.

I will send a new fixed patch.