[bug#27483] [PATCH] gnu: Add python-pass-git-helper.

[bug#27483] [PATCH] gnu: Add python-pass-git-helper.

[Jelle Licht]

* gnu/packages/password-utils.scm (python-pass-git-helper): New variable.
---
 gnu/packages/password-utils.scm | 36 ++++++++++++++++++++++++++++++++++++
 1 file changed, 36 insertions(+)

diff --git a/gnu/packages/password-utils.scm b/gnu/packages/password-utils.scm
index 9cfacdb42..55b6e2a04 100644
--- a/gnu/packages/password-utils.scm
+++ b/gnu/packages/password-utils.scm
@@ -37,6 +37,7 @@
   #:use-module (gnu packages aidc)
   #:use-module (gnu packages base)
   #:use-module (gnu packages compression)
+  #:use-module (gnu packages freedesktop)
   #:use-module (gnu packages glib)
   #:use-module (gnu packages gnupg)
   #:use-module (gnu packages gtk)
@@ -410,3 +411,38 @@ Password Scheme\"} by Niels Provos and David Mazieres.")
 
 (define-public python2-bcrypt
   (package-with-python2 python-bcrypt))
+
+(define-public python-pass-git-helper
+  (package
+    (name "python-pass-git-helper")
+    (version "0.3")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "pass-git-helper" version))
+       (sha256
+        (base32
+         "1zxzwljz8zqayd6dcai6y9qkj2ingbk89z20hqqvcr62a5bjks7v"))))
+    (build-system python-build-system)
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         (add-before 'build 'patch-pass-path
+                 (lambda* (#:key inputs #:allow-other-keys)
+                   (let* ((password-store (assoc-ref inputs "password-store"))
+                          (pass           (string-append password-store
+                                                         "/bin/pass")))
+                     (substitute* "pass-git-helper"
+                       (("'pass'") (string-append "'" pass "'")))
+                     #t))))))
+    (inputs
+     `(("python-pyxdg" ,python-pyxdg)
+       ("password-store" ,password-store)))
+    (home-page "https://github.com/languitar/pass-git-helper")
+    (synopsis "Git credential helper interfacing with pass")
+    (description
+     "A git credential helper implementation which allows to use pass, the
+standard unix password manager, as the credential backend for your git
+repositories.  This is achieved by explicitly defining mappings between hosts
+and entries in the password store.")
+    (license license:lgpl3)))
-- 
2.13.1

[bug#27483] [PATCH] gnu: Add python-pass-git-helper.

[Arun Isaac]

Thanks for the patch!

> +(define-public python-pass-git-helper
> +  (package
> +    (name "python-pass-git-helper")

Since, this is an application, not a python library, this package should
not have the "python-" prefix. It should just be called pass-git-helper.

> +    (version "0.3")

The latest version is 0.3.1. However, this is only available on the
project's github releases page. Could you try with that?

https://github.com/languitar/pass-git-helper/releases

> +    (description
> +     "A git credential helper implementation which allows to use pass, the
> +standard unix password manager, as the credential backend for your git
> +repositories.  This is achieved by explicitly defining mappings between hosts
> +and entries in the password store.")

Descriptions should use full sentences. Could you rephrase the first
sentence to comply?

https://www.gnu.org/software/guix/manual/html_node/Synopses-and-Descriptions.html

> +    (license license:lgpl3)))

The license is lgpl3+. Look at line 17 of setup.py.

Everything else LGTM. Could you send an updated patch?

[bug#27483] [PATCH] gnu: Add python-pass-git-helper.

[Jelle Licht]

[-- Attachment #1: Type: text/plain, Size: 1179 bytes --]



Arun Isaac <arunisaac@systemreboot.net> writes:
> Thanks for the patch!
>
>> +(define-public python-pass-git-helper
>> +  (package
>> +    (name "python-pass-git-helper")
>
> Since, this is an application, not a python library, this package should
> not have the "python-" prefix. It should just be called pass-git-helper.
>
>> +    (version "0.3")
>
> The latest version is 0.3.1. However, this is only available on the
> project's github releases page. Could you try with that?
>
> https://github.com/languitar/pass-git-helper/releases
>
>> +    (description
>> +     "A git credential helper implementation which allows to use pass, the
>> +standard unix password manager, as the credential backend for your git
>> +repositories.  This is achieved by explicitly defining mappings between hosts
>> +and entries in the password store.")
>
> Descriptions should use full sentences. Could you rephrase the first
> sentence to comply?
>
> https://www.gnu.org/software/guix/manual/html_node/Synopses-and-Descriptions.html
>
>> +    (license license:lgpl3)))
>
> The license is lgpl3+. Look at line 17 of setup.py.
>
> Everything else LGTM. Could you send an updated patch?

Done!

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-Add-pass-git-helper.patch --]
[-- Type: text/x-patch, Size: 2545 bytes --]

From 9b818abc4d313f42efa6f052830050b0e376a073 Mon Sep 17 00:00:00 2001
From: Jelle Licht <jlicht@fsfe.org>
Date: Sun, 25 Jun 2017 14:38:40 +0200
Subject: [PATCH] gnu: Add pass-git-helper.

* gnu/packages/password-utils.scm (pass-git-helper): New variable.
---
 gnu/packages/password-utils.scm | 37 +++++++++++++++++++++++++++++++++++++
 1 file changed, 37 insertions(+)

diff --git a/gnu/packages/password-utils.scm b/gnu/packages/password-utils.scm
index 9cfacdb42..bad52dd22 100644
--- a/gnu/packages/password-utils.scm
+++ b/gnu/packages/password-utils.scm
@@ -37,6 +37,7 @@
   #:use-module (gnu packages aidc)
   #:use-module (gnu packages base)
   #:use-module (gnu packages compression)
+  #:use-module (gnu packages freedesktop)
   #:use-module (gnu packages glib)
   #:use-module (gnu packages gnupg)
   #:use-module (gnu packages gtk)
@@ -410,3 +411,39 @@ Password Scheme\"} by Niels Provos and David Mazieres.")
 
 (define-public python2-bcrypt
   (package-with-python2 python-bcrypt))
+
+(define-public pass-git-helper
+  (package
+    (name "pass-git-helper")
+    (version "0.3.1")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "https://github.com/languitar/pass-git-helper/"
+                           "archive/release-" version ".tar.gz"))
+       (sha256
+        (base32
+         "0lz5ncy44pz7z1j2nnyildx8sq33zi3xvg5nkwg25n11nasqh2xn"))))
+    (build-system python-build-system)
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         (add-before 'build 'patch-pass-path
+                 (lambda* (#:key inputs #:allow-other-keys)
+                   (let* ((password-store (assoc-ref inputs "password-store"))
+                          (pass           (string-append password-store
+                                                         "/bin/pass")))
+                     (substitute* "pass-git-helper"
+                       (("'pass'") (string-append "'" pass "'")))
+                     #t))))))
+    (inputs
+     `(("python-pyxdg" ,python-pyxdg)
+       ("password-store" ,password-store)))
+    (home-page "https://github.com/languitar/pass-git-helper")
+    (synopsis "Git credential helper interfacing with pass")
+    (description
+     "pass-git-helper is a git credential helper which allows to use pass, the
+standard unix password manager, as the credential backend for your git
+repositories.  This is achieved by explicitly defining mappings between hosts
+and entries in the password store.")
+    (license license:lgpl3+)))
-- 
2.13.1

bug#27483: [PATCH] gnu: Add python-pass-git-helper.

[Arun Isaac]

Pushed! Thanks!

I added a copyright header for you, and made a few other minor stylistic
changes.