From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57077)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dPBGY-00040u-G1
	for guix-patches@gnu.org; Sun, 25 Jun 2017 13:24:07 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dPBGU-0004dn-J1
	for guix-patches@gnu.org; Sun, 25 Jun 2017 13:24:06 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:34847)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1dPBGU-0004dd-5Y
	for guix-patches@gnu.org; Sun, 25 Jun 2017 13:24:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dPBGT-0002o7-Vi
	for guix-patches@gnu.org; Sun, 25 Jun 2017 13:24:01 -0400
Subject: [bug#27483] [PATCH] gnu: Add python-pass-git-helper.
Resent-Message-ID: <handler.27483.B27483.149841138810695@debbugs.gnu.org>
Message-Id: <c5e215c5.AEEAMX9gutgAAAAAAAAAAAPNjeEAAAACwQwAAAAAAAW9WABZT_F4@mailjet.com>
MIME-Version: 1.0
From: Arun Isaac <arunisaac@systemreboot.net>
Date: Sun, 25 Jun 2017 22:52:44 +0530
In-reply-to: <20170625123947.5031-1-jlicht@fsfe.org>
References: <20170625123947.5031-1-jlicht@fsfe.org>
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Jelle Licht <jlicht@fsfe.org>
Cc: 27483@debbugs.gnu.org


Thanks for the patch!

> +(define-public python-pass-git-helper
> +  (package
> +    (name "python-pass-git-helper")

Since, this is an application, not a python library, this package should
not have the "python-" prefix. It should just be called pass-git-helper.

> +    (version "0.3")

The latest version is 0.3.1. However, this is only available on the
project's github releases page. Could you try with that?

https://github.com/languitar/pass-git-helper/releases

> +    (description
> +     "A git credential helper implementation which allows to use pass, t=
he
> +standard unix password manager, as the credential backend for your git
> +repositories.  This is achieved by explicitly defining mappings between =
hosts
> +and entries in the password store.")

Descriptions should use full sentences. Could you rephrase the first
sentence to comply?

https://www.gnu.org/software/guix/manual/html_node/Synopses-and-Description=
s.html

> +    (license license:lgpl3)))

The license is lgpl3+. Look at line 17 of setup.py.

Everything else LGTM. Could you send an updated patch?
=