unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Arun Isaac <arunisaac@systemreboot.net>
To: Jelle Licht <jlicht@fsfe.org>
Cc: 27483@debbugs.gnu.org
Subject: [bug#27483] [PATCH] gnu: Add python-pass-git-helper.
Date: Sun, 25 Jun 2017 22:52:44 +0530	[thread overview]
Message-ID: <c5e215c5.AEEAMX9gutgAAAAAAAAAAAPNjeEAAAACwQwAAAAAAAW9WABZT_F4@mailjet.com> (raw)
In-Reply-To: <20170625123947.5031-1-jlicht@fsfe.org>


Thanks for the patch!

> +(define-public python-pass-git-helper
> +  (package
> +    (name "python-pass-git-helper")

Since, this is an application, not a python library, this package should
not have the "python-" prefix. It should just be called pass-git-helper.

> +    (version "0.3")

The latest version is 0.3.1. However, this is only available on the
project's github releases page. Could you try with that?

https://github.com/languitar/pass-git-helper/releases

> +    (description
> +     "A git credential helper implementation which allows to use pass, the
> +standard unix password manager, as the credential backend for your git
> +repositories.  This is achieved by explicitly defining mappings between hosts
> +and entries in the password store.")

Descriptions should use full sentences. Could you rephrase the first
sentence to comply?

https://www.gnu.org/software/guix/manual/html_node/Synopses-and-Descriptions.html

> +    (license license:lgpl3)))

The license is lgpl3+. Look at line 17 of setup.py.

Everything else LGTM. Could you send an updated patch?

  reply	other threads:[~2017-06-25 17:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-25 12:39 [bug#27483] [PATCH] gnu: Add python-pass-git-helper Jelle Licht
2017-06-25 17:22 ` Arun Isaac [this message]
     [not found] ` <1205d2af.AEEAMX9gutkAAAAAAAAAAAPFxFYAAAACwQwAAAAAAAW9WABZT_F4@mailjet.com>
2017-06-25 17:56   ` Jelle Licht
2017-06-25 20:45     ` bug#27483: " Arun Isaac

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c5e215c5.AEEAMX9gutgAAAAAAAAAAAPNjeEAAAACwQwAAAAAAAW9WABZT_F4@mailjet.com \
    --to=arunisaac@systemreboot.net \
    --cc=27483@debbugs.gnu.org \
    --cc=jlicht@fsfe.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).