From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:50528) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hqC59-0003yR-Bn for guix-patches@gnu.org; Wed, 24 Jul 2019 03:53:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hqC58-0004BQ-1V for guix-patches@gnu.org; Wed, 24 Jul 2019 03:53:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:55370) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hqC57-0004BD-Pt for guix-patches@gnu.org; Wed, 24 Jul 2019 03:53:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hqC57-0003Pc-N9 for guix-patches@gnu.org; Wed, 24 Jul 2019 03:53:01 -0400 Subject: [bug#36440] [PATCH] Add FreeCAD Resent-Message-ID: References: <20190722161120.36fd0942@alma-ubu> From: Jonathan Brielmaier Message-ID: Date: Wed, 24 Jul 2019 09:52:32 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: John Soo Cc: 36440@debbugs.gnu.org I didn't build all the packages, because it failed to apply them on top of current master. Did you rebased it on current master? I only comment where I "know" something... On 7/23/19 6:25 PM, John Soo wrote: > ** Coin3D > > *** DONE Delete blobs > > *** hg-fetch deletes .hg dirs (and all submodules' .hg dirs) - Usually the (arguments) section is right after the (build-system...) but this is more optical :P - Wikipedia uses https://bitbucket.org/Coin3D/coin/src but I think the link to their wiki https://bitbucket.org/Coin3D/coin/wiki/Home is even better :) > ** SoQT vs. Quarter > > *** Not interchangeable as far as I know. > > *** FreeCAD requires SoQT specifically during configure. Do we really need SoQT? Neither openSUSE https://build.opensuse.org/package/show/science/FreeCAD nor ArchLinux https://aur.archlinux.org/packages/freecad/ depending on SoQT > ** Pyside2 > > *** Does all of pyside2 belong in qt.scm? - there are three packages: > Shiboken2, Pyside2, and Pyside2-Tools qt.scm does already include python and python-xyz, so from this side it's not a problem. If pyside* would be used by non QT projects, which also doesn't depend on QT it would be good to have it in python-xyz module, but I don't think that is the case. So leave them in qt.scm :) python-shiboken-2 Maybe leave a comment that it's a source inside of pyside-setup, because the first repo I found was this :) https://code.qt.io/cgit/pyside/shiboken.git/ pyside-2-tools: - Maybe elaborate a bit more in the description, I have no idead what "lupdate, rcc and uic" is :P - Is there a reason why we don't run the tests? python-pyside-2: - No newlines in the description after a sentence, just two whitespaces :) > ** libmedfile - description: What is a MED file? > *** Reason for old version is that what was released when I started > > *** 4.0.0 requires hdf5 >=3D 1.10.2 > > **** HDF5 has some dependents: > > guix refresh --list-dependent hdf5 Building the following 11 packages wo= uld > ensure 23 dependent packages are rebuilt: > r-ioniser@2.8.0 r-scone@1.8.0 r-lumi@2.36.0 r-yarn@1.10.0 > r-illuminahumanmethylationepicmanifest@0.3.0 r-scdd@1.8.0 pigx@0.0.3 > r-pore@0.24 r-yamss@1.10.0 r-xcms@3.6.1 r-msnid@1.18.0 20 rebuilds is not a problem. > **** HDF5 patches need updates when HDF5 updated to 1.10.5 So they don't apply anymore at the moment? > ** Using releases over hg/git downloads (please advise) > > 1. Pyside2 packages - Done for compatibility reasons > 2. Coin3D and SoQt - I don't think there are releases of these aside fro= m > the bitbucket repository. https://bitbucket.org/Coin3D/coin/downloads/ > 3. LLVM propagated packages (llvm-toolchain and pyside-libcxx-headers) > - I am not sure these are the best way to accomplish the goal anyways. > - Not sure where to find the right sources for llvm-toolchain-6 and the > pyside-libcxx-headers. > 4. libarea - Seems like libarea is actually close to not even having sou= rce > available anymore, let alone a release > 5. libspnav - Confused as to the best source to use here. If there is a > release or better version, I can update. This one: https://git.archlinux.org/svntogit/packages.git/tree/trunk/PKGBUILD?h=3Dpa= ckages/libspnav#n13 > 6. FreeCAD > - I can use the releases if they exist. I do not think they have source > tarballs available. > - I was packaging during a lot of active development of FreeCAD > > Thank you for your review and advice. That's it from me at the moment. Strong work! Keep it up :) ~Jonathan