From: Maxime Devos <maximedevos@telenet.be>
To: 51072@debbugs.gnu.org, Foo Chuan Wei <chuanwei.foo@hotmail.com>
Subject: [bug#51072] [PATCH] gnu: Add Weka
Date: Sun, 30 Oct 2022 16:34:32 +0100 [thread overview]
Message-ID: <c5443a52-60f1-f05f-7a76-eb5e54d95fa0@telenet.be> (raw)
In-Reply-To: <PU1PR01MB2155201726E55A5FC0EE82DF8DB19@PU1PR01MB2155.apcprd01.prod.exchangelabs.com>
[-- Attachment #1.1.1: Type: text/plain, Size: 1674 bytes --]
>+ (uri
"mirror://sourceforge/weka/weka-3-9/3.9.5/weka-3-9-5.zip")
These isn't source code, these are binaries (*). With the exception of
the bootstrap seeds, things in Guix must be built from source (and even
then, we still can build them from source, with "guix build
bootstrap-tarballs").
Looking at the git repository, it appears to use Ant, and we have an
ant-build-system, so unless there are complicated dependencies, it
should be feasible.
>+ (native-inputs `(("unzip" ,unzip)))
>+ (inputs `(("jre" ,icedtea)))
Nowadays you can avoid input labels with (native-inputs (list unzip))
and (inputs (list icedtea)).
>+ (display
>+ (string-append
>+ "#!/bin/sh\n\n"
>+ (assoc-ref inputs "jre") "/bin/java -jar "
>+ out "/share/weka/weka.jar \"$@\"\n"))))
>+ (chmod wrapper #o555))
Do (search-input-file inputs "bin/java") to avoid depending on input
labels. Also, you are using /bin/sh (which IIUC will be patched to
/gnu/store/.../bin/sh), but for such patching to work, you need to have
bash-minimal (or bash) in the inputs -- while bash-minimal is an
implicit (native-)input of many build systems, it isn't a regular
implicit input, at least for copy-build-system, so this wouldn't work
when cross-compiling, so I propose to add bash-minimal to the inputs.
> + #t)))))
Trailing #t are obsolete nowadays.
(*) At least, I expect them to be; the download is in-progress.
Greetings,
Maxime.
[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 929 bytes --]
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]
prev parent reply other threads:[~2022-10-30 15:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-07 8:42 [bug#51072] [PATCH] gnu: Add Weka Foo Chuan Wei
2022-10-30 15:34 ` Maxime Devos [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c5443a52-60f1-f05f-7a76-eb5e54d95fa0@telenet.be \
--to=maximedevos@telenet.be \
--cc=51072@debbugs.gnu.org \
--cc=chuanwei.foo@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).